Home
last modified time | relevance | path

Searched hist:"0 ab03c2b1478f2438d2c80204f7fef65b1bca9cf" (Results 1 – 5 of 5) sorted by relevance

/openbmc/linux/net/ipv4/
H A Dinet_diag.cdiff b8f3ab4290f1e720166e888ea2a1d1d44c4d15dd Tue Jan 18 14:40:38 CST 2011 David S. Miller <davem@davemloft.net> Revert "netlink: test for all flags of the NLM_F_DUMP composite"

This reverts commit 0ab03c2b1478f2438d2c80204f7fef65b1bca9cf.

It breaks several things including the avahi daemon.

Signed-off-by: David S. Miller <davem@davemloft.net>
diff 0ab03c2b1478f2438d2c80204f7fef65b1bca9cf Thu Jan 06 21:15:05 CST 2011 Jan Engelhardt <jengelh@medozas.de> netlink: test for all flags of the NLM_F_DUMP composite

Due to NLM_F_DUMP is composed of two bits, NLM_F_ROOT | NLM_F_MATCH,
when doing "if (x & NLM_F_DUMP)", it tests for _either_ of the bits
being set. Because NLM_F_MATCH's value overlaps with NLM_F_EXCL,
non-dump requests with NLM_F_EXCL set are mistaken as dump requests.

Substitute the condition to test for _all_ bits being set.

Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
/openbmc/linux/net/netlink/
H A Dgenetlink.cdiff b8f3ab4290f1e720166e888ea2a1d1d44c4d15dd Tue Jan 18 14:40:38 CST 2011 David S. Miller <davem@davemloft.net> Revert "netlink: test for all flags of the NLM_F_DUMP composite"

This reverts commit 0ab03c2b1478f2438d2c80204f7fef65b1bca9cf.

It breaks several things including the avahi daemon.

Signed-off-by: David S. Miller <davem@davemloft.net>
diff 0ab03c2b1478f2438d2c80204f7fef65b1bca9cf Thu Jan 06 21:15:05 CST 2011 Jan Engelhardt <jengelh@medozas.de> netlink: test for all flags of the NLM_F_DUMP composite

Due to NLM_F_DUMP is composed of two bits, NLM_F_ROOT | NLM_F_MATCH,
when doing "if (x & NLM_F_DUMP)", it tests for _either_ of the bits
being set. Because NLM_F_MATCH's value overlaps with NLM_F_EXCL,
non-dump requests with NLM_F_EXCL set are mistaken as dump requests.

Substitute the condition to test for _all_ bits being set.

Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
/openbmc/linux/net/xfrm/
H A Dxfrm_user.cdiff b8f3ab4290f1e720166e888ea2a1d1d44c4d15dd Tue Jan 18 14:40:38 CST 2011 David S. Miller <davem@davemloft.net> Revert "netlink: test for all flags of the NLM_F_DUMP composite"

This reverts commit 0ab03c2b1478f2438d2c80204f7fef65b1bca9cf.

It breaks several things including the avahi daemon.

Signed-off-by: David S. Miller <davem@davemloft.net>
diff 0ab03c2b1478f2438d2c80204f7fef65b1bca9cf Thu Jan 06 21:15:05 CST 2011 Jan Engelhardt <jengelh@medozas.de> netlink: test for all flags of the NLM_F_DUMP composite

Due to NLM_F_DUMP is composed of two bits, NLM_F_ROOT | NLM_F_MATCH,
when doing "if (x & NLM_F_DUMP)", it tests for _either_ of the bits
being set. Because NLM_F_MATCH's value overlaps with NLM_F_EXCL,
non-dump requests with NLM_F_EXCL set are mistaken as dump requests.

Substitute the condition to test for _all_ bits being set.

Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
/openbmc/linux/net/netfilter/
H A Dnf_conntrack_netlink.cdiff b8f3ab4290f1e720166e888ea2a1d1d44c4d15dd Tue Jan 18 14:40:38 CST 2011 David S. Miller <davem@davemloft.net> Revert "netlink: test for all flags of the NLM_F_DUMP composite"

This reverts commit 0ab03c2b1478f2438d2c80204f7fef65b1bca9cf.

It breaks several things including the avahi daemon.

Signed-off-by: David S. Miller <davem@davemloft.net>
diff 0ab03c2b1478f2438d2c80204f7fef65b1bca9cf Thu Jan 06 21:15:05 CST 2011 Jan Engelhardt <jengelh@medozas.de> netlink: test for all flags of the NLM_F_DUMP composite

Due to NLM_F_DUMP is composed of two bits, NLM_F_ROOT | NLM_F_MATCH,
when doing "if (x & NLM_F_DUMP)", it tests for _either_ of the bits
being set. Because NLM_F_MATCH's value overlaps with NLM_F_EXCL,
non-dump requests with NLM_F_EXCL set are mistaken as dump requests.

Substitute the condition to test for _all_ bits being set.

Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
/openbmc/linux/net/core/
H A Drtnetlink.cdiff b8f3ab4290f1e720166e888ea2a1d1d44c4d15dd Tue Jan 18 14:40:38 CST 2011 David S. Miller <davem@davemloft.net> Revert "netlink: test for all flags of the NLM_F_DUMP composite"

This reverts commit 0ab03c2b1478f2438d2c80204f7fef65b1bca9cf.

It breaks several things including the avahi daemon.

Signed-off-by: David S. Miller <davem@davemloft.net>
diff 0ab03c2b1478f2438d2c80204f7fef65b1bca9cf Thu Jan 06 21:15:05 CST 2011 Jan Engelhardt <jengelh@medozas.de> netlink: test for all flags of the NLM_F_DUMP composite

Due to NLM_F_DUMP is composed of two bits, NLM_F_ROOT | NLM_F_MATCH,
when doing "if (x & NLM_F_DUMP)", it tests for _either_ of the bits
being set. Because NLM_F_MATCH's value overlaps with NLM_F_EXCL,
non-dump requests with NLM_F_EXCL set are mistaken as dump requests.

Substitute the condition to test for _all_ bits being set.

Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>