Searched hist:"0780 ec7be82dd4781e9fd216b5d99a125882ff5a" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/qemu/ui/ |
| H A D | vnc.c | diff 0780ec7be82dd4781e9fd216b5d99a125882ff5a Tue Jan 21 00:02:10 CST 2020 Gerd Hoffmann <kraxel@redhat.com> Revert "vnc: allow fall back to RAW encoding"
This reverts commit de3f7de7f4e257ce44cdabb90f5f17ee99624557.
Remove VNC optimization to reencode framebuffer update as raw if it's
smaller than the default encoding.
QEMU's implementation was naive and didn't account for the ZLIB z_stream
mutating with each compression. Because of the mutation, simply
resetting the output buffer's offset wasn't sufficient to "rewind" the
operation. The mutated z_stream would generate future zlib blocks which
referred to symbols in past blocks which weren't sent. This would lead
to artifacting.
Considering that ZRLE is never larger than raw and even though ZLIB can
occasionally be fractionally larger than raw, the overhead of
implementing this optimization correctly isn't worth it.
Signed-off-by: Cameron Esfahani <dirty@apple.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
|