Searched hist:"0448 d38c1e8cd64fb2fa88f44cbc7c3dcf75ed6c" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/linux/drivers/usb/gadget/function/ |
| H A D | f_hid.c | diff 0448d38c1e8cd64fb2fa88f44cbc7c3dcf75ed6c Thu Nov 13 00:20:59 CST 2014 Dan Carpenter <dan.carpenter@oracle.com> usb: gadget: f_hid: fix error handling in ghid_setup()
There were a two issues here.
1) We returned PTR_ERR(NULL) which means success if class_create()
failed.
2) If alloc_chrdev_region() failed then we should clean up before
returning.
Also kernel style is to have "error handling" as opposed to "success
handling". In the original code checking for "if (!status) " is
confusing and this bad style is what lead to bug #2.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
|