Searched hist:"002 cdb95dc398919bd37d3228c677a22c5ca1498" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/linux/drivers/input/keyboard/ |
| H A D | gpio_keys.c | diff 002cdb95dc398919bd37d3228c677a22c5ca1498 Tue Jun 18 19:17:13 CDT 2019 Gustavo A. R. Silva <gustavo@embeddedor.com> Input: gpio_keys - use struct_size() in devm_kzalloc()
One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:
struct gpio_keys_drvdata {
...
struct gpio_button_data data[0];
};
size = sizeof(struct gpio_keys_drvdata) + count * sizeof(struct gpio_button_data);
instance = devm_kzalloc(dev, size, GFP_KERNEL);
Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:
instance = devm_kzalloc(dev, struct_size(instance, data, count), GFP_KERNEL);
Notice that, in this case, variable size is not necessary, hence it
is removed.
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
|