d55c8159 | 15-Jan-2018 |
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> |
nand: arasan: Select CONFIG_SYS_NAND_SELF_INIT
The Arasan NFC driver requires the self-init mode, so it should select it.
Instead of having the config header define the macro, it's cleaner to selec
nand: arasan: Select CONFIG_SYS_NAND_SELF_INIT
The Arasan NFC driver requires the self-init mode, so it should select it.
Instead of having the config header define the macro, it's cleaner to select the option at the Kconfig level.
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
show more ...
|
f25ac66c | 04-Jan-2018 |
Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com> |
nand: arasan_nfc: Use the calculated ecc address for updating ecc register
This patch corrects the ecc address calculation before updating to ecc register. The ecc address has to be calculated based
nand: arasan_nfc: Use the calculated ecc address for updating ecc register
This patch corrects the ecc address calculation before updating to ecc register. The ecc address has to be calculated based on page, oob and ecc sizes of the device.
Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
show more ...
|
cacb8a02 | 04-Jan-2018 |
Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com> |
nand: arasan_nfc: Add support for ondie ecc
This patch adds support for ondie ecc. As of now this adds support for micron parts which supports ondie ecc. Didn't found any better way to detect ondie
nand: arasan_nfc: Add support for ondie ecc
This patch adds support for ondie ecc. As of now this adds support for micron parts which supports ondie ecc. Didn't found any better way to detect ondie ecc support by a device except sorting out with manufacture and device id's.
Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
show more ...
|
d9a35697 | 26-Jan-2018 |
Mario Six <mario.six@gdsys.cc> |
cfi_flash: Always define cfi_flash_num_flash_banks
The variable cfi_flash_num_flash_banks is defined iff CONFIG_SYS_MAX_FLASH_BANKS_DETECT is defined, but it is used unconditionally in the function
cfi_flash: Always define cfi_flash_num_flash_banks
The variable cfi_flash_num_flash_banks is defined iff CONFIG_SYS_MAX_FLASH_BANKS_DETECT is defined, but it is used unconditionally in the function cfi_flash_init_dm. This leads to a undefined variable compile error when CONFIG_SYS_MAX_FLASH_BANKS_DETECT is not defined, but DM is enabled.
Fix this by always defining the cfi_flash_num_flash_banks variable.
Signed-off-by: Mario Six <mario.six@gdsys.cc> Signed-off-by: Stefan Roese <sr@denx.de>
show more ...
|
c0350fbf | 26-Jan-2018 |
Mario Six <mario.six@gdsys.cc> |
cfi_flash: Fix indention
When long expressions surrounded by parentheses are split into multiple lines, each consecutive line should be aligned with the corresponding parenthesis. Fix all instances
cfi_flash: Fix indention
When long expressions surrounded by parentheses are split into multiple lines, each consecutive line should be aligned with the corresponding parenthesis. Fix all instances where this occurs.
Signed-off-by: Mario Six <mario.six@gdsys.cc> Signed-off-by: Stefan Roese <sr@denx.de>
show more ...
|
ddcf0540 | 26-Jan-2018 |
Mario Six <mario.six@gdsys.cc> |
cfi_flash: Fix long lines
Long lines (>80 characters) should be avoided where possible. Break up some long lines where it's not detrimental to readability.
Signed-off-by: Mario Six <mario.six@gdsys
cfi_flash: Fix long lines
Long lines (>80 characters) should be avoided where possible. Break up some long lines where it's not detrimental to readability.
Signed-off-by: Mario Six <mario.six@gdsys.cc> Signed-off-by: Stefan Roese <sr@denx.de>
show more ...
|
5701ba82 | 26-Jan-2018 |
Mario Six <mario.six@gdsys.cc> |
cfi_flash: Bound-check index before array access
In a while loop in cfi_flash.c the array "start" is accessed at the index "sector" before the index variable "sector" is bounds-checked, which might
cfi_flash: Bound-check index before array access
In a while loop in cfi_flash.c the array "start" is accessed at the index "sector" before the index variable "sector" is bounds-checked, which might lead to accesses beyond the bounds of the array.
Swap the order of the checks in the "&&" expression, so that the short-circuit evaluation prevents out-of-bounds array accesses.
Signed-off-by: Mario Six <mario.six@gdsys.cc> Signed-off-by: Stefan Roese <sr@denx.de>
show more ...
|
9dbaebcf | 26-Jan-2018 |
Mario Six <mario.six@gdsys.cc> |
flash: Fix spelling of "ERR_TIMOUT"
checkpatch.pl complains about the spelling of ERR_TIMOUT. Since the error is only used in a handful of files, we rename the error to ERR_TIMEOUT.
Signed-off-by:
flash: Fix spelling of "ERR_TIMOUT"
checkpatch.pl complains about the spelling of ERR_TIMOUT. Since the error is only used in a handful of files, we rename the error to ERR_TIMEOUT.
Signed-off-by: Mario Six <mario.six@gdsys.cc> Signed-off-by: Stefan Roese <sr@denx.de>
show more ...
|
c8a9a82c | 26-Jan-2018 |
Mario Six <mario.six@gdsys.cc> |
cfi_flash: Rename camel-case variables
Camel-case naming should be avoided. Rename two camel-case variables, and fix their usage accordingly.
Signed-off-by: Mario Six <mario.six@gdsys.cc> Signed-of
cfi_flash: Rename camel-case variables
Camel-case naming should be avoided. Rename two camel-case variables, and fix their usage accordingly.
Signed-off-by: Mario Six <mario.six@gdsys.cc> Signed-off-by: Stefan Roese <sr@denx.de>
show more ...
|
876c52f3 | 26-Jan-2018 |
Mario Six <mario.six@gdsys.cc> |
cfi_flash: Fix strings split across lines
Strings should not be split accross multiple lines. Where possible and not detrimental to readability, fix the instances where this occurs.
Signed-off-by:
cfi_flash: Fix strings split across lines
Strings should not be split accross multiple lines. Where possible and not detrimental to readability, fix the instances where this occurs.
Signed-off-by: Mario Six <mario.six@gdsys.cc> Signed-off-by: Stefan Roese <sr@denx.de>
show more ...
|
5312838d | 26-Jan-2018 |
Mario Six <mario.six@gdsys.cc> |
cfi_flash: Use u8 pointers instead of void pointers
According to the C standard, pointer arithmetic for pointers of type void is undefined behavior (the assumption that they're 8-bit wide is a GCC-s
cfi_flash: Use u8 pointers instead of void pointers
According to the C standard, pointer arithmetic for pointers of type void is undefined behavior (the assumption that they're 8-bit wide is a GCC-specific assumption). In the interest of keeping the code standards-compliant, and also better communicate intent, switch all void* variables where pointer arithmetic is used to u8* variables.
Signed-off-by: Mario Six <mario.six@gdsys.cc> Signed-off-by: Stefan Roese <sr@denx.de>
show more ...
|
d3525b6b | 26-Jan-2018 |
Mario Six <mario.six@gdsys.cc> |
cfi_flash: Remove assignments from if conditions
The condition in if statements should not be used for variable assignment. Instead, the assignment should be done in a separate step beforehand. Fix
cfi_flash: Remove assignments from if conditions
The condition in if statements should not be used for variable assignment. Instead, the assignment should be done in a separate step beforehand. Fix all instances where this occurs.
Signed-off-by: Mario Six <mario.six@gdsys.cc> Signed-off-by: Stefan Roese <sr@denx.de>
show more ...
|
0cec0a12 | 26-Jan-2018 |
Mario Six <mario.six@gdsys.cc> |
cfi_flash: Fix placement of brace
The opening brace of block statements should be attached to the statement itself, and not be on a separate line.
Signed-off-by: Mario Six <mario.six@gdsys.cc> Sign
cfi_flash: Fix placement of brace
The opening brace of block statements should be attached to the statement itself, and not be on a separate line.
Signed-off-by: Mario Six <mario.six@gdsys.cc> Signed-off-by: Stefan Roese <sr@denx.de>
show more ...
|
9860137f | 26-Jan-2018 |
Mario Six <mario.six@gdsys.cc> |
cfi_flash: Fix else after break
If in a loop, the if block in a if/else statement ends in a break, the statements in the else blockcan be extracted, since the break stops the execution.
Signed-off-
cfi_flash: Fix else after break
If in a loop, the if block in a if/else statement ends in a break, the statements in the else blockcan be extracted, since the break stops the execution.
Signed-off-by: Mario Six <mario.six@gdsys.cc> Signed-off-by: Stefan Roese <sr@denx.de>
show more ...
|
12d7fed9 | 26-Jan-2018 |
Mario Six <mario.six@gdsys.cc> |
cfi_flash: Add missing braces in blocks
In if/else statements, either both blocks (if and else) should have braces or both blocks should not have braces, but mixed configurations are discouraged. Fi
cfi_flash: Add missing braces in blocks
In if/else statements, either both blocks (if and else) should have braces or both blocks should not have braces, but mixed configurations are discouraged. Fix all instances where this occurs.
Signed-off-by: Mario Six <mario.six@gdsys.cc> Signed-off-by: Stefan Roese <sr@denx.de>
show more ...
|
4f89da49 | 26-Jan-2018 |
Mario Six <mario.six@gdsys.cc> |
cfi_flash: Remove unnecessary braces
"==" and "!=" bind tighter than the boolean operators, so parentheses around them in compound logical statements are unnecessary. Fix all instances where this oc
cfi_flash: Remove unnecessary braces
"==" and "!=" bind tighter than the boolean operators, so parentheses around them in compound logical statements are unnecessary. Fix all instances where this occurs.
Signed-off-by: Mario Six <mario.six@gdsys.cc> Signed-off-by: Stefan Roese <sr@denx.de>
show more ...
|
a6d18f27 | 26-Jan-2018 |
Mario Six <mario.six@gdsys.cc> |
cfi_flash: Fix comment style
Comment blocks should end with a "*/" on a separate line, not with the "*/" attached to the end of the last line of text. Fix all instances where this occurs.
Signed-of
cfi_flash: Fix comment style
Comment blocks should end with a "*/" on a separate line, not with the "*/" attached to the end of the last line of text. Fix all instances where this occurs.
Signed-off-by: Mario Six <mario.six@gdsys.cc> Signed-off-by: Stefan Roese <sr@denx.de>
show more ...
|