#
4148f2ee |
| 29-Jan-2020 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Create profile settings page
Adding a profile settings page so readonly and operator roles are able to change their own password.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id
Create profile settings page
Adding a profile settings page so readonly and operator roles are able to change their own password.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Iee9536255ad47f4df4af8746c1e01da37c407f2b
show more ...
|
#
f2127efa |
| 10-Dec-2019 |
Wiktor Gołgowski <wiktor.golgowski@intel.com> |
User logged in when IsAuthenticated cookie is set.
Related to https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/27270
Currently the only condition checked when user is logged in was the "LOGIN_
User logged in when IsAuthenticated cookie is set.
Related to https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/27270
Currently the only condition checked when user is logged in was the "LOGIN_ID" value in browser session storage. The only place in the code where it is set is the Basic Authorization flow.
In case of mTLS authentication, we are not able to set session storage value. This is why additional 'IsAuthenticated' cookie is added.
In the case when user session expires, the failing XHR should cause the page to redirect to the login prompt. Additionally, IsAuthenticated cookie is removed to disable redirection.
Tested: verified the flow with the mTLS changes. User is put in the webUI interface without login prompt when using mTLS authentication. If the authentication fails, browser redirects to the login page.
Signed-off-by: Wiktor Gołgowski <wiktor.golgowski@intel.com> Change-Id: Ia7061f3e146c6547d4bfdf42940150b1a5c06903
show more ...
|
#
5fcee5ab |
| 19-Nov-2019 |
Dixsie Wolmers <dixsiew@gmail.com> |
Add file upload component
Created reusuable file upload component to be used on updated firmware page. Component can: -Upload file -Display status icon -Clear upload field
Made minor style change t
Add file upload component
Created reusuable file upload component to be used on updated firmware page. Component can: -Upload file -Display status icon -Clear upload field
Made minor style change to file upload on certificate management.
Tested in GUI.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I09bf56eee4d670681ea5e95c1807f8177c0e4c08
show more ...
|
#
0d11902c |
| 04-Nov-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Create alert banner component
This reusuable component will help to make sure banner implementations are consistent and will help reduce redundant code.
Signed-off-by: Yoshie Muranaka <yoshiemurana
Create alert banner component
This reusuable component will help to make sure banner implementations are consistent and will help reduce redundant code.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I3a16f65d36c2d61abf54c300e2ed5defeadee298
show more ...
|
#
1ab0f7c1 |
| 24-Oct-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Create firmware-card component
Create reusable firmware card component that will be used in the updated firmware page: https://ibm.invisionapp.com/share/4XNZ0JAMJ7B#/screens/319212821_4-8-D-1_Home
Create firmware-card component
Create reusable firmware card component that will be used in the updated firmware page: https://ibm.invisionapp.com/share/4XNZ0JAMJ7B#/screens/319212821_4-8-D-1_Home
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I86e526c59ac5c2e2c011aed0ce4bc3d82db63b5e
show more ...
|
#
5e930c0a |
| 16-Oct-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Update toast notification
Added new toast notification types, warn and info, and updated visual styling. All toasts will need to be manually closed by clicking the 'X' close icon, except a success t
Update toast notification
Added new toast notification types, warn and info, and updated visual styling. All toasts will need to be manually closed by clicking the 'X' close icon, except a success toast which will be dismissed automatically after 10 secs.
- Small updates to critical and success/on icon - Added new colors for toast status background colors
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I9077109042621b2d3346b4121d6344da502b6b26
show more ...
|
#
bea45d53 |
| 27-Sep-2019 |
Dixsie Wolmers <dixsiew@gmail.com> |
Update KVM layout and add open in new window functionality
-Adds heading with new layout consistency class name -Adds open in new window functionality
Resolves: openbmc/phosphor-webui#81
Tested on
Update KVM layout and add open in new window functionality
-Adds heading with new layout consistency class name -Adds open in new window functionality
Resolves: openbmc/phosphor-webui#81
Tested on a Witherspoon with power on and with build that allows up to 4 kvm sessions connected at a time https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/25231.
KVM console loads in firefox, chrome, safari, edge and IE11. Opening new window and returning to parent window is functional across all browsers.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I32cda025bdd459740ca2b42d573b431fac687860
show more ...
|
#
4b366b5a |
| 24-Sep-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Clean up icons
Clean up duplicate svg icons from assets directory. Created a statusIcon component to dynamically render status icons instead of using background-image in scss files.
- Moved/removed
Clean up icons
Clean up duplicate svg icons from assets directory. Created a statusIcon component to dynamically render status icons instead of using background-image in scss files.
- Moved/removed on, off, critical, warning svg icons from assets directory - Updated background-image status icons to use <icon> or <status-icon> directive
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Ic0f06d78b0861d6f60d40b2dcc0b80fd6dad2a88
show more ...
|
#
198ce1ff |
| 20-Sep-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Fix SoL and KVM refresh bug
Clicking the refresh button in the app header on the SoL and KVM pages would fail to reload because the wrong element reference is passed to the contructor after the relo
Fix SoL and KVM refresh bug
Clicking the refresh button in the app header on the SoL and KVM pages would fail to reload because the wrong element reference is passed to the contructor after the reload. Angular recommends using directives for any DOM manipulation.
- Use the $element ref availble in serial-console.js directive to select DOM element to open the terminal - Switch kvm controller to directive to be able to use element ref in the link function to select DOM element to pass as target
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Ia7391e42bf335b8c3558d25df15c052db245ee3d
show more ...
|
#
afc8a799 |
| 17-Jun-2019 |
miramurali23 <miramurali23@gmail.com> |
Update users navigation section
- Changed the section name to be access-control - Moved LDAP Settings and Certificate Management to access-control navigation - Changed Manage User Account subsection
Update users navigation section
- Changed the section name to be access-control - Moved LDAP Settings and Certificate Management to access-control navigation - Changed Manage User Account subsection name to Local User Management
Resolves: openbmc/phosphor-webui#619
Signed-off-by: Mira Murali <miramurali23@gmail.com> Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I0d94c80c295b997d94c04330fd87f4fc4d229bf8
show more ...
|
#
5e258e43 |
| 07-Nov-2018 |
beccabroek <beccabroek@gmail.com> |
LDAP configuration and user groups
Adds LDAP page and ability to add and change configuration settings. Adds ability to add, remove and edit user groups for LDAP.
Resolves openbmc/phosphor-webui#38
LDAP configuration and user groups
Adds LDAP page and ability to add and change configuration settings. Adds ability to add, remove and edit user groups for LDAP.
Resolves openbmc/phosphor-webui#38 Resolves openbmc/phosphor-webui#39
Tested: Loaded on to a witherspoon and able to add initial LDAP config as well us update the configuration and role groups. Appropriate messages displayed to user when required fields are missing or in the incorrect format.
Change-Id: If8a21f3f9d9334415ead73472e90b2a0823bf9ea Signed-off-by: beccabroek <beccabroek@gmail.com> Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Signed-off-by: Derick Montague <derick.montague@ibm.com>
show more ...
|
#
5b8cef81 |
| 10-Sep-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add batch action functionality to table Component
These changes aren't currently implemented on any table. It will be added to event logs and local user table.
- Create tableCheckbox component to h
Add batch action functionality to table Component
These changes aren't currently implemented on any table. It will be added to event logs and local user table.
- Create tableCheckbox component to handle custom styles and indeterminate state which needs to be set with JS - Update tableComponent layout to allow transition for toolbar. Updated user-accounts layout and styles to account for these changes
Tested on Chrome, Safari, Firefox, Edge, IE
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Ic57a090db1ef66f9d33facfdc425db868ae8d8c6
show more ...
|
#
418db63c |
| 19-Sep-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Move Virtual Media files and route
"Virtual media" was already part of the "Server control" submenu but the files were at app/configuration and the route was /configuration.
Marta Mazur did a simil
Move Virtual Media files and route
"Virtual media" was already part of the "Server control" submenu but the files were at app/configuration and the route was /configuration.
Marta Mazur did a similar file and route move here as part of supporting multiple Virtual Media endpoints: https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-webui/+/25218
Tested: Built and loaded on a Witherspoon. The VM route is now: #/server-control/virtual-media. Was able to use the VM panel. Change-Id: Iec46a8ece7ddfbc356bc1e71875def70c4418027 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
#
8c80dbd9 |
| 08-Aug-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add user role privilege table
Created a directive to handle display of user privilege roles on the local user management page.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I
Add user role privilege table
Created a directive to handle display of user privilege roles on the local user management page.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I83caea33356012752c7a67301fa2a372f0c28620
show more ...
|
#
bb688795 |
| 12-Aug-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add tableActions component
Creating a separate table actions component to allow row action customizations like disabling certain actions and rendering different icons.
Signed-off-by: Yoshie Muranak
Add tableActions component
Creating a separate table actions component to allow row action customizations like disabling certain actions and rendering different icons.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I85e96045af27701f5ecc4af9bf824e248abccbf5
show more ...
|
#
fb79e54c |
| 12-Aug-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add password visibility toggle
This commit will add a new password visibility toggle directive. The new directive was added to the local user management, user modal password input fields.
Signed-of
Add password visibility toggle
This commit will add a new password visibility toggle directive. The new directive was added to the local user management, user modal password input fields.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I4e2baf53eec04aaff1bba26948779de6e447e3e7
show more ...
|
#
fa56273d |
| 17-Jul-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Update local user table to new design
This commit will introduce a reusable data table component. By creating a reusable component, we can ensure tables in the GUI will look consistent and common ta
Update local user table to new design
This commit will introduce a reusable data table component. By creating a reusable component, we can ensure tables in the GUI will look consistent and common table actions (sort, select row) are shared.
- Created new components directory to store shared components - Add password-confirmation directive - Remove some error handling from API utils so it can be handled in the UI
TODO: - Add show/hide toggle to password fields - Enhance table component with icons - Manual user unlock - Batch table actions - Role table
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I03c95874d2942a2450a5da2f1d2a8bb895aa1746
show more ...
|
#
dc25db03 |
| 31-Jul-2019 |
Ed Tanous <ed.tanous@intel.com> |
Fix IE11 support
While we don't really officially support IE, it would be nice if _most_ non-complicated things actually worked. Given where transpilation is, and the fact that we already have webp
Fix IE11 support
While we don't really officially support IE, it would be nice if _most_ non-complicated things actually worked. Given where transpilation is, and the fact that we already have webpack, this isn't actually that riddiculous of an idea.
using babel was the intent with the original webpack stuff, but it turns out babel-loader wasn't pulling in the babelrc properly when it was in the root dir, so babel wasn't actually transpiling anything properly.
Functionally, this commit does 3 things: 1. Fixes the published Accepts header, as the ajax call confuses IE if it doesn't have an encoding. 2. Includes core-js, to allow us to not really have to worry about javascript features that aren't present in a given browser. 4. Includes the config to support all browsers with > 0.25% market share, which should keep us compatible with most stuff.
Requires a patch to bmcweb for the updated charset header, as we didn't handle that properly previously. https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/24063
Tested: Loaded the bmcweb patch. Started the webui in IE11 with the console open. Observed that webui launches and logs in properly with no errors on the console. Opened the webui in chrome to verify that nothing was broken. Appears working as it was before.
Measured the pre-rootfs size before and after this patchset. It adds 36KB to the final package size. (404KB to 440KB). For supporting IE11 (and probably other browsers) I think this is well worth the cost.
Signed-off-by: Ed Tanous <ed.tanous@intel.com> Signed-off-by: Gunnar Mills <gmills@us.ibm.com> Change-Id: Ie402e3296deede466a7a05726ebd7a18bead0b80
show more ...
|
#
eaa40dd3 |
| 17-Jul-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add 403 $location redirect to http interceptor service
This is a temporary solution to redirect any 403 responses to a dedicated 403 'Unauthorized' page. This could occur on inital navigation to a p
Add 403 $location redirect to http interceptor service
This is a temporary solution to redirect any 403 responses to a dedicated 403 'Unauthorized' page. This could occur on inital navigation to a page or while attempting an operation.
Once permission role mapping is defined, the code should be updated to handle 403 responses in context of user attempted actions.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Ia207f2bcdd87fb20888fe6a1588d0ccd310e484c
show more ...
|
#
309b5da3 |
| 07-Nov-2018 |
beccabroek <beccabroek@gmail.com> |
Create certificate management page
Displays certificates and the ability to add up to one of each type of certificate (as limited by the backend implementation). HTTPS certificate and LDAP client ce
Create certificate management page
Displays certificates and the ability to add up to one of each type of certificate (as limited by the backend implementation). HTTPS certificate and LDAP client cert are implemented in this commit, with the ability to add more types as needed by adding them to the constants.js CERTIFICATE_TYPES array.
Also provides the ability to replace a certificate once it is added.
Resolves openbmc/phosphor-webui#43
Tested: loaded onto a witherspoon and able to view and replace both the HTTPS certificate and the LDAP certificate. GUI only allows to upload an LDAP certificate if one doesn't already exist. The GUI limits the user to one file per type as expected at this time and provides the appropriate validation messages. Alert messages appear above the table if the certificate is expired or within 30 days of expiring.
Change-Id: I345267280ecd3cb257e9304886cde9ebb69b1240 Signed-off-by: beccabroek <beccabroek@gmail.com> Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
show more ...
|
#
c86ce3c9 |
| 05-Jun-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Consolidate button styles
This patchset will create consistent button styling according to the styleguide and remove redundant button styles by creating reusable button classes.
This patchset also
Consolidate button styles
This patchset will create consistent button styling according to the styleguide and remove redundant button styles by creating reusable button classes.
This patchset also implements a consistent strategy for including icon assets. Currently, svg icons are imported as CSS background images or inlined into the markup. Inlining an svg is preferred, especially when used with buttons or links so the colors can be easily changed for different states (hover, focus, disabled) without having to request variants. The icon provider allows us to inline svgs without cluttering the markup. Webpack config was adjusted to use svg-inline-loader when resolving svgs that are used by the icon provider directive.
- All svgs were optimized to remove unncessary information. - Removed unused svg color variants - Moved icons used by icon provider to separate directory to avoid Webpack parsing the files twice - Small changes to navigation icons
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43
show more ...
|
#
e4194ce0 |
| 24-May-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add remote logging server
Remote logging enables the user to configure a remote server to stream out local logs. This feature will be available on the Event Log page. The user can add a remote serve
Add remote logging server
Remote logging enables the user to configure a remote server to stream out local logs. This feature will be available on the Event Log page. The user can add a remote server, edit/change an existing server configuration and remove/disable the remote server.
Resolves openbmc/phosphor-webui#68
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I8284cbdbdaaf85f5c95f237efc72290c66904b40
show more ...
|
#
7920baeb |
| 23-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Remove unused errors.html
Also removed errorModalDetails and displayErrorModal from dataService since they are no longer used.
errors.html was only active when displayErrorModal was true. displayEr
Remove unused errors.html
Also removed errorModalDetails and displayErrorModal from dataService since they are no longer used.
errors.html was only active when displayErrorModal was true. displayErrorModal was only true when activateErrorModal was called.
activateErrorModal was removed in a previous commit. activateErrorModal's only use was removed here: https://github.com/openbmc/phosphor-webui/commit/a38a287ccaa97eddc9df7333e33357b14772d4c6#diff-65affd2488457363c5b9e9266258c3b8
Tested: Searched the repo. Built an image and loaded onto a Witherspoon. No regressions observed.
Change-Id: I96e26dd3817d7b02bbce74b4cc093b75dab669ed Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
#
44da471f |
| 20-Mar-2019 |
beccabroek <beccabroek@gmail.com> |
Virtual media page
Adds page to manage virtual media devices. User selects file and pushes 'start' button to establish websocket connection. nbdServerService added to provide ability for user to nav
Virtual media page
Adds page to manage virtual media devices. User selects file and pushes 'start' button to establish websocket connection. nbdServerService added to provide ability for user to navigate away from the page and return with the ability to see the current active sessions.
Currently only supports 1 Virtual Media device.
Resolves openbmc/phosphor-webui#40
Tested: uploaded ubuntu image file, started the connection and mounted virtual media device from host console. Able to see Ubuntu image file. Also uploaded file and navigated away from the page, checking that the websocket remained open and was sending / recieving messages. Finally, tested that when connection was stopped, 'USB disconnect' log was present in host console.
Change-Id: Ia3155d27cbcfef94c2753dde1303a151e08847cc Signed-off-by: beccabroek <beccabroek@gmail.com> Signed-off-by: Gunnar Mills <gmills@us.ibm.com> Signed-off-by: Derick Montague <derick.montague@ibm.com>
show more ...
|
#
e9211cb3 |
| 22-Apr-2018 |
Ed tanous <ed@tanous.net> |
Implement KVM in webui
This patchset adds the infrastructure to allow KVM sessions through the webui. A websocket capable VNC/RFB connection on the BMC is needed for KVM sessions.
To access, naviga
Implement KVM in webui
This patchset adds the infrastructure to allow KVM sessions through the webui. A websocket capable VNC/RFB connection on the BMC is needed for KVM sessions.
To access, navigate to Server control -> KVM.
Tested: Ran obmc-ikvm on the BMC, added a KVM Handler to Phosphor Rest Server, and was able to establish a KVM session in the webui on a Witherspoon. Change-Id: I7dda5bec41d270ae8d0913697714d4df4ec3a257 Signed-off-by: Ed Tanous <ed.tanous@intel.com> Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|