DNS: Remove workaround for empty list array

This workaround is no longer needed with bmcweb.

curl -k -H "Content-Type: application/json" -X PUT \
-d '{"data": [] }' \
https://${bmc}/xyz/openbmc_pr

DNS: Remove workaround for empty list array

This workaround is no longer needed with bmcweb.

curl -k -H "Content-Type: application/json" -X PUT \
-d '{"data": [] }' \
https://${bmc}/xyz/openbmc_project/network/eth0/attr/Nameservers
{
"data": null,
"message": "200 OK",
"status": "ok"

and actually casues an error now do to
https://github.com/openbmc/phosphor-networkd/commit/5fb6c33a49ee2b9718cc9ce0f921d3b6cf38a463

curl -k -H "Content-Type: application/json" -X PUT \
-d '{"data": [""] }' \
https://${bmc}/xyz/openbmc_project/network/eth0/attr/Nameservers
"data": {
"description": "xyz.openbmc_project.Common.Error.InvalidArgument"
},
"message": "Invalid argument was given.",

See https://github.com/openbmc/openbmc/issues/3240

Tested: Built and loaded on a Witherspoon. Added, removed,
and edited DNS servers.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Change-Id: I278489a8c4682641b61a0e5ab08fd714603b0234

show more ...

Fix invalid gateway toast message

Add check for gateway value before testing if the string is valid.
The backend seems to handle an empty gateway the same as sending
0.0.0.0. When the GET call is ma

Fix invalid gateway toast message

Add check for gateway value before testing if the string is valid.
The backend seems to handle an empty gateway the same as sending
0.0.0.0. When the GET call is made after sending 0.0.0.0 as the
gateway value, the response returns an empty string. This field
seems to be an override for the default gateway input for the
interface.

Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Id6a5575e73a7c8adfff052c89bb4e8ca986d45f9

show more ...

Add role alert to toasts

For accessibility reasons, 'role="alert" is required for toast
messages. This notifies screen readers that an error or success
message has appeared. Adds a service layer for

Add role alert to toasts

For accessibility reasons, 'role="alert" is required for toast
messages. This notifies screen readers that an error or success
message has appeared. Adds a service layer for toast messages
that adds the role attribute to the message.

Change-Id: Ic4dbf5556337eea589de5692c1b4c3323e771813
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Add toast to Network Settings page

Displays error message if any settings fail to save and success
if all succeed on the Network Settings page.

Change-Id: Ifddf1822ba59753a217d1ec257b8d0ca870cceed

Add toast to Network Settings page

Displays error message if any settings fail to save and success
if all succeed on the Network Settings page.

Change-Id: Ifddf1822ba59753a217d1ec257b8d0ca870cceed
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Update code styling for network page

Now that the following style guide is being
used:
https://google.github.io/styleguide/jsguide.html#naming
Some of the variable naming in this class needs to be u

Update code styling for network page

Now that the following style guide is being
used:
https://google.github.io/styleguide/jsguide.html#naming
Some of the variable naming in this class needs to be updated.

Change-Id: I6ca7a0ea7255ab2314bb4b5fc2d89cff9006039a
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Add and Update IPV4 address

This allows user to add IPV4 addresses
and updates logic for editing IPV4
addresses.

Resolves openbmc/phosphor-webui#12

Tested: Added, removed and modified IPV4
ad

Add and Update IPV4 address

This allows user to add IPV4 addresses
and updates logic for editing IPV4
addresses.

Resolves openbmc/phosphor-webui#12

Tested: Added, removed and modified IPV4
addresses, called API to verify that
addresses had been correctly modified.
Verified that if address had not been
modified, no change was made for that
address.

Change-Id: I3dd25565f4f610dce2023e23348f6eb8d00add3d
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Remove IPV4 addresses

Tested: Able to remove existing IPV4
addresses.

Change-Id: I772bee6ad6b68bc0a69351f3e5386acc659241ef
Signed-off-by: beccabroek <beccabroek@gmail.com>

Button to remove DNS server

Added button to remove DNS server from
Nameservers list.

Resolves openbmc/phosphor-webui#11

Tested: Added and was able to remove DNS servers
from list. Page updated a

Button to remove DNS server

Added button to remove DNS server from
Nameservers list.

Resolves openbmc/phosphor-webui#11

Tested: Added and was able to remove DNS servers
from list. Page updated appropriately.

Change-Id: I64e9d2499465f1aa5f9f34c831961578abf32b2b
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Set time fields

Squashed 5 commits to set the date-time fields:
time mode, time owner, BMC time, and host time.
Also included is a commit to display the timezone.

Set time mode

Moved the selection

Set time fields

Squashed 5 commits to set the date-time fields:
time mode, time owner, BMC time, and host time.
Also included is a commit to display the timezone.

Set time mode

Moved the selection of NTP vs Manual (time mode) to a radio
button.
Added code to allow the user set it.

Tested: Set the time mode on a Witherspoon.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Set time owner

The time owner is now a dropdown and is set when "Save settings"
is pressed.

Tested: Set the time owner on a Witherspoon
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Set the BMC and Host time

The BMC and host have the same time except when time mode is split.
Only need to set BMC or host time when time mode is not split.
When time mode is split, set both. Use time owner to determine
which to set.
https://github.com/openbmc/phosphor-time-manager#time-settings

Have date and time as two separate inputs, this is due to Firefox
not supporting "datetime-local". The "date" and "time" input
fields are more widely supported.
https://caniuse.com/#feat=input-datetime

The idea for 2 separate input fields came from:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime-local

Must set the time mode and time owner before setting the time,
this is due to permissions of who can set the time.

Tested: Set the date and time on a Witherspoon.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Add NTP Servers

The user can now view and set NTP Servers.

Moved setFocusOnNewInput to a common directive since it is used
on the NTP Servers and the DNS Servers on the network page.

Even though NTPServers is a network interface specific path
(e.g. /xyz/openbmc_project/network/eth0/attr/NTPServers) it acts
like a global setting, openbmc/phosphor-time-manager#4.
Using eth0 for setting and getting the NTP Servers until
NTPServers is moved to a non-network interface specific path.

In Redfish, NTPServers is a non-network interface specific.

Tested: Set NTP Servers on a Witherspoon.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Add timezone

Added the timezone for the host and bmc date time.

The timezone looks like "GMT-0400 (EDT)" or "GMT-0500 (CDT)".
I got this from
https://stackoverflow.com/questions/1091372/getting-the-clients-timezone-in-javascript
and choose this formatting over something like "America/Chicago".

Tested: See the timezone on a Witherspoon
Change-Id: I59a4449d63f73a6ed14cb934f3d8577e46620c4e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Move to clang-format-6.0

The docker image moved from clang-format-5.0 to clang-format-6.0.

Change-Id: I3c615d7df1f21569531b4dc2cb0bc4f425cb43f8
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Focus on newly created DNS server field

Got feedback from IBM's design team that to help usability after adding
a DNS Server field, focus on the newly created DNS server field.

Decided to go with a

Focus on newly created DNS server field

Got feedback from IBM's design team that to help usability after adding
a DNS Server field, focus on the newly created DNS server field.

Decided to go with a directive instead of putting this in a controller
after reading:

https://stackoverflow.com/questions/22292832/angular-ng-init-pass-element-to-scope,
https://github.com/angular/angular.js/issues/9031,
https://groups.google.com/forum/#!topic/angular/6uxWl8Z0DPw

Having dom manipulation code in the controller is frowned upon.

Tested: Verified the field is in focus (i.e. the cursor is in the
textbox).
Change-Id: Ia548361e7ac47363e05ea2963807bca0c5bf51e2
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Fixed spelling errors

Change-Id: I4b668b6246508d3bedda75ca179da1615516bad4
Signed-off-by: Rebecca Shaw <rebecca.shaw@ibm.com>

Add TODO for openbmc/openbmc#3240

Change-Id: I2dcd3625cf72c774d84399e35d3c7be19f744d5c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Keep the selected interface

If given 2 network interfaces: eth0 and eth0_60 (a VLAN interface),
and eth0_60 is selected a "cancel" of the form would result in eth0
being selected. Fixed this by movi

Keep the selected interface

If given 2 network interfaces: eth0 and eth0_60 (a VLAN interface),
and eth0_60 is selected a "cancel" of the form would result in eth0
being selected. Fixed this by moving getNetworkInfo() to a function
and calling it on a cancel. Also, call this new function after a
successful network set (a temporary fix).

Tested: The above case keeps eth0_60 selected.
Change-Id: I136ca1030cbbb053ca3b96241197c56488204dfd
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add "Add new DNS server" button

Added a button which allows the user to add new DNS Servers.
After pressing the button a new empty field appears.

Resolves openbmc/openbmc#3089

Tested: Added severa

Add "Add new DNS server" button

Added a button which allows the user to add new DNS Servers.
After pressing the button a new empty field appears.

Resolves openbmc/openbmc#3089

Tested: Added several new DNS Servers on a Witherspoon.
Change-Id: Ic6a6d2b798ad177b0e9aeb64ba3e4993af442305
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Update DNS Servers on "Save settings"

"Nameservers" is called "DNS Servers" on the GUI. Update the
property if it has changed when the user hits Save settings
and confirms.

Had difficulties getting

Update DNS Servers on "Save settings"

"Nameservers" is called "DNS Servers" on the GUI. Update the
property if it has changed when the user hits Save settings
and confirms.

Had difficulties getting the DNS input fields to update the
interface.Nameservers array. The
"ng-blur="interface.Nameservers[$index] = dns" solution is from:
https://stackoverflow.com/questions/13714884/difficulty-with-ng-model-ng-repeat-and-inputs

Tested: Changed some DNS Servers on a Witherspoon.
Change-Id: Ib9c4be044d0725ac50e57e2733c3dc2ef8e29053
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add IPV4 properties parameter validation

Added parameter validation for the IPV4 properties: IP Address,
Gateway, and Netmask prefix length.
This is important since we delete the IPV4 interface befo

Add IPV4 properties parameter validation

Added parameter validation for the IPV4 properties: IP Address,
Gateway, and Netmask prefix length.
This is important since we delete the IPV4 interface before adding
the new one (i.e. if the add is unsuccessful we are down an IPV4
interface). This validation helps to prevent some of the
unsuccessful adds.

Took the logic from the network manager valid parameter checks:
https://github.com/openbmc/phosphor-networkd/blob/master/util.cpp#L217

Moved "Netmask Prefix Length" to a "number" to do this. It should
have been a number.

Tested: A variety of good and bad values.
Change-Id: Idf4486489097bc426164b9543ea8c05eb54a2bf8
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add reload 4 seconds after network set success

Since an IPV4 interface (e.g. IP address, gateway, or netmask) edit
is a delete then an add and the GUI can't calculate the interface
id (e.g. 5c083707

Add reload 4 seconds after network set success

Since an IPV4 interface (e.g. IP address, gateway, or netmask) edit
is a delete then an add and the GUI can't calculate the interface
id (e.g. 5c083707) beforehand and it is not returned by the REST
call, reload the page after an edit, which makes another REST call.

Do this for all network changes, instead of just IPV4 interface
edits due to the possibility of a set network failing even
though it returned success, openbmc/openbmc#1641.

This REST call also updates dataService and old_interface
which is used to know which data has changed if the user
continues to edit network settings.

The issue this is solving is the GUI deletes the old IPV4
interface (5c083707), creates a new one (4d9b1add), then
let's say the user modifies the IPV4 interface again without
a refresh, the GUI doesn't know what old IPV4 interface to
delete (i.e. the GUI doesn't know to delete 4d9b1add).

Choose 4 seconds to give the network manager time to set
the network.

Tested: Did the above scenario.
Change-Id: I36cb438b12eb6540dc74f235f8f134df67e60389
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add loading spinner

Added a loading spinner that appears when set network settings are
confirmed. This fits with the other pages such as firmware update.

Tested: See the spinner when Save settings

Add loading spinner

Added a loading spinner that appears when set network settings are
confirmed. This fits with the other pages such as firmware update.

Tested: See the spinner when Save settings are confirmed.
Change-Id: Iec321e036ad7a81d960109397b3a60ffdf256062
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Set DHCP on "Save settings"

Set the DHCP enabled field when the user selects "Save settings"
and accepts the popup. Added a TODO for issue #3154, Rest server
should return a proper JSON bool.

Resol

Set DHCP on "Save settings"

Set the DHCP enabled field when the user selects "Save settings"
and accepts the popup. Added a TODO for issue #3154, Rest server
should return a proper JSON bool.

Resolves openbmc/openbmc#3165

Tested: Set "Obtain an IP address automatically using DHCP"
on a Witherspoon.
Change-Id: I45c817e3ddd8bf9c4f582460b1f9230e38548ff8
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Set IPV4 interfaces

If a gateway, netmask, or IP address of an IPV4 interface changes on
the page, when the user hits "Save changes" and confirms the popup,
delete the old IPV4 interface and create

Set IPV4 interfaces

If a gateway, netmask, or IP address of an IPV4 interface changes on
the page, when the user hits "Save changes" and confirms the popup,
delete the old IPV4 interface and create a new one with the new
values. After talking with Ratan, deleting then adding is the
the correct way to change IPV4 interfaces.
More information can be found in the network README up for review:
https://gerrit.openbmc-project.xyz/#/c/6872/

Tested: Changed IPV4 interface properties on a Witherspoon.
Also tested a Witherspoon in DHCP mode then moved over to a static
IP.
Change-Id: Idc0026aa01533ea327b53efc57e21147c4b68967
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Check if network settings changed

Before setting the Mac Address, Hostname, or DefaultGateway,
check to see if those settings changed.

Change-Id: Ifc735b61734ced13e2554651d74dc44d761f3432
Signed-of

Check if network settings changed

Before setting the Mac Address, Hostname, or DefaultGateway,
check to see if those settings changed.

Change-Id: Ifc735b61734ced13e2554651d74dc44d761f3432
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Set Hostname on "Save settings"

Set the Hostname field when the user selects "Save settings"
and accepts the popup. Before Hostname was readonly.

Tested: Set the Hostname on a Witherspoon
Change-Id

Set Hostname on "Save settings"

Set the Hostname field when the user selects "Save settings"
and accepts the popup. Before Hostname was readonly.

Tested: Set the Hostname on a Witherspoon
Change-Id: I9de840ee9d52ec4a9ae1fd69d4ea27f62b0baf17
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Set DefaultGateway on "Save settings"

Set the DefaultGateway field when the user selects "Save settings"
and accepts the popup. Moved to q.all() with a promise array.
Later commits will add to this

Set DefaultGateway on "Save settings"

Set the DefaultGateway field when the user selects "Save settings"
and accepts the popup. Moved to q.all() with a promise array.
Later commits will add to this array and do a check to make sure
the field changed before setting the value.

Tested: Set the DefaultGateway on a Witherspoon
Change-Id: Ica6abe14169f00bc3195f34a08db61ddbc09fa92
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Replace "Domain Name" with "Default Gateway"

"Domain Name" is not as important of a network settings as
"Default Gateway". Remove it for now, later we will add fields for
the other network settings

Replace "Domain Name" with "Default Gateway"

"Domain Name" is not as important of a network settings as
"Default Gateway". Remove it for now, later we will add fields for
the other network settings but getting the basic network settings
going for now. To setup the network, the user needs to configure
the Default Gateway, MAC Address, IP, Gateway, and netmask.

Change-Id: I27066dc188c3c30a01051b473a7ce10837d40fab
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...