Set init_priority attribute for global variables in shared lib

The code gets unspecified initializatio order for the global/static
variables in a shared library.

If unluck, a global/static variable

Set init_priority attribute for global variables in shared lib

The code gets unspecified initializatio order for the global/static
variables in a shared library.

If unluck, a global/static variable may be initialized in *constructor*
function, and then initialized by the default contructor.
For exmaple, if `std::unique_ptr<xxx> var{nullptr};` is initialized in
constructor function, below init order may occur:
1. It is initialized in constructor;
2. Then it is initialized as nullptr;
And eventually when the code is to use the variable, we got nullptr.

We met such issues before on openbmc/openbmc#1581, and the technical
details could be found at [this SO question][1] and [this gcc email][2]

The solution is to specify the init_priority attribute, to make the
global/staic variables inititalize earlier than the contructors.

[1]: https://stackoverflow.com/questions/43941159/global-static-variables-initialization-issue-with-attribute-constructor-i
[2]: https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00863.html

Change-Id: I901a6a5cddec12aec9512fe58b16735fa2ad90d7
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Create libipmid and libipmid-host

This starts a transition to common ipmid libraries that providers can
link against. It will allow for a cleaner separation between common
ipmid functionality and da

Create libipmid and libipmid-host

This starts a transition to common ipmid libraries that providers can
link against. It will allow for a cleaner separation between common
ipmid functionality and daemon type specific code. This is needed so we
can resolve all of the symbols in the providers at link time instead of
discovering bad linkage by building and running a full ipmi daemon.

In future commits libraries will be packaged for libipmid and libipmid-host
which provide all of the symbols used by the current set of ipmid
providers.

This is the first step, it just separates and renames the headers.
Legacy symlinks are still kept around for compatability. It also adds
stub libraries so that external users can start linking as intended.

Change-Id: I6bbd7a146362012d26812a7b039d1c4075862cbd
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Changes to align with IPMI spec

IPMI Spec Section 19.2:
Unless otherwise noted, Reserved bits and fields in commands(request messages)
and responses shall be written as '0'.

Return "out of range" e

Changes to align with IPMI spec

IPMI Spec Section 19.2:
Unless otherwise noted, Reserved bits and fields in commands(request messages)
and responses shall be written as '0'.

Return "out of range" error for unsupported power policy
and also return the supported policies on success.

Change-Id: I51d63b86ef0d3076438649abc49c63267c57cbd5
Signed-off-by: Yong Li <yong.b.li@linux.intel.com>

show more ...

Remove unused legacy code referencing org.openbmc.settings.Host

Resolves openbmc/phosphor-host-ipmid#115

Change-Id: Iab7f878b8b3011caa95f532f99062af9cbc1c33c
Signed-off-by: Tom Joseph <tomjoseph@in

Remove unused legacy code referencing org.openbmc.settings.Host

Resolves openbmc/phosphor-host-ipmid#115

Change-Id: Iab7f878b8b3011caa95f532f99062af9cbc1c33c
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>

show more ...

Implement set chassis capabilities IPMI commands

Create a new dbus interface for the chassis capabilities, and
store the chassis capabilities using phosphor settings manager

Tested By:
ipmitool -H

Implement set chassis capabilities IPMI commands

Create a new dbus interface for the chassis capabilities, and
store the chassis capabilities using phosphor settings manager

Tested By:
ipmitool -H $BMCIP -U root -P 0penBmc -I lanplus raw 0 5 0 2 4 6 8 0xa
ipmitool -H $BMCIP -U root -P 0penBmc -I lanplus raw 0 0

Change-Id: Id01555358adfec3814fd03b3e6d422916c861039
Signed-off-by: Yong Li <yong.b.li@linux.intel.com>

show more ...

Convert variant usage to std interface

This is just a refactoring to use the c++17 std::variant interfaces
instead of the mapbox::variant specific ones. We should be able to use
mapbox::variant and

Convert variant usage to std interface

This is just a refactoring to use the c++17 std::variant interfaces
instead of the mapbox::variant specific ones. We should be able to use
mapbox::variant and std::variant interchangeably now.

Tested:
Built against sdbusplus with mapbox::variant and sbusplus using
std::variant. Both variant compile and test out.

Change-Id: I6fbaad3d12dd34968db6a10f3d74a65e07d0f0cc
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Use the common timer class

The common timer class from sdbusplus offers all the timer goodness that
we currently use. The unit test is also no longer needed (and has been
added to sdbusplus's versio

Use the common timer class

The common timer class from sdbusplus offers all the timer goodness that
we currently use. The unit test is also no longer needed (and has been
added to sdbusplus's version of the timer.hpp implementation).

Change-Id: I278817489433a29ca739f70fdacd8bb897797d66
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

add std namespace prefix to common methods

Standard clib methods should be explicitly grabbed from the standard
namespace.

Change-Id: I8bcfcb260a99180d535ec8102c1a24c318cbc209
Signed-off-by: Patric

add std namespace prefix to common methods

Standard clib methods should be explicitly grabbed from the standard
namespace.

Change-Id: I8bcfcb260a99180d535ec8102c1a24c318cbc209
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

move filesystem inclusion to bottom of list

Change-Id: I4aa3c984992236bb5b4a5c62c3d42a33c12d55de
Signed-off-by: Patrick Venture <venture@google.com>

replaced c headers with cpp where applicable

Change-Id: I23a70eb540ccde5d2aba467426769feffb07b516
Signed-off-by: Patrick Venture <venture@google.com>

rename headers to match style

Moving headers from ".h" to ".hpp"

Reworked the header inclusion a bit so that host-ipmid is treated as a
library, and local headers aren't.

renamed apphandler.h => a

rename headers to match style

Moving headers from ".h" to ".hpp"

Reworked the header inclusion a bit so that host-ipmid is treated as a
library, and local headers aren't.

renamed apphandler.h => apphandler.hpp
renamed chassishandler.h => chassishandler.hpp
renamed globalhandler.h => globalhandler.hpp
renamed sensorhandler.h => sensorhandler.hpp
renamed storageaddsel.h => storageaddsel.hpp
renamed storagehandler.h => storagehandler.hpp
renamed systemintfcmds.h => systemintfcmds.hpp

Change-Id: I9d4ce3dd57e2e996800f9020a10cc10cdf2c3914
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Implement chassis set power restore policy command

Implement the IPMI set power restore policy command 0x06.
This command can be used to configure the power restore policy.
This configuration parame

Implement chassis set power restore policy command

Implement the IPMI set power restore policy command 0x06.
This command can be used to configure the power restore policy.
This configuration parameter is kept in nonvolatile storage.
The power restore policy determines how the system or chassis
behaves when AC power returns after an AC power loss

Tested:
Run the below command to check the current Power Restore Policy:
ipmitool -H <IP> -P 0penBmc -I lanplus chassis status

Run the below command to change it:
ipmitool -H <IP> -P 0penBmc -I lanplus chassis policy always-off

Change-Id: I224912890f9a9e8b4dc98f840cd6f223c9f7dfe5
Signed-off-by: Yong Li <yong.b.li@linux.intel.com>

show more ...

add .clang-format

Change-Id: I7c2a527b4751a560703a61fcbe9638b150546af5
Signed-off-by: Patrick Venture <venture@google.com>

Handle the case to turn off the Chassis Identify LED

Resolves openbmc/openbmc#3327

Change-Id: Ib0cbfccdd91b6cdd2267a48b312d2736a4ce8fbc
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>

Standardize use of filesystem

If <filesystem> exists, use that, if it doesn't, try
<experimental/filesystem>. Either way, access it from std via a
namespace splice.

Change-Id: I5b35ee9f74b88e188cb3

Standardize use of filesystem

If <filesystem> exists, use that, if it doesn't, try
<experimental/filesystem>. Either way, access it from std via a
namespace splice.

Change-Id: I5b35ee9f74b88e188cb3ca3fed9abaec64933697
Signed-off-by: Vernon Mauery <vernon.mauery@intel.com>

show more ...

Fix D-Bus error from callback method invoked from async thread

Noticed D-bus method invoked as part of the callback method
invoked from async thread returns error

Switching to use sd_event loop tim

Fix D-Bus error from callback method invoked from async thread

Noticed D-bus method invoked as part of the callback method
invoked from async thread returns error

Switching to use sd_event loop timer for callback after timer
expiry

Resolves openbmc/openbmc#3130

Change-Id: Ibe87a6b3aa179cc887593c7dea635c11d9ea844c
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

Implement Get POH Counter command

It returns a counter value proportional to the system operating
power-on hours.

Partially Resolves openbmc/openbmc#2979

Change-Id: Ib0cd43fe5cbc055ae84991577d766b

Implement Get POH Counter command

It returns a counter value proportional to the system operating
power-on hours.

Partially Resolves openbmc/openbmc#2979

Change-Id: Ib0cd43fe5cbc055ae84991577d766bedae58d775
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>

show more ...

Fix get boot options returning unexpected results

Get boot options is returning wrong value when
boot device is set to cdrom followed by setting boot
device to bios.

In the IPMI spec the boot devic

Fix get boot options returning unexpected results

Get boot options is returning wrong value when
boot device is set to cdrom followed by setting boot
device to bios.

In the IPMI spec the boot device selector has options
for both "boot source" (default/disk/crdom/network)
and "boot mode" (default/bios/safe/diag). Since this
isn't a bit field, you can't override for eg both the
source and mode at the same time.

The solution is if a set boot device is mapping to a boot
source, then reset the boot mode D-Bus property to default,
or vice versa. This way the ipmid code can determine which
property is not at the default value

Resolves openbmc/openbmc#3067
Resolves openbmc/openbmc#3068

Change-Id: I072c82a161d56f118510fe1f9e5c75cb5c610295
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

Add set boot source and boot mode methods for reuse

setBootMode and setBootSource methods are introduced
by refactoring code from ipmi_chassis_set_sys_boot_options
for code reuse.

Change-Id: I30b64

Add set boot source and boot mode methods for reuse

setBootMode and setBootSource methods are introduced
by refactoring code from ipmi_chassis_set_sys_boot_options
for code reuse.

Change-Id: I30b641239686b0411a0995468d098f5ad3d61754
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

Reducing IPMI logging footprint

-host-ipmid is very noisy in terms of journal logging. A small step
towards cleaning that up.
-Also converted printfs to phosphor-logging.

Partially Resolves openbmc

Reducing IPMI logging footprint

-host-ipmid is very noisy in terms of journal logging. A small step
towards cleaning that up.
-Also converted printfs to phosphor-logging.

Partially Resolves openbmc/openbmc#2507

Change-Id: I749c19c18d1cabf6f0216830c8cb0a08ee43d6de
Signed-off-by: Aditya Saripalli <aditya0124@gmail.com>
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>

show more ...

Revert "Revert "Add chassis identify ipmi command.""

This reverts commit 82feb17d0c244ed04b82b0fbed3c0a9456986a86.

The fix for armv5 futures is provided in yocto 2.4

Resolves openbmc/openbmc#3010

Revert "Revert "Add chassis identify ipmi command.""

This reverts commit 82feb17d0c244ed04b82b0fbed3c0a9456986a86.

The fix for armv5 futures is provided in yocto 2.4

Resolves openbmc/openbmc#3010

Change-Id: Ifc7e224f6f1fa115e0299642e8866b82d6e4f38c

show more ...

Revert "Add chassis identify ipmi command."

This reverts commit 5bfbde351aabe2096de99ee959a8a2e50edcf84c.

See https://github.com/openbmc/openbmc/issues/2740 for details. This
commit causes ipmid to

Revert "Add chassis identify ipmi command."

This reverts commit 5bfbde351aabe2096de99ee959a8a2e50edcf84c.

See https://github.com/openbmc/openbmc/issues/2740 for details. This
commit causes ipmid to fail to load.

From github user artemsen:
> ipmid[995]: ERROR opening [/usr/lib/host-ipmid/libapphandler.so.0]:
> /usr/lib/host-ipmid/libapphandler.so.0: undefined symbol: _ZTINSt13__future_base12_Result_baseE

As reported by Lei:
> This issue prevent all P8 systems (with ast2400) booting with latest
> OpenBMC, because ipmid fails to load libapphandler.so and cause watchdog
> will not be kicked and always timeout on power on.

As suggested by James Feist:
> We probably should just revert the changes until we update to yocto
> 2.4 which has the newer version of GCC with the fix for armv5 futures
> as the backport seemed to fail.

Change-Id: I0059cc3f939c1e3e5f88531fcb14ae3faa451387
Tested: Booted a ast2400 machine and checked journal
Signed-off-by: Joel Stanley <joel@jms.id.au>

show more ...

Add chassis identify ipmi command.

Add command with support for chassis identify.

Resolves openbmc/openbmc#2621

Change-Id: Ie656b71eba68141117838363456c6e075225e3e6
Signed-off-by: James Feist <jam

Add chassis identify ipmi command.

Add command with support for chassis identify.

Resolves openbmc/openbmc#2621

Change-Id: Ie656b71eba68141117838363456c6e075225e3e6
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I78e9d

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I78e9d126f19fd9fb2e3f2fa9fe8c2404dc505f82
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

boot policy: Support boot parameter #4 (boot info)

Resolves openbmc/openbmc#2356

Change-Id: If775a01a97f29a60575c03f26d32bba0315af920
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>