Remove useless wildcard handlers

The default action is to return Command Not Found, which is exactly what
the wildcard handlers are doing. This just removes that extra code that
is not needed.

Chan

Remove useless wildcard handlers

The default action is to return Command Not Found, which is exactly what
the wildcard handlers are doing. This just removes that extra code that
is not needed.

Change-Id: I0a25153395858efcdf56384ececaabc7eaf4e1af
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

chassishandler:Get Chassis Capabilities to new API

Rewrite "get chassis capabilities" command to use newly introduced
IPMI provider API.

Tested:
verified using ipmitool raw command.

Command: ipmi

chassishandler:Get Chassis Capabilities to new API

Rewrite "get chassis capabilities" command to use newly introduced
IPMI provider API.

Tested:
verified using ipmitool raw command.

Command: ipmitool raw 0x00 0x00 // get chassis capabilities command
Response: 06 20 20 20 20 20

Change-Id: I16f7efec58f438f1f04392b246b27ab665a65ed5
Signed-off-by: anil kumar appana <anil.kumarx.appana@intel.com>
Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>

show more ...

chassis: remove startup dependencies

Currently, on start if services aren't avaialble ipmid
throws and crashes. This changes the lookup of settings
to when the command is actually called.

Tested: i

chassis: remove startup dependencies

Currently, on start if services aren't avaialble ipmid
throws and crashes. This changes the lookup of settings
to when the command is actually called.

Tested: ipmi chassis status still works

Change-Id: I2106270d3f6f6bdd02ad67f7dface3bf04f98a3d
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Implement NMI command in Chassis Control command.

Set NMI (Diagnostic Interrupt) signal source to Chassis command.
Please refer ipmi spec 1.3 table 1 for details.
Set Enabled property to inform NMI

Implement NMI command in Chassis Control command.

Set NMI (Diagnostic Interrupt) signal source to Chassis command.
Please refer ipmi spec 1.3 table 1 for details.
Set Enabled property to inform NMI source handling to
trigger a NMI_OUT BSOD.

Tested:
NMI is actived(host is hang) due to NMI command
ipmitool chassis power diag

Change-Id: I8066aa19ba1f5a81897857de2a5fe551876101b3
Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>

show more ...

Add compile option to disable safe mode option in boot flags

Some platforms doe not support safe mode in
set/get system boot options commands, add an compile option to disable it.
Using the below co

Add compile option to disable safe mode option in boot flags

Some platforms doe not support safe mode in
set/get system boot options commands, add an compile option to disable it.
Using the below command:
./configure --disable-boot-flag-safe-mode-support

Tested:
After adding this compile option, below command fails:

// set safe mode in set system boot options command
ipmitool raw 0 8 5 0x80 0xc
Unable to send RAW command (channel=0x0 netfn=0x0 lun=0x0 cmd=0x8 rsp=0xcc):
Invalid data field in request

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: Ie479a0c68a8e9fc79f99c9d4cc10cdd1e6ceb20e

show more ...

chassishandler: move set chassis cap to new api

Rewrite set chassis capabilities to use new ipmi provider api

Tested:
verified ipmitool raw get chassis capabilities command

ipmitool raw 0 5 00 20

chassishandler: move set chassis cap to new api

Rewrite set chassis capabilities to use new ipmi provider api

Tested:
verified ipmitool raw get chassis capabilities command

ipmitool raw 0 5 00 20 20 20 20 20 // set chassis cap command

ipmitool raw 0 0 // get chassis cap command
00 14 14 14 14 14 // updated response in hex

Signed-off-by: anil kumar appana <anil.kumarx.appana@intel.com>
Change-Id: Idcc7c12250d4465ff838c15ba0d511701688a3a2

show more ...

Use xyz.openbmc_project.State.Chassis for IPMI chassis status

Instead of directly using pgood on dbus, this change uses the
xyz.openbmc_project.State.Chassis "CurrentPowerState" property
for the IPM

Use xyz.openbmc_project.State.Chassis for IPMI chassis status

Instead of directly using pgood on dbus, this change uses the
xyz.openbmc_project.State.Chassis "CurrentPowerState" property
for the IPMI chassis status command. This will allow us to
remove pgood from dbus.

Tested:
Ran IPMI chassis commands and confirmed that they behave as
expected:
ipmitool power status
Chassis Power is on

ipmitool power off
Chassis Power Control: Down/Off

ipmitool power status
Chassis Power is off

ipmitool power on
Chassis Power Control: Up/On

ipmitool power status
Chassis Power is on

Change-Id: I7836c16b76c3b309f176186f3e2453082e4cd1af
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Fix power restore policy input parameter check

This changes the power restore policy command to return invalid
parameter for any unsupported policy option (greater than 0x03).

Tested:
ipmitool raw

Fix power restore policy input parameter check

This changes the power restore policy command to return invalid
parameter for any unsupported policy option (greater than 0x03).

Tested:
ipmitool raw 0 6 0
07
ipmitool chassis status
Power Restore Policy : always-off
ipmitool raw 0 6 1
07
ipmitool chassis status
Power Restore Policy : previous
ipmitool raw 0 6 2
07
ipmitool chassis status
Power Restore Policy : always-on
ipmitool raw 0 6 3
07
ipmitool chassis status
Power Restore Policy : always-on
ipmitool raw 0 6 4
Unable to send RAW command (channel=0x0 netfn=0x0 lun=0x0 cmd=0x6 rsp=0xcc): Invalid data field in request

Change-Id: Ie78e00753f6dfd8b7bccce38c239a8103b6cc3fd
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Chassishandler: Add chassis identify state support for chassis status command

Return the present chassis identify state in get chassis status command:
Off
Temporary on
Indefinite on
Reserved

Tested

Chassishandler: Add chassis identify state support for chassis status command

Return the present chassis identify state in get chassis status command:
Off
Temporary on
Indefinite on
Reserved

Tested:
Set chassis identify in different states:
ipmitool raw 0 4 10 0
ipmitool raw 0 4 0 1
ipmitool raw 0 4 0 0

Then query the chassis status and check on the third byte
ipmitool raw 0 1

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: I66690b74823a6b819c4fda25d95bc8690b98181a

show more ...

chassishandler: add AC failed bit support for chassis status

PFail property is provided by power control service,
true means the booting is from AC power loss.

Tested:
Remove the AC cable and recon

chassishandler: add AC failed bit support for chassis status

PFail property is provided by power control service,
true means the booting is from AC power loss.

Tested:
Remove the AC cable and reconnect it to power on the system
ipmitool chassis status will return:
Last Power Event : ac-failed

Change-Id: I3743f15da259491052ee8fc869205438e79046f8
Signed-off-by: Yong Li <yong.b.li@linux.intel.com>

show more ...

Add support for removable media/Floppy

1. fix issue for handling unsupported parameter
2. add support for floppy/USB boot

There is dbus interface change in:
https://gerrit.openbmc-project.xyz/c/ope

Add support for removable media/Floppy

1. fix issue for handling unsupported parameter
2. add support for floppy/USB boot

There is dbus interface change in:
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/21177

Test:
$ ipmitool -H <ip> -P 0penBmc -I lanplus raw
0x0 0x8 0x5 0x80 0x14 0x00 0x00 0x00
$ ipmitool -H <ip> -P 0penBmc -I lanplus chassis bootparam get 5
...
- Boot Device Selector : Force Boot from CD/DVD
...

$ipmitool -H <ip> -P 0penBmc -I lanplus raw
0x0 0x8 0x5 0x80 0x3c 0x00 0x00 0x00
$ipmitool -H <ip> -P 0penBmc -I lanplus chassis bootparam get 5
...
- Boot Device Selector : Force Boot from Floppy/primary removable media
...
Change-Id: I915aaa3f684d02d0dfc4b65afb3c1db139c41781
Signed-off-by: Jia, chunhui <chunhui.jia@linux.intel.com>

show more ...

Get Chassis Status should not bail if button interfaces are not present

The recent rewrite of Get Chassis Status also added support for reading
the front panel enables status instead of returning a

Get Chassis Status should not bail if button interfaces are not present

The recent rewrite of Get Chassis Status also added support for reading
the front panel enables status instead of returning a hard-coded false.
But the implementation also errors out if the interface is not present
This makes the interfaces optional, returning false if they are not presnt
and reading them correctly if they are.

Tested-by: running ipmitool chassis status with and without the
xyz.openbmc_project.Chassis.Buttons service running:

# ipmitool chassis status
System Power : on
Power Overload : false
Power Interlock : inactive
Main Power Fault : false
Power Control Fault : false
Power Restore Policy : previous
Last Power Event :
Chassis Intrusion : inactive
Front-Panel Lockout : inactive
Drive Fault : false
Cooling/Fan Fault : false
Sleep Button Disable : not allowed
Diag Button Disable : not allowed
Reset Button Disable : allowed
Power Button Disable : allowed
Sleep Button Disabled: false
Diag Button Disabled : false
Reset Button Disabled: false
Power Button Disabled: false

# systemctl stop xyz.openbmc_project.Chassis.Buttons@0.service

# ipmitool chassis status
System Power : on
Power Overload : false
Power Interlock : inactive
Main Power Fault : false
Power Control Fault : false
Power Restore Policy : previous
Last Power Event :
Chassis Intrusion : inactive
Front-Panel Lockout : inactive
Drive Fault : false
Cooling/Fan Fault : false
Front Panel Control : none

Change-Id: If845194b6f052ba84f8b062ac4259ec66f706bb5
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

rewrite Get Chassis Status command

The Set Front Panel Enables command touches one of the same interfaces
that this command does, so rewrite this command to reflect the changes
that set front panel

rewrite Get Chassis Status command

The Set Front Panel Enables command touches one of the same interfaces
that this command does, so rewrite this command to reflect the changes
that set front panel enables causes.

Tested-by: manually run get chassis status command via ipmitool:
# ipmitool raw 0 1
01 00 40 30
# ipmitool chassis status

Change-Id: Ifbb13a6f344c58b2140933447995d3854cca0c0d
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

ipmid: Update set chassis power restore policy

Use the new ipmi api, including the yield context mechanism.
Modify to use the new provider API. One by one, change calls to
remove any legacy API cons

ipmid: Update set chassis power restore policy

Use the new ipmi api, including the yield context mechanism.
Modify to use the new provider API. One by one, change calls to
remove any legacy API constructs.

Tested-by: ipmitool chassis policy list
ipmitool chassis policy previous
ipmitool chassis policy always-on
ipmitool chassis policy always-off

Change-Id: I02a955c3946b940daaa3fe90c2a220b0eb719bad
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

remove usage of sdbusplus::message::variant

sdbusplus has had its alias of std::variant in place for long
enough. This changes all ipmid references to use std::variant
directly instead of the sdbusp

remove usage of sdbusplus::message::variant

sdbusplus has had its alias of std::variant in place for long
enough. This changes all ipmid references to use std::variant
directly instead of the sdbusplus alias.

Tested-by: building and running ipmid

Change-Id: Id5b4136d4589aa598815edd3ef4202e64a7698e2
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

chassishandler: move chassis control to new API

Rewritten "Chassis control" command to the use newly
introduced IPMI provider API.

Tested:
Verified ipmitool raw chassis control command
ipmitool raw

chassishandler: move chassis control to new API

Rewritten "Chassis control" command to the use newly
introduced IPMI provider API.

Tested:
Verified ipmitool raw chassis control command
ipmitool raw 0 2 0/1/2/3/4/5 and for invalid value
got invalid field in request response.

Change-Id: I0213157640e34c693b53999f69d7d47ced950e0d
Signed-off-by: anil kumar appana <anil.kumarx.appana@intel.com>
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

chassishandler: move get POH counter to new API

Rewritten "Get POH counter" command to use the newly
introduced IPMI provider API.

Tested:
verified using ipmitool chassis poh
ipmitool chassis poh
P

chassishandler: move get POH counter to new API

Rewritten "Get POH counter" command to use the newly
introduced IPMI provider API.

Tested:
verified using ipmitool chassis poh
ipmitool chassis poh
POH Counter : 1 days, 6 hours // Response

Change-Id: Ife250269da19e511783f1a0cf1298a366f3c2728
Signed-off-by: anil kumar appana <anil.kumarx.appana@intel.com>
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

move variant to std namespace

sdbusplus::message::variant_ns has been std for a while now. This moves
ipmid away from sdbusplus::message::variant_ns to directly use
std::variant.

Tested-by: built,

move variant to std namespace

sdbusplus::message::variant_ns has been std for a while now. This moves
ipmid away from sdbusplus::message::variant_ns to directly use
std::variant.

Tested-by: built, compiles, and runs the same as before.

Change-Id: I8caa945f31c926c2721319f001b9d7f83fd3f1b7
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

ipmid: update chassis identify command

Modify to use the new provider API. One by one, change calls to
remove any legacy API constructs.

Tested-by: ipmitool chassis identify
ipmitool cha

ipmid: update chassis identify command

Modify to use the new provider API. One by one, change calls to
remove any legacy API constructs.

Tested-by: ipmitool chassis identify
ipmitool chassis identify 0
ipmitool chassis identify force

Change-Id: I91bc21fdaef74eb32f297e0fa54edbc2e1bf4c2b
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Only include ipmid/api.hpp for the new API

After some feedback from users of the new IPMI API, they wanted to see
two things:
1) don't require ipmid/api.hpp and ipmid/registration.hpp to be able to

Only include ipmid/api.hpp for the new API

After some feedback from users of the new IPMI API, they wanted to see
two things:
1) don't require ipmid/api.hpp and ipmid/registration.hpp to be able to
write new handlers
2) only require including ipmid/api.hpp (instead of ipmid/api.h)

So now, by simply including ipmid/api.hpp instead of ipmid/api.h
(deprecated), handlers incorporating the new IPMI API can be written.

Change-Id: I446dcce70cff03d4ecc28c658292d052485f77fc
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

remove legacy ipmid.cpp and ipmid.hpp

These two files have now been replaced with newer APIs and can be removed.

Change-Id: If60227b24188c6796211ca43379169f9a95c9cb3
Signed-off-by: Vernon Mauery <v

remove legacy ipmid.cpp and ipmid.hpp

These two files have now been replaced with newer APIs and can be removed.

Change-Id: If60227b24188c6796211ca43379169f9a95c9cb3
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Remove experimental filesystem splice

In order to be compatible with older versions of GCC that did not have
the experimental filesystem moved over to the standard paths, the code
would splice the e

Remove experimental filesystem splice

In order to be compatible with older versions of GCC that did not have
the experimental filesystem moved over to the standard paths, the code
would splice the experimental code into the std namespace. This is no
longer necessary with yocto 2.6 and the latest versions of GCC.

Change-Id: I2db13c52a91456318795819f2d45c3386b4c56d2
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

move types.hpp to ipmid/types.hpp for export

types.hpp is required by utility.hpp, which is exported, so it needs to
be exported as well. This moves it to the include/libipmid directory,
changes the

move types.hpp to ipmid/types.hpp for export

types.hpp is required by utility.hpp, which is exported, so it needs to
be exported as well. This moves it to the include/libipmid directory,
changes the Makefile to export it, and changes all the files that
include it so it can be found in the right place.

Change-Id: I30ec365446e4de466c266ec4faa327478460ec05
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Move util.cpp/util.hpp to libipmid

These are functions that are used widely by ipmid providers, so it makes
sense to put them in libipmi.so (the library that all providers must
link against).

Teste

Move util.cpp/util.hpp to libipmid

These are functions that are used widely by ipmid providers, so it makes
sense to put them in libipmi.so (the library that all providers must
link against).

Tested-by: use nm to inspect the binaries to see that the symbols are in
the expected library.

arm-openbmc-linux-gnueabi-nm libipmid.so.0.0.0 \
| grep getDbusObject
0001063c T _ZN4ipmi13getDbusObjectERN9sdbusplus....

Change-Id: I1221f807f2711c5301c5574623564ea1ae48a437
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Extra Bytes in response data for chassis Identify command

From IPMI spec, response should be complete code only.

Tested:
ipmitool raw 0x00 0x04 0x02 0x00

Change-Id: I48a9f71e01c89ee1125d515c50e3e2

Extra Bytes in response data for chassis Identify command

From IPMI spec, response should be complete code only.

Tested:
ipmitool raw 0x00 0x04 0x02 0x00

Change-Id: I48a9f71e01c89ee1125d515c50e3e2655510d0ce
Signed-off-by: Jia, Chunhui <chunhui.jia@linux.intel.com>

show more ...