Update Host State Transition function

This updates the Host State Transition function to use the new
IPMI DBus APIs for transition requests.

Tested:
Ran each IPMI chassis control command to confirm

Update Host State Transition function

This updates the Host State Transition function to use the new
IPMI DBus APIs for transition requests.

Tested:
Ran each IPMI chassis control command to confirm the expected
behavior:
ipmitool power on: system is powered-on
ipmitool power off: system is forced off
ipmitool power cycle: system is forced off then powered-on
ipmitool power reset: system is hard reset
ipmitool power soft: soft power-off requested from system software

Change-Id: Id2253a9c0060e892bc318dd02a6221ac1a2ae2d9
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Support chassis bootdev clear-cmos

Implement the set/get the CMOS clear data 2 of the boot option
parameters boot flags(0x05).

Tested:
1. Set the clear-cmos to yes
# ipmitool chassis bootdev non

Support chassis bootdev clear-cmos

Implement the set/get the CMOS clear data 2 of the boot option
parameters boot flags(0x05).

Tested:
1. Set the clear-cmos to yes
# ipmitool chassis bootdev none clear-cmos=yes
2. Get the bootparam 0x05
# ipmitool chassis bootparam get 5
Boot parameter version: 1
Boot parameter 5 is valid/unlocked
Boot parameter data: a080000000
Boot Flags :
- Boot Flag Valid
- Options apply to only next boot
- BIOS EFI boot
- CMOS Clear
- Boot Device Selector : No override
- BIOS verbosity : System Default
- Console Redirection control : Console redirection occurs per
BIOS configuration setting (default)
- BIOS Mux Control Override : BIOS uses recommended setting of
the mux at the end of POST

Signed-off-by: Hieu Huynh <hieuh@os.amperecomputing.com>
Change-Id: I7312106977f8aef5d781dd276eecf9af279a7dc3

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic2b49715c7b81ac5bcfc12ff2d3b4c593cd95ce7

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3b5d83511afdf17b2911502279087e57a59b9945

show more ...

Implement the set/get system boot option parameters 0x04

Implement the set/get system boot options parameter 0x04 (boot info
acknowledge).

Tested:
1. Set system boot options by command:
$ ipmito

Implement the set/get system boot option parameters 0x04

Implement the set/get system boot options parameter 0x04 (boot info
acknowledge).

Tested:
1. Set system boot options by command:
$ ipmitool raw 0x00 0x08 0x04 0x01 0x01
2. Get system boot options by command:
$ ipmitool raw 0x00 0x09 0x04 0x00 0x00
01 04 00 01
3. Force boot into BIOS setup menu
$ ipmitool chassis bootdev bios
4. Get the bootparm #4
$ ipmitool chassis bootparam get 4
Boot parameter version: 1
Boot parameter 4 is valid/unlocked
Boot parameter data: 0001
Boot Info Acknowledge :
- BIOS/POST has handled boot info
5. Chassis power reset
6. Wait and make sure the Host boot to the BIOS menu
7. Force boot from default Hard-drive or PXE
$ ipmitool bootdev disk/pxe
8. Chassis power reset, the Host will boot to disk/pxe

Signed-off-by: Hieu Huynh <hieuh@os.amperecomputing.com>
Change-Id: I66f68bf3c673cb983404ff215da52add482551f8

show more ...

chassishandler: Support Hard Reset command

Follow the IPMI spec v2.0 and the OpenBMC state management design,
Support the Hard Reset IPMI command correspond the BMC transition to
A ForceWarmReboot.

chassishandler: Support Hard Reset command

Follow the IPMI spec v2.0 and the OpenBMC state management design,
Support the Hard Reset IPMI command correspond the BMC transition to
A ForceWarmReboot.

The full mapping of Redfish and IPMI to xyz.openbmc_project.State.*
is as follows:
https://github.com/openbmc/docs/blob/master/designs/state-management-and-external-interfaces.md

Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
Change-Id: I6c26e7c70c1792498b17d3800d80343b19193c41

show more ...

Fix for getSystemBootOptions for unsupported param

Issue: For "get system boot options" IPMI command, unsupported parameter
giving incorrect response.

Fix: Return "responseParmNotSupported" when us

Fix for getSystemBootOptions for unsupported param

Issue: For "get system boot options" IPMI command, unsupported parameter
giving incorrect response.

Fix: Return "responseParmNotSupported" when user trying with unsupported
parameter.

Tested:
Verified using IPMI command
Command: ipmitool raw 0x00 0x09 0x6a 0x30 0xb2 //get System Boot Options
Response: Unable to send RAW command (channel=0x0 netfn=0x0 lun=0x0
cmd=0x9 rsp=0x80): Unknown (0x80)

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I62a079b492b721e182c9e41b924fedfe550e0132

show more ...

Support new boot override setting design

Add support for the new boot override setting design that was
pushed in this commit:
"phosphor-settings-manager: redesign boot setting override feature"
(htt

Support new boot override setting design

Add support for the new boot override setting design that was
pushed in this commit:
"phosphor-settings-manager: redesign boot setting override feature"
(https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/44226)
The new design not only simplifies boot override settings handling,
but also adds support for the invalidation of "boot flags valid"
bit.

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: I3231190ec5385d33bb0eac61540513c2666fe023

show more ...

Revert "Support new boot override setting design"

This reverts commit 69e8e84d53f838ca774564c0f248e637397d501c.

Reason for revert: Prematurely committed; requires another interface

Change-Id: I841

Revert "Support new boot override setting design"

This reverts commit 69e8e84d53f838ca774564c0f248e637397d501c.

Reason for revert: Prematurely committed; requires another interface

Change-Id: I84149fe1f5913fc78e3cc1a129da8285d7fe6111

show more ...

Support new boot override setting design

Add support for the new boot override setting design that was
pushed in this commit:
"phosphor-settings-manager: redesign boot setting override feature"
(htt

Support new boot override setting design

Add support for the new boot override setting design that was
pushed in this commit:
"phosphor-settings-manager: redesign boot setting override feature"
(https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/44226)
The new design not only simplifies boot override settings handling,
but also adds support for the invalidation of "boot flags valid"
bit.

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: Iecfc75c734a34f63b0485f859ce87f06566bd749
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

Fix for getSystemBootOptions for unsupported param

Issue: For "get system boot options" IPMI command, unsupported parameter
giving incorrect response.

Fix: Return "responseParmNotSupported" when us

Fix for getSystemBootOptions for unsupported param

Issue: For "get system boot options" IPMI command, unsupported parameter
giving incorrect response.

Fix: Return "responseParmNotSupported" when user trying with unsupported
parameter.

Tested:
Verified using IPMI command
Command: ipmitool raw 0x00 0x09 0x0c 0x30 0xb2 //get System Boot Options
Response: Unable to send RAW command (channel=0x0 netfn=0x0 lun=0x0
cmd=0x9 rsp=0x80): Unknown (0x80)

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Id38ecfa7a8d3578d1ab21272b556cfd178d306ae

show more ...

support BMC boot flag valid bit clearing

Set/Get system boot options commands don't support
BMC boot flag valid bit clearing, add it.

Tested: it test by ipmi commands:
set BIOS boot option with par

support BMC boot flag valid bit clearing

Set/Get system boot options commands don't support
BMC boot flag valid bit clearing, add it.

Tested: it test by ipmi commands:
set BIOS boot option with parameter 3
ipmitool raw 0x00 0x08 0x03 xx
get boot option with parameter 3
ipmitool raw 0x00 0x09 0x03 0 0
for example:
ipmitool raw 0x00 0x08 0x03 2
no response, without error response
ipmitool raw 0x00 0x09 0x03 0 0
01 03 02
the third response datum is the value by setting boot option.


Change-Id: I7db3c7d9f52b107b5b07d94fe58f3c7ada761460
Signed-off-by: Chen Yugang <yugang.chen@linux.intel.com>

show more ...

chassishandler: Refactor get/set boot parameters code

-Make use of 'getDbusProperty'/'setDbusProperty' library functions
-Remove duplicate log messages on errors

Signed-off-by: Konstantin Aladyshev

chassishandler: Refactor get/set boot parameters code

-Make use of 'getDbusProperty'/'setDbusProperty' library functions
-Remove duplicate log messages on errors

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: Iadd3b145b2170667ca0d885a6413d1ef86b6fe27

show more ...

chassishandler: Add support for boot type flag (Legacy/EFI)

Add support for IPMI boot type field of a
"Get System Boot Options" сommand:

[1] - BIOS boot type (for BIOS that support both legacy and

chassishandler: Add support for boot type flag (Legacy/EFI)

Add support for IPMI boot type field of a
"Get System Boot Options" сommand:

[1] - BIOS boot type (for BIOS that support both legacy and EFI boots)
0b = "PC compatible" boot (legacy)
1b = Extensible Firmware Interface Boot (EFI)

For the architectures that don't implement Legacy/EFI boot type
property (for example POWER), always return EFI boot type.

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: Ifc052b988af86f02a7665ed0477b364c243e9f71

show more ...

types: Force underlying int conversion for enums

Boost 1.76.0 changed the behavior of numeric to not accept implicitly
converted ints from enum class types. This breaks many of our casts and
would r

types: Force underlying int conversion for enums

Boost 1.76.0 changed the behavior of numeric to not accept implicitly
converted ints from enum class types. This breaks many of our casts and
would require 2 casts in most cases.

This adds a convenience function to do the underlying type conversions
needed to cast enums to ints and vice versa.

Change-Id: Id653d6a10ef5cab8267c174848940807d693dbf1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

use new sdbus++ camelcase

Change I17a8d7479556596a3cf252b3f4eae9c8df547189 will change
how sdbus++ generates names which start with an acronym.
Prepare for this by keying off the SDBUSPP_NEW_CAMELCA

use new sdbus++ camelcase

Change I17a8d7479556596a3cf252b3f4eae9c8df547189 will change
how sdbus++ generates names which start with an acronym.
Prepare for this by keying off the SDBUSPP_NEW_CAMELCASE
define to use the new format.

Changes:
pOHCounter -> pohCounter

(This repository only uses this as a local variable so there
is no need for an SDBUSPP_NEW_CAMELCASE override.)

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I918aed7f6ddadd21bd490a0ddb547545499646ee

show more ...

Return channel in get system restart cause

The ipmi spec says that we should return the channel
as the last byte in get system restart cause. This was
not available when the command was originally w

Return channel in get system restart cause

The ipmi spec says that we should return the channel
as the last byte in get system restart cause. This was
not available when the command was originally written.
Now, it is available from the ipmi::Context

Tested: Check that channel in the response matches the
channel the request came in on.

Change-Id: I6490c0b6fa41f78292aa002c17de39b31b7ee032
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Add boot info ack paramter to set/get boot option command

It's required by BIOS, BIOS always checks the bootinfo ack
paramter, otherwise, BIOS will bypass the boot option flow

Tested: Ran `ipmitool

Add boot info ack paramter to set/get boot option command

It's required by BIOS, BIOS always checks the bootinfo ack
paramter, otherwise, BIOS will bypass the boot option flow

Tested: Ran `ipmitool chassis bootdev pxe`, saw the BIOS
entered into pxe

Signed-off-by: John Wang <wangzhiqiang.bj@bytedance.com>
Change-Id: I127801301d713d7177fcf84a166800a9158545c1

show more ...

Add set in progress paramter to set/get boot option command

Signed-off-by: huanghe <he.huang@intel.com>
Change-Id: Ib977e9c6a1b4ca6bbca9695c30fa90496cf211a6

chassishandler.cpp: typofix valid/invalid

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I03511a471fb6ec41392e240b23cb141343d9cf70

chassishandler: GetSystemBootOptions to new API

Rewrite ipmiChassisGetSytemBootOptions to use newly introduced
IPMI provider API

Tested:
Verified using ipmi chassis bootparam command

ipmitool chas

chassishandler: GetSystemBootOptions to new API

Rewrite ipmiChassisGetSytemBootOptions to use newly introduced
IPMI provider API

Tested:
Verified using ipmi chassis bootparam command

ipmitool chassis bootparam get 5 //command

//response
Boot parameter version: 1
Boot parameter 5 is valid/unlocked
Boot parameter data: 8000000000
Boot Flags :
- Boot Flag Valid
- Options apply to only next boot
- BIOS PC Compatible (legacy) boot
- Boot Device Selector : No override
- BIOS verbosity : System Default
- Console Redirection control : Console redirection occurs per BIOS
configuration setting (default)
- BIOS Mux Control Override : BIOS uses recommended setting of the
mux at the end of POST

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Signed-off-by: srikanta mondal <srikantax.mondal@intel.com>
Change-Id: Iaf4c5cb61f6142b2112ad9c4d927b898ef94cb14

show more ...

chassishandler: SetSystemBootOptions to new API

Rewrite ipmiChassisSetSysBootOptions to use newly introduced IPMI
provider API

Tested:
verified using IPMI chassis bootparam command and raw commands

chassishandler: SetSystemBootOptions to new API

Rewrite ipmiChassisSetSysBootOptions to use newly introduced IPMI
provider API

Tested:
verified using IPMI chassis bootparam command and raw commands

Command: ipmitool chassis bootparam set bootflag force_disk
Response: Set Boot Device to force_disk
Command: ipmitool chassis bootparam set bootflag force_pxe
Response: Set Boot Device to force_pxe
Command: ipmitool chassis bootdev pxe options=persistent
Response: Set Boot Device to pxe
Command: ipmitool chassis bootparam set bootflag force_bios
Response: Set Boot Device to force_bios
Command: ipmitool chassis bootparam set bootflag force_safe
Response: Set Chassis Boot Parameter 5 failed: Invalid data field in
request

Command: ipmitool raw 0 8 0x5 0 0 0 0 0 //setBootOptions param 5
Response: //Success
Command: ipmitool raw 0 8 0x4 0 0 //setBootOptions param 4
Response: //Success
Command: ipmitool raw 0 8 0x61 0x21 0x70 0x62 0x21 0x00 0x01
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0x01 0x01 0x04 0 0 0 0 1 1 1 1 //setBootOptions param 61
Response: //Success
Command: ipmitool raw 0 8 0 0 //setBootOptions param 0
Response: Unable to send RAW command (channel=0x0 netfn=0x0 lun=0x0
cmd=0x8 rsp=0x80): Unknown (0x80)

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Signed-off-by: srikanta mondal <srikantax.mondal@intel.com>
Change-Id: I6faa0b5162ba02bbe0e8a3acaba092888ed48acc

show more ...

Implement set front panel button enables command

The buttons D-Bus interface offers an Enabled option that can be
used by IPMI to change the button enabled state.

This adds support for disabling th

Implement set front panel button enables command

The buttons D-Bus interface offers an Enabled option that can be
used by IPMI to change the button enabled state.

This adds support for disabling the power and reset buttons.

Test-By: ipmitool raw 0x0 0xa 0x2 # disable reset button
ipmitool raw 0x0 0xa 0x1 # disable power button
ipmitool raw 0x0 0xa 0x0 # enable all buttons
ipmitool raw 0x0 0x01 # check button status in byte 5

Change-Id: I3d40261f4e7b4eb82606a3d7a9e861e12ca18151
Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

chassishandler: Add restart cause support

Added support for chassis restart cause command. This will read data
from Host power state dbus interface and reply to ipmi command.

Tested: Verified execu

chassishandler: Add restart cause support

Added support for chassis restart cause command. This will read data
from Host power state dbus interface and reply to ipmi command.

Tested: Verified executing 'ipmitool chassis restart_cause'
System restart cause: power-up via pushbutton

Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
Change-Id: I8e351035da1b8b1d85f3c34094fd7533e7af529b

show more ...

Change the CapabilitiesFlags property into booleans

Each bit in CapabilitiesFlags dbus property is a chassis
capability. Setting a capability overwrites other capabilities.
Read-and-update of the pr

Change the CapabilitiesFlags property into booleans

Each bit in CapabilitiesFlags dbus property is a chassis
capability. Setting a capability overwrites other capabilities.
Read-and-update of the property results in race condition/confusion.
To tackle this, added a boolean property for each of chassis
capability. The new properties will be read and updated in ipmi
command handling code.

The original CapabilitiesFlags property will be deprecated once the
changes are made to use new boolean properties in all the repos.

The phosphor-dbus-interfaces change is in review
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/27592

Tested:

Tested this code along with the changes in settings deamon where the
new boolean dbus properties were added and default values have
been intialized.

root@intel-obmc:~# ipmitool raw 0x00 0x00
07 22 44 66 88 aa

Signed-off-by: Karthick Sundarrajan <karthick.sundarrajan@intel.com>
Change-Id: I487a37b50bfe7d6555ff7b257b49cdb6dde781f6

show more ...