Fix: srcrev bump 4b258ac8b6..7883f58ab2

Add missed python variable initialization causing srcrev bump fail

Failed srcrev bump:
https://gerrit.openbmc-project.xyz/18414

Change-Id: I0d7d4647abe3

Fix: srcrev bump 4b258ac8b6..7883f58ab2

Add missed python variable initialization causing srcrev bump fail

Failed srcrev bump:
https://gerrit.openbmc-project.xyz/18414

Change-Id: I0d7d4647abe3c2f46cabfebf6be5ab500641f504
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Parse and generate zone interfaces

Interfaces can optionally be defined on each zone to include setting
properties under those interfaces when fan control initializes the zone.
Setting the property

Parse and generate zone interfaces

Interfaces can optionally be defined on each zone to include setting
properties under those interfaces when fan control initializes the zone.
Setting the property values here allows them to be initialized to a
default value or set of values.

Change-Id: I75d51a05caa9e5662a0608d285fd388acc8593e2
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Update parser for properties on zone objects

Create a service attribute that can be optionally defined on a group
denoting what service is hosting the group members. Initially, defining
a service na

Update parser for properties on zone objects

Create a service attribute that can be optionally defined on a group
denoting what service is hosting the group members. Initially, defining
a service name generates the group member(s) to be zone objects only.

This service attribute will be enhanced to specifically note what
service provides the group members and allow for a better trigger for
properties on zone objects instead of generating a blank signal match.

Tested:
Blank signal match generated for group members in events used

Change-Id: I483fcf6a5e210e5d70bc9d5c4c0dee15524b01b9
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Parser updates to support alternate events action

With the use alternate events action, the ability to generate an event
type is required within the parser. This action requires two separate
lists o

Parser updates to support alternate events action

With the use alternate events action, the ability to generate an event
type is required within the parser. This action requires two separate
lists of events to be generated and to generate the event code, it was
necessary to add what code is generated for each section that comprises
an event to the parser directly.

Tested:
Updated events yaml with an event to use the alternate events action
Verified the generated code builds and runs on wspoon

Change-Id: I2078610222b0ae0f7fdbcf348e5c9ff02c4108b6
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Rename Timer -> TimerConf

It is confusing to read some of the type definitions that deal with
timers when Timer could mean a timer instantiation or a set of timer
configuration parameters.

control: Rename Timer -> TimerConf

It is confusing to read some of the type definitions that deal with
timers when Timer could mean a timer instantiation or a set of timer
configuration parameters. This change disambiguates the two types.

Tested:
Built and run through unit tests.

Change-Id: I9dd6b47886747d56a86b6a50eb9a74a331d0a1fe
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

control: Alias TimerType locally

This is needed for a future commit that removes the local
phosphor::util::Timer implementation.

Tested:
Built and run through unit tests.

Change-Id: I8ea3399fe

control: Alias TimerType locally

This is needed for a future commit that removes the local
phosphor::util::Timer implementation.

Tested:
Built and run through unit tests.

Change-Id: I8ea3399fec8761055d4a0d94fb9ea91fd34040ea
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Fix exit status codes

Using an exit status of -1 everywhere leads to the status being
converted to 255 when output to a calling application. While this does
signify an error it has a reserved meanin

Fix exit status codes

Using an exit status of -1 everywhere leads to the status being
converted to 255 when output to a calling application. While this does
signify an error it has a reserved meaning for exit status out of range.
Lets use a valid general exit status of 1 instead.

Change-Id: I326701c78985e34c430c258fe31d9e910da10405
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Move generated code template to file

In preparation of enhancing the generated code format, the template used
has been externalized and will continue to be modified in future commits
to parse & gene

Move generated code template to file

In preparation of enhancing the generated code format, the template used
has been externalized and will continue to be modified in future commits
to parse & generate more efficiently.

Tested:
Generated code remains unchanged

Resolves openbmc/phosphor-fan-presence#8

Change-Id: Ifbf718e8a22acb2f2f939bbdcc2e7fe041e9ed58
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Generate InterfacesRemoved signal events

In the case that an interface containing a property used within an event
is removed from dbus, that event can subscribe to the InterfacesRemoved
signal. When

Generate InterfacesRemoved signal events

In the case that an interface containing a property used within an event
is removed from dbus, that event can subscribe to the InterfacesRemoved
signal. When an InterfacesRemoved signal is received by fan control, the
corresponding interface (and all associated properties) is removed from
the cache used by all events.

*Note: This area of signal subscription/handling code generation is
intended to be re-worked under openbmc/openbmc#2911. This is the reason
for supporting a different yaml layout for the InterfacesRemoved signal.

Tested:
Generated code constructs InterfacesRemoved signals correctly

Resolves openbmc/openbmc#2223

Change-Id: Idc3e8db4e7dc07a2bb6898d3cc30ab775362dd35
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Make event actions optional

Event actions should be made optional for events that only require
subscribing to group signals.

This is in preparation for separating signal and timer based event
actio

Make event actions optional

Event actions should be made optional for events that only require
subscribing to group signals.

This is in preparation for separating signal and timer based event
actions. A use case would be where one event can be used to subscribe to
signals that update cached property values without performing an action,
and another timer based event performs an action based on those
property values the signal event provides.

Tested:
Events without an action are generated correctly
Events without an action are handled correctly and run no action

Change-Id: I757a82ce6c45ac637ce7cea8f82a62b98b600e3e
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Parse a list of groups with zone conditions

Set speed events can use a list of groups associated with its actions
where each group defines what zone conditions the group should be
included in action

Parse a list of groups with zone conditions

Set speed events can use a list of groups associated with its actions
where each group defines what zone conditions the group should be
included in actions.

Tested:
List a single group within an event
List two groups within an event with different zone conditions
List two groups within an event in the same zone conditions
List more than two groups with different zone conditions

Change-Id: Ifba30e116f92d945f8812c15e856a5e772e077f2
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add target interface for fan control

Current fan control assumes the use of the FanSpeed interface for fan
targets.
For fans controlled by pwm, FanPwm interface is added.

This commit adds "target_i

Add target interface for fan control

Current fan control assumes the use of the FanSpeed interface for fan
targets.
For fans controlled by pwm, FanPwm interface is added.

This commit adds "target_interface" config parameter, so that user can
specify the interface for the fan targets.

E.g.

- inventory: /system/chassis/motherboard/fan0
cooling_zone: 0
cooling_profile: air
sensors:
- fan0
target_interface: xyz.openbmc_project.Control.FanPwm

The config is optional and defaults to FanSpeed, so the current code
will not be affected.

Tested: Use this config on Romulus, ensures the fan control sets
target on FanPwm interface and works fine.

Change-Id: I73adccaa770d657b5d7aaeb307917f89588524de
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Support properties of type string

Properties used within set speed events may be of type string to trigger
an action. These should be handled where the defined type attribute is
given as 'std::strin

Support properties of type string

Properties used within set speed events may be of type string to trigger
an action. These should be handled where the defined type attribute is
given as 'std::string' and a parsed value is an instance of python str
type.

Resolves openbmc/openbmc#292

Change-Id: Ib188e7abc212062a1c61950abaa28434a4726521
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Allow timers & embedded actions within an action

Add support for timer parameters to action functions along with
recursively build action functions that are a parameter to an event
action.

Change-I

Allow timers & embedded actions within an action

Add support for timer parameters to action functions along with
recursively build action functions that are a parameter to an event
action.

Change-Id: Ic126c8dfc85d5ede5f53034262f8910913e4cdd4
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Modify generating event actions

Move to constructing the entire event action parameter string within the
python code in prep for additional special parameters.

Change-Id: I517ad859813e348cd6781cc9b

Modify generating event actions

Move to constructing the entire event action parameter string within the
python code in prep for additional special parameters.

Change-Id: I517ad859813e348cd6781cc9be11ab92fa6cac09
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add timer type for set speed event timers

This is the first step towards allowing timer driven and/or wrapped
actions where the timer interval and type will be defined by the user.

Change-Id: If008

Add timer type for set speed event timers

This is the first step towards allowing timer driven and/or wrapped
actions where the timer interval and type will be defined by the user.

Change-Id: If008fda5a2b73117e869f93223e0bfe61290f858
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Generate selected handlers

The available event handlers are listed within the events yaml and would
be selected per event.

Change-Id: Ia393009b3a10b6f47f5de9a0e6d44f804576f05a
Signed-off-by: Matthe

Generate selected handlers

The available event handlers are listed within the events yaml and would
be selected per event.

Change-Id: Ia393009b3a10b6f47f5de9a0e6d44f804576f05a
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Update event initialization

Using a null dbus message to the event signal will perform the necessary
steps to initialize the event parameters using the given signal
handler's function directly.

i.e

Update event initialization

Using a null dbus message to the event signal will perform the necessary
steps to initialize the event parameters using the given signal
handler's function directly.

i.e.) In the case for subscribing to PropertiesChanged signals,
initially the given property must be read. When the PropertiesChanged
signal struct is given a null message, it finds the property, reads the
value, and then can perform the given signal handler function directly.
This produces the same functional path as receiving a PropertiesChanged
signal containing the property value within the message.

Change-Id: I35575cfff66eb0305156be786cb1f5536d42bb1c
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Generate selected match strings and signals

The available matches and their associated signals are now listed
within the events yaml and can be added to the list of matches to
register for per event

Generate selected match strings and signals

The available matches and their associated signals are now listed
within the events yaml and can be added to the list of matches to
register for per event.

Change-Id: I65f657038afe7c68a421adb4820ea09e275be06d
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Allow no parameter action functions

Action functions are not required to have parameters.

Change-Id: I04bf8294d9be9141cc7d8d3183628c94b777154a
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

Set speed event parser updates

Added some optimizations in the event yaml format to nest set speed
events that have the same preconditions and allow multiple actions to be
taken within a single set

Set speed event parser updates

Added some optimizations in the event yaml format to nest set speed
events that have the same preconditions and allow multiple actions to be
taken within a single set speed event.

Change-Id: I21ec395b6c9686e1efd5abc1be48d563480fec5f
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add timer option to run set speed event actions

For groups within set speed events where the property values of the
group may not signal its action to occur, an optional timer may be added
to the ev

Add timer option to run set speed event actions

For groups within set speed events where the property values of the
group may not signal its action to occur, an optional timer may be added
to the event. This timer is configured as a repeating timer on the
interval provided where upon timer expiration, the event's action is
run.

Change-Id: I4cbe8a0ab1b734bfc7828706a6515af7f6d78b52
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add interfacesAdded subscriptions to groups

For each group in an event, subscribe to the interfacesAdded signals in
the case where the member(s) of a group may or may not exist when
initialized.

Ad

Add interfacesAdded subscriptions to groups

For each group in an event, subscribe to the interfacesAdded signals in
the case where the member(s) of a group may or may not exist when
initialized.

Additionally, updated to use the propertiesChanged function to remove
repetitive property change subscription lines generated.

Change-Id: I52b0cd839383ebb90e93a81b5bac02ee7c4f44b2
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Update parser to support optional preconditions

Set speed events are now allowed to have preconditions defined within
the event where those preconditions must be met before the set speed
event is en

Update parser to support optional preconditions

Set speed events are now allowed to have preconditions defined within
the event where those preconditions must be met before the set speed
event is enabled and active. The supported precondition added is against
a list of groups and their properties matching a given value.

The parser generates a precondition with the same layout as a set speed
event where the event is nested as the last parameter to the
precondition function. Having the set speed event as the last input
parameter to precondition functions is required.

Resolves openbmc/openbmc#1835

Change-Id: I7a247e7eb2d6b31ba9a60da1bc321a35edda9b24
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add increase & decrease timer values in seconds

Support setting the increase delay time(in seconds) for each zone from
the zone yaml file. Speed increases use a delay type timer where the
amount of

Add increase & decrease timer values in seconds

Support setting the increase delay time(in seconds) for each zone from
the zone yaml file. Speed increases use a delay type timer where the
amount of time given delays additional increase requests from happening
until the fans within the zone reach the highest net increase in speeds.

Support setting the decrease interval time(in seconds) for each zone
from the zone yaml file. Since decreasing is done on an interval, a
decrease interval time of zero disables the decrease interval timer
causing no decreases in speed to occur. Speed decreases use an interval
type timer to decrease the fan speeds within the zone when no speed
increase requests exist on the given time interval.

Change-Id: I88334a313b6e2820b768fa7e3f1cb65887f29258
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...