Update to latest release of nlohmann

3.11.2 -> 3.11.3

Change-Id: Ie0c59af0f5941b4c108bd022c54e46e40673b3fd
Signed-off-by: Ed Tanous <etanous@nvidia.com>

unit-test: Set to none after sanitizer

The unit test contains a step to do sanitize test by
`-Db_sanitize=address,undefined`, and remove the config after it's done.
However, the meson generated `com

unit-test: Set to none after sanitizer

The unit test contains a step to do sanitize test by
`-Db_sanitize=address,undefined`, and remove the config after it's done.
However, the meson generated `compile_commands.json` still contains the
`-fsanitize=address,undefined` compile option. If we run the unit test
again, it will cause valgrind test reporting error as below:

```
ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD.
```

To correctly disable sanitizer, `-Db_sanitize=none` is needed to
specifically tell meson to disable it.

Tested: Run sdbusplus's unit test twice without issue. Without this
change, the second run will get the above valgrind error.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: Iebde8ce80b498a039de4f2713b5c16561ca63b09

show more ...

Use clang as C compiler

When setting up the clang build, use clang as the C compiler and the C++
compiler. This matters for C libraries where we might want to set up
fuzzing. Having the C portions

Use clang as C compiler

When setting up the clang build, use clang as the C compiler and the C++
compiler. This matters for C libraries where we might want to set up
fuzzing. Having the C portions compile with GCC prevents compiling with
libfuzzer flags.

Change-Id: I113693bc139f4ebb58107e3df26ee82cc460f460
Signed-off-by: Ed Tanous <etanous@nvidia.com>

show more ...

gitlint: screen userid from Signed-off-by

It is a common issue for new users to have a git-config that has a
user id (either from their system or github) rather than a legal name
matching an entry i

gitlint: screen userid from Signed-off-by

It is a common issue for new users to have a git-config that has a
user id (either from their system or github) rather than a legal name
matching an entry in their associated CLA. Screen these out in the
gitlint check, so maintainers do not need to check this manually.

Some individuals decide to go by a one word name. Provide an exception
for this.

Tested:

```
-: UC3 Signed-off-by user has too few words; likely user id instead of legal name?: "Signed-off-by: foo <foo@nobody.com>"
-: UC3 Invalid Signed-off-by format: "Signed-off-by: bar"
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie87d640db8f0d223912f7c3b77545347020255ee

show more ...

gitlint: screen multiple change-ids

Tested:
```
$ ./scripts/format-code.sh --enable commit_gitlint
Formatting code under .../openbmc-build-scripts
Running commit_gitlint
-: UC2 Multiple Chan

gitlint: screen multiple change-ids

Tested:
```
$ ./scripts/format-code.sh --enable commit_gitlint
Formatting code under .../openbmc-build-scripts
Running commit_gitlint
-: UC2 Multiple Change-Ids found in commit message body: "['Change-Id: Iec3501f75927d58bfe176423ce3eac824a0553d9', 'Change-Id: Iec3501f75927d58bfe176423ce3eac824a0553d9']"
commit_gitlint: FAILED
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iec3501f75927d58bfe176423ce3eac824a0553d9

show more ...

unit-test: Remove `UBSAN_OPTIONS=halt_on_error=1`

Setting `UBSAN_OPTIONS=halt_on_error=1` here makes adding the
`UBSAN_OPTION` environment variable ineffective (like
`suppressions=ubsan.supp` or `pr

unit-test: Remove `UBSAN_OPTIONS=halt_on_error=1`

Setting `UBSAN_OPTIONS=halt_on_error=1` here makes adding the
`UBSAN_OPTION` environment variable ineffective (like
`suppressions=ubsan.supp` or `print_summary=1`). This environment
variable is always overwritten.

The mechanism that makes UBSAN kill tests is no longer needed when using
meson version 1.3.0 or higher
https://github.com/mesonbuild/meson/commit/7b7d2e060b where default
```
UBSAN_OPTION=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1
```

Resolves: openbmc/openbmc-build-scripts#43

Tested:
- Run `run-unit-test-docker.sh` without setting env variable, with
`invalid vptr` error - tests failed with more info in logs (stack trace,
summary)
- Run `run-unit-test-docker.sh` with setting env variable
`UBSAN_OPTION=suppressions=ubsan.supp` with suppression for vptr check
and with bug location - tests passed

Change-Id: I64eb799645dbc9cde4b7ee75098b641ebe30a5a4
Signed-off-by: Ewelina Walkusz <ewelinax.walkusz@intel.com>

show more ...

format-code: enable meson format linting

Meson has a format utility built-in now. Use this to format
both meson.build and meson.option files so we have consistent
formatting.

Signed-off-by: Patric

format-code: enable meson format linting

Meson has a format utility built-in now. Use this to format
both meson.build and meson.option files so we have consistent
formatting.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6ad7b24ca02ca86ddb3c45cb1b14f459349ad8ab

show more ...

build-setup.sh: prevent git clone when only building container

When someone wants to just build the container, there's no need to clone
openbmc.

Tested:
- Confirmed no clone when CONTAINER_ONLY set

build-setup.sh: prevent git clone when only building container

When someone wants to just build the container, there's no need to clone
openbmc.

Tested:
- Confirmed no clone when CONTAINER_ONLY set to true
- Confirmed a clone when CONTAINER_ONLY is not set

Change-Id: I7765c8511cffe2db9b94f3e8e5815300fd9c65f1
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

build-unit-test-docker: Add libmpfr-dev

After meson bump, clang-tidy reports an error when using
boost::multiprecision based on the MPFR library

```
/usr/local/include/boost/multiprecision/mpfr.hp

build-unit-test-docker: Add libmpfr-dev

After meson bump, clang-tidy reports an error when using
boost::multiprecision based on the MPFR library

```
/usr/local/include/boost/multiprecision/mpfr.hpp:22:10: error: 'mpfr.h' file not found [clang-diagnostic-error]
```

Change-Id: I76db10af842926f5767c897b92f1ccc0f63ffdbe
Signed-off-by: Ewelina Walkusz <ewelinax.walkusz@intel.com>

show more ...

unit-test: Add ability to skip cppcheck

Now you can run openbmc-build-scripts/run-unit-test-docker.sh with
`NO_CPPCHECK=1` to skip cppcheck

We need this mechanizm in case cppcheck hangs. This probl

unit-test: Add ability to skip cppcheck

Now you can run openbmc-build-scripts/run-unit-test-docker.sh with
`NO_CPPCHECK=1` to skip cppcheck

We need this mechanizm in case cppcheck hangs. This problem can occur
when compiling with the BOOST_NO_RTTI and BOOST_NO_TYPEID flags.

Tested:
- Run `run-unit-test-docker.sh` as before, verify cppcheck runs
- Run `NO_CPPCHECK=1 run-unit-test-docker.sh`, verify cppcheck is
skipped

Change-Id: Ib1b246dc932b3b36334bfbe51934c206bdeb936f
Signed-off-by: Ewelina Walkusz <ewelinax.walkusz@intel.com>

show more ...

userid-validation: add sipearl

SiPearl has submitted a CCLA and it has been uploaded to our
shared google drive.

Change-Id: I9b48378d8a9e8253b77ef744b5c9fad4d3307131
Signed-off-by: Andrew Geissler

userid-validation: add sipearl

SiPearl has submitted a CCLA and it has been uploaded to our
shared google drive.

Change-Id: I9b48378d8a9e8253b77ef744b5c9fad4d3307131
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

userid-validation: add multicoreware

Multicoreware has submitted a CCLA and it has been uploaded to our
shared google drive.

Change-Id: I7ae6736bd708902c89d55cf250d1af168262f461
Signed-off-by: Andr

userid-validation: add multicoreware

Multicoreware has submitted a CCLA and it has been uploaded to our
shared google drive.

Change-Id: I7ae6736bd708902c89d55cf250d1af168262f461
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Update robotframework version

Changes:
- Update version from 7.0.1 to 7.1.1 due to fixes
and enhancements.

Tested:
- Tested version on local sandbox
Robot Framework 7.1.1 (Pytho

Update robotframework version

Changes:
- Update version from 7.0.1 to 7.1.1 due to fixes
and enhancements.

Tested:
- Tested version on local sandbox
Robot Framework 7.1.1 (Python 3.10.12 on linux)

Change-Id: I46e959c3b166d5b2f4a5a0095c33fe66f16674e1
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

build-unit-test-docker: update meson to 1.7.0

Meson 1.7.0 was released and is in the latest Yocto master
branch. Update our unit test container as well.

Signed-off-by: Patrick Williams <patrick@st

build-unit-test-docker: update meson to 1.7.0

Meson 1.7.0 was released and is in the latest Yocto master
branch. Update our unit test container as well.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I760b9092fbd1ac0a6c7307261e2d077c94f6773c

show more ...

userid-validation: add hetzner

A new CLA from Hetzner has been accepted and uploaded to the google
drive

Change-Id: Ia7557e94ec794a1f7479b9df6c757f374dfbf2e6
Signed-off-by: Andrew Geissler <geisson

userid-validation: add hetzner

A new CLA from Hetzner has been accepted and uploaded to the google
drive

Change-Id: Ia7557e94ec794a1f7479b9df6c757f374dfbf2e6
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

build-unit-test-docker: upgrade meson to 1.6.1

Tested: run-unit-test-docker.sh runs correctly

Change-Id: Ifa4bc74d707d1c0b12bf9b147fd03e0e3c075262
Signed-off-by: Ewelina Walkusz <ewelinax.walkusz@i

build-unit-test-docker: upgrade meson to 1.6.1

Tested: run-unit-test-docker.sh runs correctly

Change-Id: Ifa4bc74d707d1c0b12bf9b147fd03e0e3c075262
Signed-off-by: Ewelina Walkusz <ewelinax.walkusz@intel.com>

show more ...

unit-test: Reconfigure after sanitizers

After running `meson configure build -Db_sanitize=none`, there may be
leftovers that cause the next analysis to fail:
`ASan runtime does not come first in ini

unit-test: Reconfigure after sanitizers

After running `meson configure build -Db_sanitize=none`, there may be
leftovers that cause the next analysis to fail:
`ASan runtime does not come first in initial library list; you should
either link runtime to your application or manually preload it with
LD_PRELOAD.`

Fixes: openbmc/openbmc-build-scripts#42

Change-Id: Ia5b3c6c8a076c61aadd70ab23c029c591a3e29f5
Signed-off-by: Ewelina Walkusz <ewelinax.walkusz@intel.com>

show more ...

build-unit-test-docker: use heredoc-copy for wgetrc

The "heredoc" support in Docker can be a bit tedious with indented
content. Most of the examples do not indent it, but start at the
beginning [1].

build-unit-test-docker: use heredoc-copy for wgetrc

The "heredoc" support in Docker can be a bit tedious with indented
content. Most of the examples do not indent it, but start at the
beginning [1].

To prevent any weird behavior with "RUN cat" heredoc's, we should
use the native "COPY heredoc" feature which is mentioned at the end
of the blog [1].

[1] https://www.docker.com/blog/introduction-to-heredocs-in-dockerfiles/

Fixes: f7e5261 ("build-unit-test-docker: Add .wgetrc for proxy")
Change-Id: I41b09c093fe5c5954e0411582806434ae6a148d0
Signed-off-by: Tan Siewert <tan@siewert.io>

show more ...

build-unit-test-docker: Add .wgetrc for proxy

The script now uses `wget -O - https://apt.llvm.org/llvm.sh` to download
the llvm.sh.

If http_proxy is set, set the proxy to .wgetrc in the docker cont

build-unit-test-docker: Add .wgetrc for proxy

The script now uses `wget -O - https://apt.llvm.org/llvm.sh` to download
the llvm.sh.

If http_proxy is set, set the proxy to .wgetrc in the docker container
so that it could be used by `wget` when building the unit test docker.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I5cb305515cb4f79e5fd759bf1844a110f106a049

show more ...

gitlint: allow Fixes to exceed line length

The Kernel convention for "Fixes" directives is as follows[1]:

```
If your patch fixes a bug in a specific commit, e.g. you found an issue
using git bisec

gitlint: allow Fixes to exceed line length

The Kernel convention for "Fixes" directives is as follows[1]:

```
If your patch fixes a bug in a specific commit, e.g. you found an issue
using git bisect, please use the ‘Fixes:’ tag with the first 12
characters of the SHA-1 ID, and the one line summary. Do not split the
tag across multiple lines, tags are exempt from the “wrap at 75
columns” rule in order to simplify parsing scripts.
```

Some repositories follow this convention, so allow it in the commit
message by ignoring lines that start with "Fixes:".

[1]: https://docs.kernel.org/process/submitting-patches.html

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I81aa98663d421ff670f09dd048d12a48c32ce3c5

show more ...

build-setup.sh: remove ARCH from container name

We removed the architecture check a while ago. Remove it from the
container name so we stop getting weird names like
openbmc/ubuntu:latest-p10bmc-

Te

build-setup.sh: remove ARCH from container name

We removed the architecture check a while ago. Remove it from the
container name so we stop getting weird names like
openbmc/ubuntu:latest-p10bmc-

Tested:
- Confirmed we now get openbmc/ubuntu:latest-p10bmc for a container name

Change-Id: Ib0414d46f128af714e0a339292da8086180f0117
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

build-unit-test-docker: remove 'yamldir' option to phosphor-logging

phosphor-logging currently uses the `phosphor-dbus-interfaces.pc`
file by default to determine the location of the install YAML,
i

build-unit-test-docker: remove 'yamldir' option to phosphor-logging

phosphor-logging currently uses the `phosphor-dbus-interfaces.pc`
file by default to determine the location of the install YAML,
in order to generate appropriate headers for error metadata.
`phosphor-dbus-interfaces` changed where the YAML is installed, but
the yamldir value here did not match. Remove it entirely and fall
back to obtaining the one from the pkg-config.

Tested: Ensured `phosphor-networkd` compiled using this container.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ibe2168a05e7ad5be0e497c9bcfc6cadac7607a5d

show more ...

build-unit-test-docker: upgrade meson to 1.5.1

Poky is using meson 1.5.1

Tested: run-unit-test-docker.sh runs correctly

Change-Id: I9b4b27b72118dcb15a9616ca78edf8a087cd4481
Signed-off-by: Ewelina

build-unit-test-docker: upgrade meson to 1.5.1

Poky is using meson 1.5.1

Tested: run-unit-test-docker.sh runs correctly

Change-Id: I9b4b27b72118dcb15a9616ca78edf8a087cd4481
Signed-off-by: Ewelina Walkusz <ewelinax.walkusz@intel.com>

show more ...

openbmc-build-scripts: add `libcurl` dependency to test redflish client

On some system designs we need a "redfish client" to query metrics from
an http(s) server running on an Satellite Management C

openbmc-build-scripts: add `libcurl` dependency to test redflish client

On some system designs we need a "redfish client" to query metrics from
an http(s) server running on an Satellite Management Controller
instance, such as the Nvidia HMC[1], and forward those metrics to BMC
monitoring the devices.

There is a design document proposal available[2]. Adding `libcurl`
enables prototyping of the "Redfish client" instances following this
design document and run them on the official container.

[1]: https://github.com/openbmc/entity-manager/blob/master/configurations/nvidia_hmc.json#L14
[2]: https://gerrit.openbmc.org/c/openbmc/docs/+/75641/9/designs/redfish-client.md#154

Change-Id: I4848fb76edffb09d12891460972f9fb676d0d48a
Signed-off-by: Anirban Banerjee <anirbanb@meta.com>

show more ...

build-unit-test-docker: fix clang version argument

The latest version of bash seems to not pass additional arguments
when called with `-c` unless those arguments are after the `--`.

This caused the

build-unit-test-docker: fix clang version argument

The latest version of bash seems to not pass additional arguments
when called with `-c` unless those arguments are after the `--`.

This caused the build-unit-test-docker to not install the latest
version of clang, but instead the release of clang that was present
in the Ubuntu repository.

Add "19" after `--` so that the latest versions of clang tools are
installed.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I894b77b2a03e9125df50a297c9898b3456846cdc

show more ...