Add libaudit-dev package to the base container

There has been work going on in bmcweb to leverage linux
libaudit framework for auditlogging. The idea behind this
commit is to add the libaudit-dev pa

Add libaudit-dev package to the base container

There has been work going on in bmcweb to leverage linux
libaudit framework for auditlogging. The idea behind this
commit is to add the libaudit-dev package into the CI base
container to let the bmcweb commits pass CI.

libaudit-dev package contains the header files & static library
for security auditing.

Change-Id: Iac7b5089aa8788dabb1554c01cb4dcf12bb44ac9
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

docker:buildkit: ensure container build output is generated

Some newer distributions are moving to buildkit which is an improved
backend to docker that replaces the legacy builder. This new backend

docker:buildkit: ensure container build output is generated

Some newer distributions are moving to buildkit which is an improved
backend to docker that replaces the legacy builder. This new backend
builder has different rules on what it outputs to the console as it
builds an image.

To ensure we get the normal verbose output we're used to, set the
BUILDKIT_PROGRESS env variable.

There's also a parameter you can pass to docker build (--progress) but
it doesn't appear in the --help of older docker build commands so it's
best to just utilize the env variable option.

Change-Id: I520c0b933f920b05937e68a76fb7bd02ff889bc4
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

cppcheck: enable inline-suppr

Allow inline suppression of cppcheck errors for special cases. Some
example use cases might be:

- suppress accessMoved in a unit test for a move constructor (ensuring

cppcheck: enable inline-suppr

Allow inline suppression of cppcheck errors for special cases. Some
example use cases might be:

- suppress accessMoved in a unit test for a move constructor (ensuring
the moved from object is in the expected state).
- suppress noExplicitConstructor for RAII types where implicit
conversion is intentional and desired.

Change-Id: I560d780fdf9266dc54662a9eeb6ed6986fc271a8
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Run clang-tidy in meson

Meson has built in functionality for running clang-tidy. It improves on
run-clang-tidy because it will also run each header file individually,
rather than relying on their #

Run clang-tidy in meson

Meson has built in functionality for running clang-tidy. It improves on
run-clang-tidy because it will also run each header file individually,
rather than relying on their #inclusion into a src file, which can find
far more missing #includes, and seems to find more issues in complex
source files (unclear why).

Tested: I've walked through all the repos that have a .clang-tidy, and
I've systematically fixed the issues, so hopefully this change has no
impact. I have yet to see this cause any functional impact.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I62520056192d876938ddab4d7cdafc954fa1806d

show more ...

black: remove --preview

The --preview option is more likely to cause churn in our Python
formatting. Disable it.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I96e6e7fbd6607c478ca

black: remove --preview

The --preview option is more likely to cause churn in our Python
formatting. Disable it.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I96e6e7fbd6607c478ca38c5de8a0db0c30b180a5

show more ...

build-unit-test-docker: update per new format rules

New formatting rules require this change

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ieef4c1359d065daa5c636c42cc0618b287285

build-unit-test-docker: update per new format rules

New formatting rules require this change

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ieef4c1359d065daa5c636c42cc0618b287285307

show more ...

unit-test: support install process in cmake

This change allows cmake-based project to install the
executable/library/configuration to the right directory.

Tested:
Manually run the commands below in

unit-test: support install process in cmake

This change allows cmake-based project to install the
executable/library/configuration to the right directory.

Tested:
Manually run the commands below in the docker.
```
$ sudo cmake --install .
-- Install configuration: ""
-- Installing: /usr/local/lib/xxx.so
-- Installing: /usr/local/include/xxx.h
-- Installing: /usr/local/bin/xxx_tool
```

Change-Id: Ica9f0c26c57baca5d46067c1bb55ecccc2d8fc58
Signed-off-by: Michael Shen <gpgpgp@google.com>

show more ...

Make clang-tidy projects compile on clang

Compiling individual repos on clang gives us an extra set of checks, and
ensures that we are coding to the c++ standard, and not to gcc
specifics. In pract

Make clang-tidy projects compile on clang

Compiling individual repos on clang gives us an extra set of checks, and
ensures that we are coding to the c++ standard, and not to gcc
specifics. In practice, a lot of the repos have compiled against clang
for a while, but leads to maintainers jumping in from time to time to
fix the clang build with seemingly minor changes that are better caught
at review time.

This commit causes the clang build (created as part of the tidy checks)
to actually compile, which can find issues like
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/51346 that clang
finds, but gcc does not (or allows silently).

I walked through every repo I'm aware of that are relying on clang-tidy,
and made sure that they compile with clang. bmcweb, dbus-sensors, and
entity-manager have patchsets in review to resolve the minor issues,
that should be merged before this.

sdeventplus builds with clang as-is.

Tested:
Compiled repos above against clang with the aforementioned commits, and
build passed.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I310f9aebc75fe4bc9645c4c961ca0caf8f94b4d5

show more ...

Add json-c as unit test build dependency

nbd-proxy.c needs json-c as dependency - CI run fails on that.

Added latest tagged git version (json-c-0.16-2022041) the same as in
the OpenBMC.

Tested:
lo

Add json-c as unit test build dependency

nbd-proxy.c needs json-c as dependency - CI run fails on that.

Added latest tagged git version (json-c-0.16-2022041) the same as in
the OpenBMC.

Tested:
locally passed run-unit-test-docker.sh on jsnbd repository.

Change-Id: I837247a2c4b9ebee3081cea3adae68364da269f9
Signed-off-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@intel.com>

show more ...

qemu: misc fixes for new qemu release

- Ensure qemu is built in same ubuntu distro as where it is run
- Add new libslirp-dev dep to docker container that executes qemu

Signed-off-by: Andrew Geissle

qemu: misc fixes for new qemu release

- Ensure qemu is built in same ubuntu distro as where it is run
- Add new libslirp-dev dep to docker container that executes qemu

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Iaa58d097de0377e4bb5ee229c5ec267ebe4565a7

show more ...

Upgrade to boost 1.81.0

Per the other commits, we are temporarily moving to boost 1.81.0 to get
ahead of some of the API breaking changes in boost-url. This requires
moving CI off of using the yoct

Upgrade to boost 1.81.0

Per the other commits, we are temporarily moving to boost 1.81.0 to get
ahead of some of the API breaking changes in boost-url. This requires
moving CI off of using the yocto mirror. So far as I'm aware, the boost
bandwidth issues have been long solved, so this should be fine.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Iec89a040374bef52c5188c89be9f8a25a12d6164

show more ...

openbmc-build-scripts: add vim to container

There are times when interactively working within a CI unit test docker
container that having vim available is useful.

Change-Id: I564e1882e325e5b871eda9

openbmc-build-scripts: add vim to container

There are times when interactively working within a CI unit test docker
container that having vim available is useful.

Change-Id: I564e1882e325e5b871eda9c0defaec51d4a7bf0d
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

build-unit-test-docker: sort apt packages

Make it easier to identify if a needed package is being installed

Change-Id: Iba108c6ddddc9ee25bd7341b41e79d7c82f231bb
Signed-off-by: Andrew Geissler <geis

build-unit-test-docker: sort apt packages

Make it easier to identify if a needed package is being installed

Change-Id: Iba108c6ddddc9ee25bd7341b41e79d7c82f231bb
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

format-code: enable markdownlint

Enable markdownlint but allow it to always pass. This will allow
maintainers the opportunity to run the tools and fix up their own
markdown before we enable this gl

format-code: enable markdownlint

Enable markdownlint but allow it to always pass. This will allow
maintainers the opportunity to run the tools and fix up their own
markdown before we enable this globally.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie397a72ca4ef113cdbe433d263ccf3bd5063cf4b

show more ...

format-code: enable black/isort

* black is a widely used python formatting tool.
* isort is used to order python imports in a consistent way.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

format-code: enable black/isort

* black is a widely used python formatting tool.
* isort is used to order python imports in a consistent way.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1918421120ce2942f04b9110a2c0f1bd820d21c7

show more ...

format-code: enable beautysh

beautysh is a code formatter for bash/sh/zsh.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0ebd5da9e78d84a98940fb3e6618b12cf8eb0fc7

format-code: enable prettier

prettier is a formatter for YAML, JSON, Markdown, etc.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7a47d02ef7382d811423b97a88132aa92b991eed

format-code: enable shellcheck everywhere

I have contributed fixes (or linter ignores) to all repositories
so that shellcheck passes. Enable it everywhere.

Signed-off-by: Patrick Williams <patrick

format-code: enable shellcheck everywhere

I have contributed fixes (or linter ignores) to all repositories
so that shellcheck passes. Enable it everywhere.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1b771d9492f2ba3665e84e59beabee33dcc96f6f

show more ...

format-code: enable flake8 instead of pycodestyle

flake8 is a more complete python linter than pycodestyle
as it contains pycodestyle, pyflakes and mccabe. I have
contributed fixes to all repositor

format-code: enable flake8 instead of pycodestyle

flake8 is a more complete python linter than pycodestyle
as it contains pycodestyle, pyflakes and mccabe. I have
contributed fixes to all repositories so that flake8 passes,
so switch from pycodestyle to flake8 and enable everywhere.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I93867773830d476809364f44ad78104241d66a2a

show more ...

Remove packaging dependency

Once https://gerrit.openbmc.org/c/openbmc/bmcweb/+/59633 merges, we will
no longer need packaging as a dependecy. Remove it.

Signed-off-by: Ed Tanous <edtanous@google.c

Remove packaging dependency

Once https://gerrit.openbmc.org/c/openbmc/bmcweb/+/59633 merges, we will
no longer need packaging as a dependecy. Remove it.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ibd75ba7290a4dbd32fe0dddbb6d47ecef78ca7c6

show more ...

format-code: detect tcl files

openbmc-test-automation has a few tcl files which are incorrectly
identified as bash by the `file` utility. Explicitly catch this
extension and classify as 'tcl' even

format-code: detect tcl files

openbmc-test-automation has a few tcl files which are incorrectly
identified as bash by the `file` utility. Explicitly catch this
extension and classify as 'tcl' even though we don't have a linter
for that language.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2bb45b21398819d6a73cfa99aa1b5ef5f4bed164

show more ...

format-code: option to explicitly enable linters

Sometimes it is useful to explicitly enable a single (or set of)
linters. Add an option (`--enable <tool>`) such that if any enable
is set then only

format-code: option to explicitly enable linters

Sometimes it is useful to explicitly enable a single (or set of)
linters. Add an option (`--enable <tool>`) such that if any enable
is set then only those linters will be utilized.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I49e4b760217e6a0df5c16275c466958b3a2422b3

show more ...

format-code: handle incorrect 'env python3'

I noticed the `tools/owners` file was not getting the linters ran
correctly and upon investigation I found that it had the wrong path
for env, which cause

format-code: handle incorrect 'env python3'

I noticed the `tools/owners` file was not getting the linters ran
correctly and upon investigation I found that it had the wrong path
for env, which caused `file` to give incorrect results.

Fix the path in tools/owners, reformat and fix linter issues, and
ensure the scripts can handle python3 scripts with the wrong env
path.

I checked the codebase and there was only one other script, which
happens to reside in openbmc/openbmc, which used this incorrect
path. Therefore this change should have no effect on existing
repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ice9703afbf104e3529f2c1b29ba8ba680eb07d94

show more ...

format-code: pycodestyle: add some compatibility for black/flake8

Black has some formatting defaults that disagree with pycodestyle.
Add options to pycodestyle to disable all default-disabled checks

format-code: pycodestyle: add some compatibility for black/flake8

Black has some formatting defaults that disagree with pycodestyle.
Add options to pycodestyle to disable all default-disabled checks
plus two that are incompatible with black. This allows commits to get
in to other repos in preparation for black/flake8 roll-out.

When we switch to black/flake8 these two extras will also be disabled
in flake8.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I86b4e2d21c7a89c40b98aadc3074a554201af93d

show more ...

format shell scripts with beautysh

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie72911e0f57a1f69b0bf317de8c52947886e1303