build-unit-test-docker: update to clang-16

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I59cf51cdb89476d9da4934d0cf6be44fc2cf6bc1

Update boost 1.81 -> 1.82

The latest yocto update pulled in the new boost version. Update it.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Idb39a2ac496b6c1e54cd6c87682c7847e7f848a8

build-unit-test-docker: move homedir with usermod

When the uid already exists, we do a usermod instead of a useradd,
but this does not create the new home directory. We need to pass
the `-m` argume

build-unit-test-docker: move homedir with usermod

When the uid already exists, we do a usermod instead of a useradd,
but this does not create the new home directory. We need to pass
the `-m` argument in order to move the old home directory to the
new location.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9f2cabe982af0b09d3c3f65dcd3a0acb6b8f3591

show more ...

build-unit-test-docker: Use curl for getting keys

apt-key fails to get keys when behind a firewall. Use curl to
get keys via http proxy and add them using apt-key add.

Tested: docker build and run

build-unit-test-docker: Use curl for getting keys

apt-key fails to get keys when behind a firewall. Use curl to
get keys via http proxy and add them using apt-key add.

Tested: docker build and run using "scripts/build-unit-test-docker".

Change-Id: I3fa3e4cdd326681b72a77ac251de76a9359ce706
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

unit-test: Make UBSAN kill tests

Continuing to exploit the runtime library means we get useful
diagnostics printed rather than just the application generating a core.

Change-Id: I0b93e61bbca48eb5a7

unit-test: Make UBSAN kill tests

Continuing to exploit the runtime library means we get useful
diagnostics printed rather than just the application generating a core.

Change-Id: I0b93e61bbca48eb5a79ba6fa9228431d36504f64
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

unit-test: add meson version check for get_variable

Some repositories are using the newer `get_variable` call in meson
without a keyword argument. This requires meson 0.58 or later. I've
contribut

unit-test: add meson version check for get_variable

Some repositories are using the newer `get_variable` call in meson
without a keyword argument. This requires meson 0.58 or later. I've
contributed fixes for all repositories under the
`meson_deprecated_pkgconfig` topic and so am also adding a CI catch
to prevent future regressions.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9465c3946825ec96d0c934635685e85d74fdf4ee

show more ...

build-unit-test-docker: switch to ubuntu:lunar

Besides the usual changes, upgrade requires the following:

- remove liburing2-dbgsym - package no longer exists
- pip3 add `--break-system-packages` -

build-unit-test-docker: switch to ubuntu:lunar

Besides the usual changes, upgrade requires the following:

- remove liburing2-dbgsym - package no longer exists
- pip3 add `--break-system-packages` - pip3 will no longer install
content at the system level without this.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic84e19c7c0f0e3be0057126d562b4aab00392aaf

show more ...

build-unit-test-docker: handle existing user/group

Ubuntu Lunar docker images contain a 'ubuntu' user and group by
default at 1000. The current code will skip creating a user if
the gid/uid already

build-unit-test-docker: handle existing user/group

Ubuntu Lunar docker images contain a 'ubuntu' user and group by
default at 1000. The current code will skip creating a user if
the gid/uid already exist but then attempt to `chown` a path to
the `{username}:{username}` that it didn't create (which fails).

Rather than do-nothing if the gid/uid already exist, use groupmod
and usermod to modify those as appropriate.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie07146be1bd2ce9bce2aac818da2f01665dba890

show more ...

build-unit-test-docker: update meson to 1.0.1

The version in poky is currently 1.0.1, so upgrade to that for
consistency.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I39cae4bcb0c

build-unit-test-docker: update meson to 1.0.1

The version in poky is currently 1.0.1, so upgrade to that for
consistency.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I39cae4bcb0cb8578fe621851597cb467d8055d4f

show more ...

build-unit-test-docker: turn 'pip3 install' calls into one invocation

Future Ubuntu is going to require us to pass in a parameter to
`pip3 install`. Reduce the number of RUN commands to simplify th

build-unit-test-docker: turn 'pip3 install' calls into one invocation

Future Ubuntu is going to require us to pass in a parameter to
`pip3 install`. Reduce the number of RUN commands to simplify that
future invocation.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9f5d4d6b43c637dbfeb6beaadfb5bf80f82cefc3

show more ...

boot-qemu: shellcheck fix

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic13f10cf1393cb3d55e2f33c49abdf5918892832

build-unit-test-docker: remove openbmc/linux dependency

Downloading the entire openbmc/linux repository is pretty slow
due to the way the Github CDN works on these kinds of files (and
how large it i

build-unit-test-docker: remove openbmc/linux dependency

Downloading the entire openbmc/linux repository is pretty slow
due to the way the Github CDN works on these kinds of files (and
how large it is). On my home connection I typically see ~100kbps
on this download, which would equate to over 15 minutes of a download.

This was originally done so that we could get kernel headers for
interfaces that we didn't have upstreamed yet but everything is now
upstreamed so this is not necessary.

If this becomes necessary again in the future, it would be better
to explicitly download specific headers from the respository instead
of attempting to get the entire thing.

Tested:

The necessary headers are now provided by `linux-libc-dev`:
```
$ docker run --rm -it openbmc/ubuntu-unit-test:2023-W15-c977bb8f48b9ee3b
root@e20efded42fb:/# dpkg -S /usr/include/linux/ipmi_bmc.h
linux-libc-dev:amd64: /usr/include/linux/ipmi_bmc.h
root@e20efded42fb:/# dpkg -S /usr/include/linux/bt-bmc.h
linux-libc-dev:amd64: /usr/include/linux/bt-bmc.h
```

Also manually ran `btbridge` and `ipmbbridge` under the
`run-unit-test-docker.sh` with successful results.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7689c59e6cb290ac1a703cbf7994d2d9b6434482

show more ...

Add libaudit-dev package to the base container

There has been work going on in bmcweb to leverage linux
libaudit framework for auditlogging. The idea behind this
commit is to add the libaudit-dev pa

Add libaudit-dev package to the base container

There has been work going on in bmcweb to leverage linux
libaudit framework for auditlogging. The idea behind this
commit is to add the libaudit-dev package into the CI base
container to let the bmcweb commits pass CI.

libaudit-dev package contains the header files & static library
for security auditing.

Change-Id: Iac7b5089aa8788dabb1554c01cb4dcf12bb44ac9
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

docker:buildkit: ensure container build output is generated

Some newer distributions are moving to buildkit which is an improved
backend to docker that replaces the legacy builder. This new backend

docker:buildkit: ensure container build output is generated

Some newer distributions are moving to buildkit which is an improved
backend to docker that replaces the legacy builder. This new backend
builder has different rules on what it outputs to the console as it
builds an image.

To ensure we get the normal verbose output we're used to, set the
BUILDKIT_PROGRESS env variable.

There's also a parameter you can pass to docker build (--progress) but
it doesn't appear in the --help of older docker build commands so it's
best to just utilize the env variable option.

Change-Id: I520c0b933f920b05937e68a76fb7bd02ff889bc4
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

cppcheck: enable inline-suppr

Allow inline suppression of cppcheck errors for special cases. Some
example use cases might be:

- suppress accessMoved in a unit test for a move constructor (ensuring

cppcheck: enable inline-suppr

Allow inline suppression of cppcheck errors for special cases. Some
example use cases might be:

- suppress accessMoved in a unit test for a move constructor (ensuring
the moved from object is in the expected state).
- suppress noExplicitConstructor for RAII types where implicit
conversion is intentional and desired.

Change-Id: I560d780fdf9266dc54662a9eeb6ed6986fc271a8
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Run clang-tidy in meson

Meson has built in functionality for running clang-tidy. It improves on
run-clang-tidy because it will also run each header file individually,
rather than relying on their #

Run clang-tidy in meson

Meson has built in functionality for running clang-tidy. It improves on
run-clang-tidy because it will also run each header file individually,
rather than relying on their #inclusion into a src file, which can find
far more missing #includes, and seems to find more issues in complex
source files (unclear why).

Tested: I've walked through all the repos that have a .clang-tidy, and
I've systematically fixed the issues, so hopefully this change has no
impact. I have yet to see this cause any functional impact.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I62520056192d876938ddab4d7cdafc954fa1806d

show more ...

black: remove --preview

The --preview option is more likely to cause churn in our Python
formatting. Disable it.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I96e6e7fbd6607c478ca

black: remove --preview

The --preview option is more likely to cause churn in our Python
formatting. Disable it.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I96e6e7fbd6607c478ca38c5de8a0db0c30b180a5

show more ...

build-unit-test-docker: update per new format rules

New formatting rules require this change

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ieef4c1359d065daa5c636c42cc0618b287285

build-unit-test-docker: update per new format rules

New formatting rules require this change

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ieef4c1359d065daa5c636c42cc0618b287285307

show more ...

unit-test: support install process in cmake

This change allows cmake-based project to install the
executable/library/configuration to the right directory.

Tested:
Manually run the commands below in

unit-test: support install process in cmake

This change allows cmake-based project to install the
executable/library/configuration to the right directory.

Tested:
Manually run the commands below in the docker.
```
$ sudo cmake --install .
-- Install configuration: ""
-- Installing: /usr/local/lib/xxx.so
-- Installing: /usr/local/include/xxx.h
-- Installing: /usr/local/bin/xxx_tool
```

Change-Id: Ica9f0c26c57baca5d46067c1bb55ecccc2d8fc58
Signed-off-by: Michael Shen <gpgpgp@google.com>

show more ...

Make clang-tidy projects compile on clang

Compiling individual repos on clang gives us an extra set of checks, and
ensures that we are coding to the c++ standard, and not to gcc
specifics. In pract

Make clang-tidy projects compile on clang

Compiling individual repos on clang gives us an extra set of checks, and
ensures that we are coding to the c++ standard, and not to gcc
specifics. In practice, a lot of the repos have compiled against clang
for a while, but leads to maintainers jumping in from time to time to
fix the clang build with seemingly minor changes that are better caught
at review time.

This commit causes the clang build (created as part of the tidy checks)
to actually compile, which can find issues like
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/51346 that clang
finds, but gcc does not (or allows silently).

I walked through every repo I'm aware of that are relying on clang-tidy,
and made sure that they compile with clang. bmcweb, dbus-sensors, and
entity-manager have patchsets in review to resolve the minor issues,
that should be merged before this.

sdeventplus builds with clang as-is.

Tested:
Compiled repos above against clang with the aforementioned commits, and
build passed.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I310f9aebc75fe4bc9645c4c961ca0caf8f94b4d5

show more ...

Add json-c as unit test build dependency

nbd-proxy.c needs json-c as dependency - CI run fails on that.

Added latest tagged git version (json-c-0.16-2022041) the same as in
the OpenBMC.

Tested:
lo

Add json-c as unit test build dependency

nbd-proxy.c needs json-c as dependency - CI run fails on that.

Added latest tagged git version (json-c-0.16-2022041) the same as in
the OpenBMC.

Tested:
locally passed run-unit-test-docker.sh on jsnbd repository.

Change-Id: I837247a2c4b9ebee3081cea3adae68364da269f9
Signed-off-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@intel.com>

show more ...

qemu: misc fixes for new qemu release

- Ensure qemu is built in same ubuntu distro as where it is run
- Add new libslirp-dev dep to docker container that executes qemu

Signed-off-by: Andrew Geissle

qemu: misc fixes for new qemu release

- Ensure qemu is built in same ubuntu distro as where it is run
- Add new libslirp-dev dep to docker container that executes qemu

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Iaa58d097de0377e4bb5ee229c5ec267ebe4565a7

show more ...

Upgrade to boost 1.81.0

Per the other commits, we are temporarily moving to boost 1.81.0 to get
ahead of some of the API breaking changes in boost-url. This requires
moving CI off of using the yoct

Upgrade to boost 1.81.0

Per the other commits, we are temporarily moving to boost 1.81.0 to get
ahead of some of the API breaking changes in boost-url. This requires
moving CI off of using the yocto mirror. So far as I'm aware, the boost
bandwidth issues have been long solved, so this should be fine.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Iec89a040374bef52c5188c89be9f8a25a12d6164

show more ...

openbmc-build-scripts: add vim to container

There are times when interactively working within a CI unit test docker
container that having vim available is useful.

Change-Id: I564e1882e325e5b871eda9

openbmc-build-scripts: add vim to container

There are times when interactively working within a CI unit test docker
container that having vim available is useful.

Change-Id: I564e1882e325e5b871eda9c0defaec51d4a7bf0d
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

build-unit-test-docker: sort apt packages

Make it easier to identify if a needed package is being installed

Change-Id: Iba108c6ddddc9ee25bd7341b41e79d7c82f231bb
Signed-off-by: Andrew Geissler <geis

build-unit-test-docker: sort apt packages

Make it easier to identify if a needed package is being installed

Change-Id: Iba108c6ddddc9ee25bd7341b41e79d7c82f231bb
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...