6005f1c8 | 05-Apr-2023 |
Andrew Jeffery <andrew@aj.id.au> |
clang-tidy: Fix readability-identifier-naming diagnostic
For example:
``` /usr/bin/clang-tidy -checks=-*, readability-identifier-naming -export-fixes /tmp/tmpsjbxtnss/tmpbj5pbywt.yaml -p=build /mnt
clang-tidy: Fix readability-identifier-naming diagnostic
For example:
``` /usr/bin/clang-tidy -checks=-*, readability-identifier-naming -export-fixes /tmp/tmpsjbxtnss/tmpbj5pbywt.yaml -p=build /mnt/host/andrew/src/openbmc/libpldm/src/platform.c /mnt/host/andrew/src/openbmc/libpldm/build/../include/libpldm/pdr.h:166:6: error: invalid case style for function 'pldm_pdr_update_TL_pdr' [readability-identifier-naming,-warnings-as-errors] void pldm_pdr_update_TL_pdr(const pldm_pdr *repo, uint16_t terminusHandle, ^~~~~~~~~~~~~~~~~~~~~~ pldm_pdr_update_tl_pdr /mnt/host/andrew/src/openbmc/libpldm/build/../include/libpldm/pdr.h:166:60: error: invalid case style for parameter 'terminusHandle' [readability-identifier-naming,-warnings-as-errors] void pldm_pdr_update_TL_pdr(const pldm_pdr *repo, uint16_t terminusHandle, ^~~~~~~~~~~~~~ terminus_handle /mnt/host/andrew/src/openbmc/libpldm/build/../include/libpldm/pdr.h:167:29: error: invalid case style for parameter 'tlEid' [readability-identifier-naming,-warnings-as-errors] uint8_t tid, uint8_t tlEid, bool valid); ^~~~~ tl_eid ```
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I6419dade685ee656fe773451148f15aefb20becd
show more ...
|
1e0528c2 | 05-Apr-2023 |
Andrew Jeffery <andrew@aj.id.au> |
clang-tidy: Fix readability-else-after-return diagnostics
``` /usr/bin/clang-tidy -checks=-*, readability-else-after-return -export-fixes /tmp/tmp4f2o40d3/tmp18pyt1xg.yaml -p=build /mnt/host/andrew/
clang-tidy: Fix readability-else-after-return diagnostics
``` /usr/bin/clang-tidy -checks=-*, readability-else-after-return -export-fixes /tmp/tmp4f2o40d3/tmp18pyt1xg.yaml -p=build /mnt/host/andrew/src/openbmc/libpldm/src/requester/pldm.c /mnt/host/andrew/src/openbmc/libpldm/build/../src/requester/pldm.c:64:4: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors] } else if (length < min_len) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ```
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I43dd1da00ed3192cccaf1001e2eb6031cee12a27
show more ...
|
b705fb0a | 05-Apr-2023 |
Andrew Jeffery <andrew@aj.id.au> |
clang-tidy: Fix bugprone-narrowing-conversion diagnostic
``` /usr/bin/clang-tidy -checks=-*, bugprone-narrowing-conversions -export-fixes /tmp/tmp9pcdq4bf/tmpulhoe1tp.yaml -p=build /mnt/host/andrew/
clang-tidy: Fix bugprone-narrowing-conversion diagnostic
``` /usr/bin/clang-tidy -checks=-*, bugprone-narrowing-conversions -export-fixes /tmp/tmp9pcdq4bf/tmpulhoe1tp.yaml -p=build /mnt/host/andrew/src/openbmc/libpldm/src/requester/pldm.c ../src/requester/pldm.c:32:7: error: narrowing conversion from 'ssize_t' (aka 'long') to signed type 'int' is implementation-defined [bugprone-narrowing-conversions,-warnings-as-errors] rc = write(fd, &MCTP_MSG_TYPE_PLDM, sizeof(MCTP_MSG_TYPE_PLDM)); ^ ```
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I95e70d4692dd57d87216e75adb9ac26ab4b96bb9
show more ...
|