platform: Stabilise decode_pldm_message_poll_event_data() APIs

See usage example at:
[1] https://gerrit.openbmc.org/c/openbmc/pldm/+/73033/1/platform-mc/event_manager.cpp#126

Change-Id: Ic680a514b2

platform: Stabilise decode_pldm_message_poll_event_data() APIs

See usage example at:
[1] https://gerrit.openbmc.org/c/openbmc/pldm/+/73033/1/platform-mc/event_manager.cpp#126

Change-Id: Ic680a514b224d366cc00fa291f2da45dde77950a
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>

show more ...

platform: Rework decode/encode_pldm_message_poll_event_data() APIs

Adds `struct pldm_message_poll_event` which includes `format_version`,
`event_id` and `data_transfer_handle` in `pldmMessagePollEve

platform: Rework decode/encode_pldm_message_poll_event_data() APIs

Adds `struct pldm_message_poll_event` which includes `format_version`,
`event_id` and `data_transfer_handle` in `pldmMessagePollEvent` data.
Rework decode/encode_pldm_message_poll_event_data() APIs to use `struct
pldm_message_poll_event poll_event` as parameter.

Change-Id: I01c643ed320b17141d89068cb3e00b1a99162d77
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>

show more ...

platform: Stabilise related decode_entity_auxiliary_names_pdr*() APIs

See usage example at:
https://gerrit.openbmc.org/c/openbmc/pldm/+/72610

Change-Id: I16c6d42ad11afa59b04676fa187f5ea0764d1880
Si

platform: Stabilise related decode_entity_auxiliary_names_pdr*() APIs

See usage example at:
https://gerrit.openbmc.org/c/openbmc/pldm/+/72610

Change-Id: I16c6d42ad11afa59b04676fa187f5ea0764d1880
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>

show more ...

fw_update: Add encode req & decode resp for get_downstream_fw_params

Add support for Get Downstream Firmware Parameters to ask all
downstream devices' Firmware Parameters.

The code is developed bas

fw_update: Add encode req & decode resp for get_downstream_fw_params

Add support for Get Downstream Firmware Parameters to ask all
downstream devices' Firmware Parameters.

The code is developed based on the definition of
'GetDownstreamFirmwareParameters' in DSP0267_1.1.0. Section 10.5

Change-Id: I291ca3b623be6119434b70494bb9a12b22f600b9
Signed-off-by: Chris Wang <chris.wang.wiwynn@gmail.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pdr: Add related decode_entity_auxiliary_names_pdr*() APIs

Add `decode_entity_auxiliary_names_pdr()` to decode the entity auxiliary
names PDR raw data to the data fields as table 95 in DSP0248_1.2.2

pdr: Add related decode_entity_auxiliary_names_pdr*() APIs

Add `decode_entity_auxiliary_names_pdr()` to decode the entity auxiliary
names PDR raw data to the data fields as table 95 in DSP0248_1.2.2.
The API will not decode the entity auxiliary names directly - to
expose the language tags and names fields the caller has to
subsequently call `decode_pldm_entity_auxiliary_names_pdr_index()`.
Between the API calls the caller must allocate memory for the
`names` field as an array of `struct pldm_entity_auxiliary_name` with
`name_string_count` elements.

Change-Id: I5fc3989c4c4595546a70c01eb2b6dadcf8c14303
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pdr: Add pldm_pdr_get_terminus_handle() API

Adds a new libpldm API to get the terminus handle of the
particular record given as input from the PDR repo.

Change-Id: I3694cc3974a564296f4584b70de7d6d1

pdr: Add pldm_pdr_get_terminus_handle() API

Adds a new libpldm API to get the terminus handle of the
particular record given as input from the PDR repo.

Change-Id: I3694cc3974a564296f4584b70de7d6d1dad2a866
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

platform: Define macros for the responded transferflags

`Table 16: PollForPlatformEventMessage command format` and `Table 68:
GetPDR command format` in DSP0248 v1.2.2 define the values of the
respon

platform: Define macros for the responded transferflags

`Table 16: PollForPlatformEventMessage command format` and `Table 68:
GetPDR command format` in DSP0248 v1.2.2 define the values of the
responded `transferflag` for PLDM platform and control commands.
Add the definition for further using.

Change-Id: Ibd97918a7a5add10dbb5db7c044c71daa5bbaa4e
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>

show more ...

changelog: Add entry for entity association PDR API

Log entry for new APIs introduced to add a contained entity
into an entity association PDR as a new change.

Change-Id: I2f8510ecaab97ae68de53c54d

changelog: Add entry for entity association PDR API

Log entry for new APIs introduced to add a contained entity
into an entity association PDR as a new change.

Change-Id: I2f8510ecaab97ae68de53c54d295f55c43cef952
Signed-off-by: Varsha Kaverappa <vkaverap@in.ibm.com>

show more ...

requester: instance-id: Release read lock on conflict

36af84cdbb66 ("requester: Add new APIs for instance ID allocation and
freeing") introduced the new instance ID allocation APIs, and some
unbalan

requester: instance-id: Release read lock on conflict

36af84cdbb66 ("requester: Add new APIs for instance ID allocation and
freeing") introduced the new instance ID allocation APIs, and some
unbalanced locking along with it. When a conflict arose on an instance
ID, the read lock was not released by the non-owning caller.

Release the lock on conflict and on error, and add a test case to
prevent regression.

gitlint-ignore: UC1, B1
Fixes: 36af84cdbb66 ("requester: Add new APIs for instance ID allocation and freeing")
Reported-by: Jerry Chen <jerry_c_chen@wiwynn.com>
Change-Id: Iecd1583c6b8863b458cc4fbf1ac42b20ca2a3433
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

include: Drop compat symlinks for IBM OEM headers

These symlinks have been in-place long enough for people to migrate.
Provide a coccinelle semantic patch to help anyone who hasn't.

Change-Id: Iab4

include: Drop compat symlinks for IBM OEM headers

These symlinks have been in-place long enough for people to migrate.
Provide a coccinelle semantic patch to help anyone who hasn't.

Change-Id: Iab456ebba8d87c57eb2d573b7a8bffb394e0bb00
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: fru: Rename get_fru_record_by_option_check()

We drop the `_check` suffix so that it is now
`get_fru_record_by_option()`.

To do so, introduce some infrastructure that makes renaming APIs
easier

dsp: fru: Rename get_fru_record_by_option_check()

We drop the `_check` suffix so that it is now
`get_fru_record_by_option()`.

To do so, introduce some infrastructure that makes renaming APIs
easier and scripts the migration for users. The renaming process comes
in several parts, which are captured in the addition to the changes
checklist.

The coccinelle script based off the insight at [1].

[1]: https://stackoverflow.com/questions/42776220/coccinelle-help-to-replace-a-function-with-variable-args

Change-Id: I730b76c3e3c92dcc046fecbee76cd6b040f11d21
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

base: Define macros for reserved TIDs

Move the definition of `PLDM_TID_RESERVED` from platform.h to base.h as
the value is defined in the base specification (DSP0240). platform.h
already includes ba

base: Define macros for reserved TIDs

Move the definition of `PLDM_TID_RESERVED` from platform.h to base.h as
the value is defined in the base specification (DSP0240). platform.h
already includes base.h so the move is not an API-breaking change.

Further, add the definition for `PLDM_TID_UNASSIGNED`, which is the
other reserved TID value.

Change-Id: I191bee73e091a4b0e83c4bffcee38bff3c88ed96
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>

show more ...

platform: Add support for GetStateEffecterStates command

Based on DSP0248 PLDM for Platform Monitoring
and Control Specification version 1.2.0a Section 22.6

Implement encode and decode for both req

platform: Add support for GetStateEffecterStates command

Based on DSP0248 PLDM for Platform Monitoring
and Control Specification version 1.2.0a Section 22.6

Implement encode and decode for both request and response
for GetStateEffecterStates PLDM command.

Include unit-tests.

Change-Id: Ia3bd71151d40b56f91afe2fe23b8bf2f26915b64
Signed-off-by: Tal Yacobi <talycb8@gmail.com>

show more ...

libpldm: Release v0.8.0

Change-Id: I5950344f0f35609cd178c4505dc662f1ddbc5e78
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

tests: oem: meta: Fix fileio use of msgbuf

After resolving some undefined behavior regarding pointer arithmetic in
pldm_msgbuf_init(), clang-tidy detected the following:

```
clang-tidy-17 -export-f

tests: oem: meta: Fix fileio use of msgbuf

After resolving some undefined behavior regarding pointer arithmetic in
pldm_msgbuf_init(), clang-tidy detected the following:

```
clang-tidy-17 -export-fixes /tmp/tmpmu0oifam/tmpwpj83pgb.yaml -p=/home/andrew/src/openbmc.org/openbmc/libpldm/origin/buildkcgocca3 -quiet /home/andrew/src/openbmc.org/openbmc/libpldm/origin/tests/oem/meta/libpldm_fileio_test.cpp
../src/msgbuf.h:593:14: error: Branch condition evaluates to a garbage value [clang-analyzer-core.uninitialized.Branch,-warnings-as-errors]
593 | if (!ctx || !ctx->cursor) {
| ^
../tests/oem/meta/libpldm_fileio_test.cpp:26:5: note: Calling 'pldm_msgbuf_init'
26 | pldm_msgbuf_init(ctx, 0, &buf[hdrSize], sizeof(buf) - hdrSize);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/msgbuf.h:75:7: note: 'ctx' is non-null
75 | if (!ctx || !buf) {
| ^~~
../src/msgbuf.h:75:6: note: Left side of '||' is false
75 | if (!ctx || !buf) {
| ^
../src/msgbuf.h:75:15: note: 'buf' is non-null
75 | if (!ctx || !buf) {
| ^~~
../src/msgbuf.h:75:2: note: Taking false branch
75 | if (!ctx || !buf) {
| ^
../src/msgbuf.h:79:7: note: 'minsize' is <= 'len'
79 | if ((minsize > len) || (len > SSIZE_MAX)) {
| ^~~~~~~
../src/msgbuf.h:79:6: note: Left side of '||' is false
79 | if ((minsize > len) || (len > SSIZE_MAX)) {
| ^
../src/msgbuf.h:79:26: note: 'len' is <= SSIZE_MAX
79 | if ((minsize > len) || (len > SSIZE_MAX)) {
| ^~~
../src/msgbuf.h:79:2: note: Taking false branch
79 | if ((minsize > len) || (len > SSIZE_MAX)) {
| ^
../src/msgbuf.h:83:6: note: Assuming the condition is true
83 | if ((uintptr_t)buf + len < len) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
../src/msgbuf.h:83:2: note: Taking true branch
83 | if ((uintptr_t)buf + len < len) {
| ^
../src/msgbuf.h:84:3: note: Returning without writing to 'ctx->cursor'
84 | return PLDM_ERROR_INVALID_LENGTH;
| ^
../tests/oem/meta/libpldm_fileio_test.cpp:26:5: note: Returning from 'pldm_msgbuf_init'
26 | pldm_msgbuf_init(ctx, 0, &buf[hdrSize], sizeof(buf) - hdrSize);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../tests/oem/meta/libpldm_fileio_test.cpp:28:5: note: Calling 'pldm_msgbuf_insert_uint8'
28 | pldm_msgbuf_insert_uint8(ctx, fileHandle);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/msgbuf.h:593:7: note: 'ctx' is non-null
593 | if (!ctx || !ctx->cursor) {
| ^~~
../src/msgbuf.h:593:6: note: Left side of '||' is false
593 | if (!ctx || !ctx->cursor) {
| ^
../src/msgbuf.h:593:14: note: Branch condition evaluates to a garbage value
593 | if (!ctx || !ctx->cursor) {
| ^~~~~~~~~~~~
```

Fixes: 22fad3957d36 ("oem: meta: Add decode_oem_meta_file_io_req()")
Change-Id: I99f1d6f8c28a7e812b12f5ef60af5d0f0b0d1866
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

fw_update: Add encode req & decode resp for query_downtream_identifiers

Add support for Query Downstream Identifiers to ask all downstream
devices' Descriptors managed by a endpoint.

The code is de

fw_update: Add encode req & decode resp for query_downtream_identifiers

Add support for Query Downstream Identifiers to ask all downstream
devices' Descriptors managed by a endpoint.

The code is developed based on the definition of
'QueryDownstreamIdentifiers' in DSP0267_1.1.0 Section 10.4

Change-Id: I6282a894c73b78470c147e77d81e5a4ddd6a39a8
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>

show more ...

fw_update: Add encode req & decode resp for query_downstream_devices

Add support for Query Downstream Devices to ask if a endpoint supports
downstream devices.

The code is developed based on the de

fw_update: Add encode req & decode resp for query_downstream_devices

Add support for Query Downstream Devices to ask if a endpoint supports
downstream devices.

The code is developed based on the definition of
'QueryDownstreamDevices' in DSP0267_1.1.0. Section 10.3

Change-Id: I5925290de5023eb48f675e736429fe9f257170c8
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>

show more ...

oem: ibm: Support for the Real SAI entity id

This commit adds the Real SAI (System Attention Indicator) oem
entity id.

Real SAI is a physical led indicator which lights up whenever
there is a platf

oem: ibm: Support for the Real SAI entity id

This commit adds the Real SAI (System Attention Indicator) oem
entity id.

Real SAI is a physical led indicator which lights up whenever
there is a platform error (originated from BMC) or a partition
error that is not mapped to any physical FRU (Field Replaceable Unit).

The pldm commit that uses this value is
https://gerrit.openbmc.org/c/openbmc/pldm/+/48906

Change-Id: I3e070303c1a8aed236be05fbf79a402f6b1322f8
Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>

show more ...

pdr: Add decode_numeric_effecter_pdr_data()

Add `decode_numeric_effecter_pdr_data` API to decode the numeric
effecter PDR data in DSP0248_1.2.2 table 87. The API will be used to
retrieve the data fi

pdr: Add decode_numeric_effecter_pdr_data()

Add `decode_numeric_effecter_pdr_data` API to decode the numeric
effecter PDR data in DSP0248_1.2.2 table 87. The API will be used to
retrieve the data fields of numeric effecter from the PDRs in `pldmd`.

Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: I323a1288cb0262bd39f4f28701ddc7dbb70c33c8

show more ...

libpldm: add enum used by some Network Controller

The network interface connectors and ports connection entity types
(along with Link State set and Redfish Device Resource PDR) are useful
for some N

libpldm: add enum used by some Network Controller

The network interface connectors and ports connection entity types
(along with Link State set and Redfish Device Resource PDR) are useful
for some NIC devices.

Change-Id: I28cd2c9db4ef3bfc9885892b41312d31a709ebbf
Signed-off-by: Jinliang Wang <jinliangw@google.com>

show more ...

changelog: Fix whitespace in `Changelog` header

0ee776642275 ("platform: Add alias members to PDRRepoChgEvent") added
some entries to the changelog, but managed to ding the top level header
whitespa

changelog: Fix whitespace in `Changelog` header

0ee776642275 ("platform: Add alias members to PDRRepoChgEvent") added
some entries to the changelog, but managed to ding the top level header
whitespace in the process. Undo that.

Fixes: 0ee776642275 ("platform: Add alias members to PDRRepoChgEvent")
Change-Id: Ie2e769e0d97d0ed2601933740ded5f145cf40542
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

oem: ibm: Add Firmware UAK as a FRU field type

The oem-ibm FRU field type enumeration is added with a new enum value
for Firmware Update Access Key (UAK) value. The PLDM commit that uses
this enum v

oem: ibm: Add Firmware UAK as a FRU field type

The oem-ibm FRU field type enumeration is added with a new enum value
for Firmware Update Access Key (UAK) value. The PLDM commit that uses
this enum value is [oem-ibm: Access key update support][1]

[1]: https://gerrit.openbmc.org/c/openbmc/pldm/+/49054

Change-Id: I50f12be1dd1a92ad11431e5b2b9573e54b50d1e1
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

oem-ibm: Alias pldm_oem_ibm_fru_field_type members as PLDM_OEM_IBM_*

The oem-ibm FRU field type enumeration did not have a IBM prefix in
their enum values. This change is done to give more consisten

oem-ibm: Alias pldm_oem_ibm_fru_field_type members as PLDM_OEM_IBM_*

The oem-ibm FRU field type enumeration did not have a IBM prefix in
their enum values. This change is done to give more consistent names to
the enum constants.

The older version of these duplicate constants will be removed once a
tag containing the new members has been created.

Change-Id: Ibba743c24dc6f41b767e88e27b843a49f8731f5d
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

platform: Add alias members to PDRRepoChgEvent

Alias constants are added in pldmPDRRepositoryChgEvent
changeRecord event data operation enum. This is done
to give more consistent names to the enum c

platform: Add alias members to PDRRepoChgEvent

Alias constants are added in pldmPDRRepositoryChgEvent
changeRecord event data operation enum. This is done
to give more consistent names to the enum constants.
The older version of these duplicate constants will be
removed after backward compatibility is taken care.

See CHANGELOG.md for more information on this enum.

Change-Id: Ie30f9034d4ca12abd5d2a4b3e584e0f63f55e56b
Signed-off-by: Varsha Kaverappa <vkaverap@in.ibm.com>

show more ...

state-set: Add all system power states (set ID 260)

System power state defines power states of a system
or an entity in the system.

Change-Id: If9b08b6e954fc3d73e98df7307aa7b397f04707c
Signed-off-b

state-set: Add all system power states (set ID 260)

System power state defines power states of a system
or an entity in the system.

Change-Id: If9b08b6e954fc3d73e98df7307aa7b397f04707c
Signed-off-by: Varsha Kaverappa <vkaverap@in.ibm.com>

show more ...