/openbmc/phosphor-logging/test/openpower-pels/ |
H A D | service_indicators_test.cpp | bad056be Wed Jan 25 14:16:57 CST 2023 Matt Spinler <spinler@us.ibm.com> PEL: Handle multiple inv paths per loc code
DataInterface::getInventoryFromLocCode() was only returning a single inventory path from GetFRUsByExpandedLocationCode() even though multiple paths may have been returned.
Mostly that was fine, except when a processor on a DCM was called out. That would lead to only one processor on the DCM being set to not functional by service_indicators.cpp, so on the web UI the actual CPU called out may not have been marked as unhealthy (health status critical in Redfish).
This commit changes getInventoryFromLocCode() to return all the paths that GetFRUsByExpandedLocationCode() returns, and then makes the corresponding changes in service_indicators.cpp to be able to handle multiple inventory paths per location code when setting them to not functional and creating a critical association.
The other code that was calling this function can just use the first path returned, since in those cases it's just needed to get the VPD information for the PEL, and all the paths would return the same info anyway since they had the same location code.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Ia16f50881e4a4f84c171ae20b7a99eddcc98ad4f
|
H A D | src_test.cpp | bad056be Wed Jan 25 14:16:57 CST 2023 Matt Spinler <spinler@us.ibm.com> PEL: Handle multiple inv paths per loc code
DataInterface::getInventoryFromLocCode() was only returning a single inventory path from GetFRUsByExpandedLocationCode() even though multiple paths may have been returned.
Mostly that was fine, except when a processor on a DCM was called out. That would lead to only one processor on the DCM being set to not functional by service_indicators.cpp, so on the web UI the actual CPU called out may not have been marked as unhealthy (health status critical in Redfish).
This commit changes getInventoryFromLocCode() to return all the paths that GetFRUsByExpandedLocationCode() returns, and then makes the corresponding changes in service_indicators.cpp to be able to handle multiple inventory paths per location code when setting them to not functional and creating a critical association.
The other code that was calling this function can just use the first path returned, since in those cases it's just needed to get the VPD information for the PEL, and all the paths would return the same info anyway since they had the same location code.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Ia16f50881e4a4f84c171ae20b7a99eddcc98ad4f
|
H A D | pel_test.cpp | bad056be Wed Jan 25 14:16:57 CST 2023 Matt Spinler <spinler@us.ibm.com> PEL: Handle multiple inv paths per loc code
DataInterface::getInventoryFromLocCode() was only returning a single inventory path from GetFRUsByExpandedLocationCode() even though multiple paths may have been returned.
Mostly that was fine, except when a processor on a DCM was called out. That would lead to only one processor on the DCM being set to not functional by service_indicators.cpp, so on the web UI the actual CPU called out may not have been marked as unhealthy (health status critical in Redfish).
This commit changes getInventoryFromLocCode() to return all the paths that GetFRUsByExpandedLocationCode() returns, and then makes the corresponding changes in service_indicators.cpp to be able to handle multiple inventory paths per location code when setting them to not functional and creating a critical association.
The other code that was calling this function can just use the first path returned, since in those cases it's just needed to get the VPD information for the PEL, and all the paths would return the same info anyway since they had the same location code.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Ia16f50881e4a4f84c171ae20b7a99eddcc98ad4f
|
H A D | mocks.hpp | bad056be Wed Jan 25 14:16:57 CST 2023 Matt Spinler <spinler@us.ibm.com> PEL: Handle multiple inv paths per loc code
DataInterface::getInventoryFromLocCode() was only returning a single inventory path from GetFRUsByExpandedLocationCode() even though multiple paths may have been returned.
Mostly that was fine, except when a processor on a DCM was called out. That would lead to only one processor on the DCM being set to not functional by service_indicators.cpp, so on the web UI the actual CPU called out may not have been marked as unhealthy (health status critical in Redfish).
This commit changes getInventoryFromLocCode() to return all the paths that GetFRUsByExpandedLocationCode() returns, and then makes the corresponding changes in service_indicators.cpp to be able to handle multiple inventory paths per location code when setting them to not functional and creating a critical association.
The other code that was calling this function can just use the first path returned, since in those cases it's just needed to get the VPD information for the PEL, and all the paths would return the same info anyway since they had the same location code.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Ia16f50881e4a4f84c171ae20b7a99eddcc98ad4f
|
H A D | pel_manager_test.cpp | bad056be Wed Jan 25 14:16:57 CST 2023 Matt Spinler <spinler@us.ibm.com> PEL: Handle multiple inv paths per loc code
DataInterface::getInventoryFromLocCode() was only returning a single inventory path from GetFRUsByExpandedLocationCode() even though multiple paths may have been returned.
Mostly that was fine, except when a processor on a DCM was called out. That would lead to only one processor on the DCM being set to not functional by service_indicators.cpp, so on the web UI the actual CPU called out may not have been marked as unhealthy (health status critical in Redfish).
This commit changes getInventoryFromLocCode() to return all the paths that GetFRUsByExpandedLocationCode() returns, and then makes the corresponding changes in service_indicators.cpp to be able to handle multiple inventory paths per location code when setting them to not functional and creating a critical association.
The other code that was calling this function can just use the first path returned, since in those cases it's just needed to get the VPD information for the PEL, and all the paths would return the same info anyway since they had the same location code.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Ia16f50881e4a4f84c171ae20b7a99eddcc98ad4f
|
/openbmc/phosphor-logging/extensions/openpower-pels/ |
H A D | service_indicators.cpp | bad056be Wed Jan 25 14:16:57 CST 2023 Matt Spinler <spinler@us.ibm.com> PEL: Handle multiple inv paths per loc code
DataInterface::getInventoryFromLocCode() was only returning a single inventory path from GetFRUsByExpandedLocationCode() even though multiple paths may have been returned.
Mostly that was fine, except when a processor on a DCM was called out. That would lead to only one processor on the DCM being set to not functional by service_indicators.cpp, so on the web UI the actual CPU called out may not have been marked as unhealthy (health status critical in Redfish).
This commit changes getInventoryFromLocCode() to return all the paths that GetFRUsByExpandedLocationCode() returns, and then makes the corresponding changes in service_indicators.cpp to be able to handle multiple inventory paths per location code when setting them to not functional and creating a critical association.
The other code that was calling this function can just use the first path returned, since in those cases it's just needed to get the VPD information for the PEL, and all the paths would return the same info anyway since they had the same location code.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Ia16f50881e4a4f84c171ae20b7a99eddcc98ad4f
|
H A D | data_interface.hpp | bad056be Wed Jan 25 14:16:57 CST 2023 Matt Spinler <spinler@us.ibm.com> PEL: Handle multiple inv paths per loc code
DataInterface::getInventoryFromLocCode() was only returning a single inventory path from GetFRUsByExpandedLocationCode() even though multiple paths may have been returned.
Mostly that was fine, except when a processor on a DCM was called out. That would lead to only one processor on the DCM being set to not functional by service_indicators.cpp, so on the web UI the actual CPU called out may not have been marked as unhealthy (health status critical in Redfish).
This commit changes getInventoryFromLocCode() to return all the paths that GetFRUsByExpandedLocationCode() returns, and then makes the corresponding changes in service_indicators.cpp to be able to handle multiple inventory paths per location code when setting them to not functional and creating a critical association.
The other code that was calling this function can just use the first path returned, since in those cases it's just needed to get the VPD information for the PEL, and all the paths would return the same info anyway since they had the same location code.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Ia16f50881e4a4f84c171ae20b7a99eddcc98ad4f
|
H A D | src.cpp | bad056be Wed Jan 25 14:16:57 CST 2023 Matt Spinler <spinler@us.ibm.com> PEL: Handle multiple inv paths per loc code
DataInterface::getInventoryFromLocCode() was only returning a single inventory path from GetFRUsByExpandedLocationCode() even though multiple paths may have been returned.
Mostly that was fine, except when a processor on a DCM was called out. That would lead to only one processor on the DCM being set to not functional by service_indicators.cpp, so on the web UI the actual CPU called out may not have been marked as unhealthy (health status critical in Redfish).
This commit changes getInventoryFromLocCode() to return all the paths that GetFRUsByExpandedLocationCode() returns, and then makes the corresponding changes in service_indicators.cpp to be able to handle multiple inventory paths per location code when setting them to not functional and creating a critical association.
The other code that was calling this function can just use the first path returned, since in those cases it's just needed to get the VPD information for the PEL, and all the paths would return the same info anyway since they had the same location code.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Ia16f50881e4a4f84c171ae20b7a99eddcc98ad4f
|
H A D | data_interface.cpp | bad056be Wed Jan 25 14:16:57 CST 2023 Matt Spinler <spinler@us.ibm.com> PEL: Handle multiple inv paths per loc code
DataInterface::getInventoryFromLocCode() was only returning a single inventory path from GetFRUsByExpandedLocationCode() even though multiple paths may have been returned.
Mostly that was fine, except when a processor on a DCM was called out. That would lead to only one processor on the DCM being set to not functional by service_indicators.cpp, so on the web UI the actual CPU called out may not have been marked as unhealthy (health status critical in Redfish).
This commit changes getInventoryFromLocCode() to return all the paths that GetFRUsByExpandedLocationCode() returns, and then makes the corresponding changes in service_indicators.cpp to be able to handle multiple inventory paths per location code when setting them to not functional and creating a critical association.
The other code that was calling this function can just use the first path returned, since in those cases it's just needed to get the VPD information for the PEL, and all the paths would return the same info anyway since they had the same location code.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Ia16f50881e4a4f84c171ae20b7a99eddcc98ad4f
|