Searched hist:b20dae70 (Results 1 – 1 of 1) sorted by relevance
/openbmc/linux/net/sunrpc/xprtrdma/ |
H A D | svc_rdma_sendto.c | b20dae70 Thu Jul 13 12:51:15 CDT 2017 Colin Ian King <colin.king@canonical.com> svcrdma: fix an incorrect check on -E2BIG and -EINVAL
The current check will always be true and will always jump to err1, this looks dubious to me. I believe && should be used instead of ||.
Detected by CoverityScan, CID#1450120 ("Logically Dead Code")
Fixes: 107c1d0a991a ("svcrdma: Avoid Send Queue overflow") Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com> b20dae70 Thu Jul 13 12:51:15 CDT 2017 Colin Ian King <colin.king@canonical.com> svcrdma: fix an incorrect check on -E2BIG and -EINVAL The current check will always be true and will always jump to err1, this looks dubious to me. I believe && should be used instead of ||. Detected by CoverityScan, CID#1450120 ("Logically Dead Code") Fixes: 107c1d0a991a ("svcrdma: Avoid Send Queue overflow") Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
|