Searched hist:"86347 bec" (Results 1 – 2 of 2) sorted by relevance
| /openbmc/openbmc/meta-fii/meta-mori/recipes-mori/mori-fw-utility/ |
| H A D | mori-fw.bb | 86347bec Mon Oct 16 13:44:14 CDT 2023 Kyle Nieman <kyle.nieman@fii-na.com> meta-fii: meta-mori: Launch apps by correct path to avoid anti-pattern
As specified by OpenBMC anti-pattern document, calls to a binary/script
should be the fully qualified path to the application being launched.
https://github.com/openbmc/docs/blob/717d273cf8bceac3868a278aeb34d19e8d74c1b3/anti-patterns.md#resolution-4
This follows the systemd recommendation to use the full
path to avoid ambiguity.
https://www.freedesktop.org/software/systemd/man/systemd.service.html#:~:text=Using%20an%20absolute%20path%20is%20recommended%20to%20avoid%20ambiguity
In addition, OpenBMC applications that are intended to be used by users
should be located in /usr/bin.
Changes:
Place user scripts in /usr/bin instead of /usr/sbin. Start scripts by
their absolute path in service files.
Testing:
The services that are modified can find and start their scripts. The
scripts that had their locations modified can be called by the user
without providing their full path.
Change-Id: Ibe7fbb1644aa1b0df0f296ea1f1a8ceaf444fe35
Signed-off-by: Kyle Nieman <kyle.nieman@fii-na.com>
|
| /openbmc/openbmc/meta-fii/meta-mori/recipes-mori/mori-sys-utility/ |
| H A D | mori-cmd.bb | 86347bec Mon Oct 16 13:44:14 CDT 2023 Kyle Nieman <kyle.nieman@fii-na.com> meta-fii: meta-mori: Launch apps by correct path to avoid anti-pattern
As specified by OpenBMC anti-pattern document, calls to a binary/script
should be the fully qualified path to the application being launched.
https://github.com/openbmc/docs/blob/717d273cf8bceac3868a278aeb34d19e8d74c1b3/anti-patterns.md#resolution-4
This follows the systemd recommendation to use the full
path to avoid ambiguity.
https://www.freedesktop.org/software/systemd/man/systemd.service.html#:~:text=Using%20an%20absolute%20path%20is%20recommended%20to%20avoid%20ambiguity
In addition, OpenBMC applications that are intended to be used by users
should be located in /usr/bin.
Changes:
Place user scripts in /usr/bin instead of /usr/sbin. Start scripts by
their absolute path in service files.
Testing:
The services that are modified can find and start their scripts. The
scripts that had their locations modified can be called by the user
without providing their full path.
Change-Id: Ibe7fbb1644aa1b0df0f296ea1f1a8ceaf444fe35
Signed-off-by: Kyle Nieman <kyle.nieman@fii-na.com>
|