Searched hist:"616 f9228" (Results 1 – 3 of 3) sorted by relevance
| /openbmc/bios-settings-mgr/include/ |
| H A D | password.hpp | 616f9228 Wed Dec 29 00:25:39 CST 2021 George Liu <liuxiwei@inspur.com> Fix some warnings by cppcheck
Warning message:
/src/manager.cpp:255:53: warning: Division by zero [core.DivideZero]
if (((std::abs(attrValue - lowerBound)) % scalarIncrement) != 0)
include/password.hpp:84:36: performance: Function parameter 'rawData'
should be passed by const reference. [passedByValue]
const std::string rawData, const std::string algo);
^
include/password.hpp:84:63: performance: Function parameter 'algo'
should be passed by const reference. [passedByValue]
const std::string rawData, const std::string algo);
Tested: Verify that there are no such warnings in local CI.
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I12276f64b06e4eddfd8cd340ebc16d04e4e9ccd5
|
| /openbmc/bios-settings-mgr/src/ |
| H A D | password.cpp | 616f9228 Wed Dec 29 00:25:39 CST 2021 George Liu <liuxiwei@inspur.com> Fix some warnings by cppcheck
Warning message:
/src/manager.cpp:255:53: warning: Division by zero [core.DivideZero]
if (((std::abs(attrValue - lowerBound)) % scalarIncrement) != 0)
include/password.hpp:84:36: performance: Function parameter 'rawData'
should be passed by const reference. [passedByValue]
const std::string rawData, const std::string algo);
^
include/password.hpp:84:63: performance: Function parameter 'algo'
should be passed by const reference. [passedByValue]
const std::string rawData, const std::string algo);
Tested: Verify that there are no such warnings in local CI.
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I12276f64b06e4eddfd8cd340ebc16d04e4e9ccd5
|
| H A D | manager.cpp | 616f9228 Wed Dec 29 00:25:39 CST 2021 George Liu <liuxiwei@inspur.com> Fix some warnings by cppcheck
Warning message:
/src/manager.cpp:255:53: warning: Division by zero [core.DivideZero]
if (((std::abs(attrValue - lowerBound)) % scalarIncrement) != 0)
include/password.hpp:84:36: performance: Function parameter 'rawData'
should be passed by const reference. [passedByValue]
const std::string rawData, const std::string algo);
^
include/password.hpp:84:63: performance: Function parameter 'algo'
should be passed by const reference. [passedByValue]
const std::string rawData, const std::string algo);
Tested: Verify that there are no such warnings in local CI.
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I12276f64b06e4eddfd8cd340ebc16d04e4e9ccd5
|