Searched hist:"3 d9c2563" (Results 1 – 1 of 1) sorted by relevance
/openbmc/linux/drivers/pinctrl/vt8500/ |
H A D | pinctrl-wmt.c | 3d9c2563 Tue Jul 11 13:28:42 CDT 2017 Gustavo A. R. Silva <garsilva@embeddedor.com> pinctrl: vt8500: wmt: constify gpio_chip structure
This structure is only used to copy into other structure, so declare it as const.
This issue was detected using Coccinelle and the following semantic patch:
@r disable optional_qualifier@ identifier i; position p; @@ static struct gpio_chip i@p = { ... };
@ok@ identifier r.i; expression e; position p; @@ e = i@p;
@bad@ position p != {r.p,ok.p}; identifier r.i; struct gpio_chip e; @@ e@i@p
@depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct gpio_chip i = { ... };
In the following log you can see a significant difference in the code size and data segment, hence in the dec segment. This log is the output of the size command, before and after the code change:
before: text data bss dec hex filename 7754 2328 0 10082 2762 drivers/pinctrl/vt8500/pinctrl-wmt.o
after: text data bss dec hex filename 7472 2272 0 9744 2610 drivers/pinctrl/vt8500/pinctrl-wmt.o
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> 3d9c2563 Tue Jul 11 13:28:42 CDT 2017 Gustavo A. R. Silva <garsilva@embeddedor.com> pinctrl: vt8500: wmt: constify gpio_chip structure This structure is only used to copy into other structure, so declare it as const. This issue was detected using Coccinelle and the following semantic patch: @r disable optional_qualifier@ identifier i; position p; @@ static struct gpio_chip i@p = { ... }; @ok@ identifier r.i; expression e; position p; @@ e = i@p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct gpio_chip e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct gpio_chip i = { ... }; In the following log you can see a significant difference in the code size and data segment, hence in the dec segment. This log is the output of the size command, before and after the code change: before: text data bss dec hex filename 7754 2328 0 10082 2762 drivers/pinctrl/vt8500/pinctrl-wmt.o after: text data bss dec hex filename 7472 2272 0 9744 2610 drivers/pinctrl/vt8500/pinctrl-wmt.o Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
|