Searched hist:"1 aa3b3e0" (Results 1 – 1 of 1) sorted by relevance
/openbmc/linux/fs/quota/ |
H A D | dquot.c | 1aa3b3e0 Mon Apr 09 09:31:19 CDT 2018 Jia-Ju Bai <baijiaju1990@gmail.com> fs: quota: Replace GFP_ATOMIC with GFP_KERNEL in dquot_init
dquot_init() is never called in atomic context. This function is only set as a parameter of fs_initcall().
Despite never getting called from atomic context, dquot_init() calls __get_free_pages() with GFP_ATOMIC, which waits busily for allocation. GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, to avoid busy waiting and improve the possibility of sucessful allocation.
This is found by a static analysis tool named DCNS written by myself. And I also manually check it.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> Signed-off-by: Jan Kara <jack@suse.cz>
|