xref: /openbmc/docs/maintainer-workflow.md (revision f4febd00)
1# OpenBMC Maintainer/CLA Workflow
2
3OpenBMC contributors are required to execute an OpenBMC CLA (Contributor License
4Agreement) before their contributions can be accepted. This page is a checklist
5for sub-project maintainers to follow before approving patches.
6
7- Manually verify the contributor has signed the ICLA (individual) or is listed
8  on an existing CCLA (corporate).
9  - Executed CLAs can be found [in the CLA repository][1].
10  - If you were not added to the appropriate CLA repository ACL send an email to
11    openbmc@lists.ozlabs.org with a request to be added.
12  - If a CLA for the contributor is found, accept the patch(1).
13- If a CLA is not found, request that the contributor execute one and send it to
14  manager@lfprojects.org.
15  - Do not accept the patch(1) until a signed CLA (individual _or_ corporate)
16    has been uploaded to the CLA repository.
17  - The CCLA form can be found [here][2].
18  - The ICLA form can be found [here][3].
19
20An executed OpenBMC CLA is _not_ required to accept contributions to OpenBMC
21forks of upstream projects, like the Linux kernel or U-Boot.
22
23Review the maintainers' responsibilities in the
24[contributing guidelines](./CONTRIBUTING.md). Maintainers are ultimately
25responsible for sorting out open source license issues, issues with using code
26copied from the web, and maintaining the quality of the code.
27
28Repository maintainers ought to have the following traits as recognized by a
29consensus of their peers:
30
31- responsible: have a continuing desire to ensure only high-quality code goes
32  into the repo
33- leadership: foster open-source aware practices such as [FOSS][4]
34- expertise: typically demonstrated by significant contributions to the code or
35  code reviews
36
37(1) The semantics of accepting a patch depend on the sub-project contribution
38process.
39
40- GitHub pull requests - Merging the pull request.
41- Gerrit - +2.
42- email - Merging the patch.
43
44Ensure that accepted changes actually merge into OpenBMC repositories.
45
46[1]: https://drive.google.com/drive/folders/1Ooi0RdTcaOWF1DWFJUAJDdN7tRKde7Nl
47[2]: https://drive.google.com/file/d/1d-2M8ng_Dl2j1odsvZ8o1QHAdHB-pNSH
48[3]: https://drive.google.com/file/d/1k3fc7JPgzKdItEfyIoLxMCVbPUhTwooY
49[4]: https://en.wikipedia.org/wiki/Free_and_open-source_software
50