Searched hist:ff198cdb (Results 1 – 1 of 1) sorted by relevance
| /openbmc/linux/drivers/net/phy/ |
| H A D | phy_led_triggers.c | ff198cdb Wed Nov 01 18:48:45 CDT 2017 Maciej S. Szmigiero <mail@maciej.szmigiero.name> net: phy: leds: Refactor "no link" handler into a separate function
Currently, phy_led_trigger_change_speed() is handling a "no link" condition
like it was some kind of an error (using "goto" to a code at the function
end).
However, having no link at PHY is an ordinary operational state, so let's
handle it in an appropriately named separate function so it is more obvious
what the code is doing.
Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Signed-off-by: David S. Miller <davem@davemloft.net>
ff198cdb Wed Nov 01 18:48:45 CDT 2017 Maciej S. Szmigiero <mail@maciej.szmigiero.name> net: phy: leds: Refactor "no link" handler into a separate function
Currently, phy_led_trigger_change_speed() is handling a "no link" condition
like it was some kind of an error (using "goto" to a code at the function
end).
However, having no link at PHY is an ordinary operational state, so let's
handle it in an appropriately named separate function so it is more obvious
what the code is doing.
Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Signed-off-by: David S. Miller <davem@davemloft.net>
|