Home
last modified time | relevance | path

Searched hist:fcf92585 (Results 1 – 1 of 1) sorted by relevance

/openbmc/linux/tools/perf/
H A DMakefilefcf92585 Thu Oct 10 01:05:25 CDT 2013 Ingo Molnar <mingo@kernel.org> tools/perf/build: Pass through DEBUG parameter

Arnaldo reported that 'make DEBUG=1' does not work anymore.

The reason is that 'Makefile' only passes it through to
'Makefile.perf' via the environment, but 'Makefile.perf'
checks that it's a command line option:

ifeq ("$(origin DEBUG)", "command line")
PERF_DEBUG = $(DEBUG)
endif

So pass it through properly, and also clean up DEBUG parameter
handling while at it and fix a couple of annoyances:

- DEBUG=0 used to be interpreted as 'debugging on'. Turn it
into 'debugging off' instead.

- Same was the case for 'DEBUG=' - turn that into debug-off
as well.

- Pass in just a clean, sanitized 'DEBUG' value and get rid of
the intermediate, unnecessary PERF_DEBUG variable.

Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
fcf92585 Thu Oct 10 01:05:25 CDT 2013 Ingo Molnar <mingo@kernel.org> tools/perf/build: Pass through DEBUG parameter

Arnaldo reported that 'make DEBUG=1' does not work anymore.

The reason is that 'Makefile' only passes it through to
'Makefile.perf' via the environment, but 'Makefile.perf'
checks that it's a command line option:

ifeq ("$(origin DEBUG)", "command line")
PERF_DEBUG = $(DEBUG)
endif

So pass it through properly, and also clean up DEBUG parameter
handling while at it and fix a couple of annoyances:

- DEBUG=0 used to be interpreted as 'debugging on'. Turn it
into 'debugging off' instead.

- Same was the case for 'DEBUG=' - turn that into debug-off
as well.

- Pass in just a clean, sanitized 'DEBUG' value and get rid of
the intermediate, unnecessary PERF_DEBUG variable.

Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>