Searched hist:d9f466b3b92f242343dcdecae83b40579f92c506 (Results 1 – 5 of 5) sorted by relevance
| /openbmc/bmcweb/ |
| H A D | .clang-tidy | d9f466b3b92f242343dcdecae83b40579f92c506 Mon Mar 06 17:04:25 CST 2023 Ed Tanous <edtanous@google.com> Take url views by value
Any of our things taking URLs should be taking url_view by value,
similar to how we take string_view.
From the beast documentation:
"...it acts like a string_view in terms of ownership." [1]
Therefore, we should treat it like we treat string_view, and take by value, not reference.
[1] https://www.boost.org/doc/libs/master/libs/url/doc/html/url/ref/boost__urls__url_view.html
Tested:
Stacked these patches. Redfish service validator passes.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I696b495f4aa04984225853f653cc175c0eaad79d
|
| /openbmc/bmcweb/redfish-core/include/ |
| H A D | error_messages.hpp | d9f466b3b92f242343dcdecae83b40579f92c506 Mon Mar 06 17:04:25 CST 2023 Ed Tanous <edtanous@google.com> Take url views by value
Any of our things taking URLs should be taking url_view by value,
similar to how we take string_view.
From the beast documentation:
"...it acts like a string_view in terms of ownership." [1]
Therefore, we should treat it like we treat string_view, and take by value, not reference.
[1] https://www.boost.org/doc/libs/master/libs/url/doc/html/url/ref/boost__urls__url_view.html
Tested:
Stacked these patches. Redfish service validator passes.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I696b495f4aa04984225853f653cc175c0eaad79d
|
| /openbmc/bmcweb/http/ |
| H A D | utility.hpp | d9f466b3b92f242343dcdecae83b40579f92c506 Mon Mar 06 17:04:25 CST 2023 Ed Tanous <edtanous@google.com> Take url views by value
Any of our things taking URLs should be taking url_view by value,
similar to how we take string_view.
From the beast documentation:
"...it acts like a string_view in terms of ownership." [1]
Therefore, we should treat it like we treat string_view, and take by value, not reference.
[1] https://www.boost.org/doc/libs/master/libs/url/doc/html/url/ref/boost__urls__url_view.html
Tested:
Stacked these patches. Redfish service validator passes.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I696b495f4aa04984225853f653cc175c0eaad79d
|
| /openbmc/bmcweb/redfish-core/src/ |
| H A D | error_messages.cpp | d9f466b3b92f242343dcdecae83b40579f92c506 Mon Mar 06 17:04:25 CST 2023 Ed Tanous <edtanous@google.com> Take url views by value
Any of our things taking URLs should be taking url_view by value,
similar to how we take string_view.
From the beast documentation:
"...it acts like a string_view in terms of ownership." [1]
Therefore, we should treat it like we treat string_view, and take by value, not reference.
[1] https://www.boost.org/doc/libs/master/libs/url/doc/html/url/ref/boost__urls__url_view.html
Tested:
Stacked these patches. Redfish service validator passes.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I696b495f4aa04984225853f653cc175c0eaad79d
|
| /openbmc/bmcweb/redfish-core/lib/ |
| H A D | virtual_media.hpp | d9f466b3b92f242343dcdecae83b40579f92c506 Mon Mar 06 17:04:25 CST 2023 Ed Tanous <edtanous@google.com> Take url views by value
Any of our things taking URLs should be taking url_view by value,
similar to how we take string_view.
From the beast documentation:
"...it acts like a string_view in terms of ownership." [1]
Therefore, we should treat it like we treat string_view, and take by value, not reference.
[1] https://www.boost.org/doc/libs/master/libs/url/doc/html/url/ref/boost__urls__url_view.html
Tested:
Stacked these patches. Redfish service validator passes.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I696b495f4aa04984225853f653cc175c0eaad79d
|