Searched hist:d662fc82 (Results 1 – 1 of 1) sorted by relevance
/openbmc/linux/drivers/regulator/ |
H A D | lp3971.c | d662fc82 Sat Nov 21 15:18:44 CST 2009 Julia Lawall <julia@diku.dk> drivers/regulator: use PTR_ERR to get error code
IS_ERR returns only 1 or 0. The callsite of setup_regulators expects a negative integer in an error case. Thus, PTR_ERR has to be used to extract it.
The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression E,E1; @@
*E = IS_ERR(...) ... when != E = E1 *return E; // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: <broonie@opensource.wolfsonmicro.com> Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk> d662fc82 Sat Nov 21 15:18:44 CST 2009 Julia Lawall <julia@diku.dk> drivers/regulator: use PTR_ERR to get error code IS_ERR returns only 1 or 0. The callsite of setup_regulators expects a negative integer in an error case. Thus, PTR_ERR has to be used to extract it. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression E,E1; @@ *E = IS_ERR(...) ... when != E = E1 *return E; // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: <broonie@opensource.wolfsonmicro.com> Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
|