Home
last modified time | relevance | path

Searched hist:c2b32e58 (Results 1 – 1 of 1) sorted by relevance

/openbmc/linux/drivers/net/ethernet/ti/
H A Dcpsw.cc2b32e58 Thu Sep 04 02:00:23 CDT 2014 Daniel Mack <zonque@gmail.com> net: ethernet: cpsw: improve interrupt lookup logic in cpsw_probe()

Simplify the interrupt resource lookup code in cpsw_probe() by the
following:

* Only look at the first member of the resource. As the driver only
works for DT-enabled platforms anyway, a resource of type
IORESOURCE_IRQ will only contain one single entry
(res->start == res->end), so there is no need for the iteration.

* Add a bounds check to avoid overflows if we are passed more than
ARRAY_SIZE(priv->irqs_table) resources.

* Assign 'ret' with the return value of devm_request_irq() so that
cpsw_probe() returns the appropriate error code.

* If devm_request_irq() fails, report the error code in the log
message.

Signed-off-by: Daniel Mack <zonque@gmail.com>
Acked-by: Mugunthan V N <mugunthanvnm@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
c2b32e58 Thu Sep 04 02:00:23 CDT 2014 Daniel Mack <zonque@gmail.com> net: ethernet: cpsw: improve interrupt lookup logic in cpsw_probe()

Simplify the interrupt resource lookup code in cpsw_probe() by the
following:

* Only look at the first member of the resource. As the driver only
works for DT-enabled platforms anyway, a resource of type
IORESOURCE_IRQ will only contain one single entry
(res->start == res->end), so there is no need for the iteration.

* Add a bounds check to avoid overflows if we are passed more than
ARRAY_SIZE(priv->irqs_table) resources.

* Assign 'ret' with the return value of devm_request_irq() so that
cpsw_probe() returns the appropriate error code.

* If devm_request_irq() fails, report the error code in the log
message.

Signed-off-by: Daniel Mack <zonque@gmail.com>
Acked-by: Mugunthan V N <mugunthanvnm@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>