Home
last modified time | relevance | path

Searched hist:aa59637ea1c6a4c83430933f9c44c43e6c3f1b69 (Results 1 – 2 of 2) sorted by relevance

/openbmc/qemu/qga/
H A Dcommands-win32.c51bd45816615bdb22a31a86f02d601ce536034e3 Wed Apr 22 08:07:19 CDT 2020 Markus Armbruster <armbru@redhat.com> qga: Fix qmp_guest_suspend_{disk, ram}() error handling

The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second

qmp_guest_suspend_disk() and qmp_guest_suspend_ram() pass @local_err
first to check_suspend_mode(), then to acquire_privilege(), then to
execute_async(). Continuing after errors here can only end in tears.
For instance, we risk tripping error_setv()'s assertion.

Fixes: aa59637ea1c6a4c83430933f9c44c43e6c3f1b69
Fixes: f54603b6aa765514b2519e74114a2f417759d727
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200422130719.28225-15-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
aa59637ea1c6a4c83430933f9c44c43e6c3f1b69 Sun Jan 29 03:53:31 CST 2012 Gal Hammer <ghammer@redhat.com> qemu-ga: add win32 guest-suspend-disk command.

Implement guest-suspend-disk RPC for Windows. Functionally this should be
equivalent to the posix implementation.

Signed-off-by: Gal Hammer <ghammer@redhat.com>
/openbmc/qemu/
H A Dconfigureaa59637ea1c6a4c83430933f9c44c43e6c3f1b69 Sun Jan 29 03:53:31 CST 2012 Gal Hammer <ghammer@redhat.com> qemu-ga: add win32 guest-suspend-disk command.

Implement guest-suspend-disk RPC for Windows. Functionally this should be
equivalent to the posix implementation.

Signed-off-by: Gal Hammer <ghammer@redhat.com>