Home
last modified time | relevance | path

Searched hist:a6aca2f4 (Results 1 – 1 of 1) sorted by relevance

/openbmc/linux/drivers/irqchip/
H A Dqcom-pdc.ca6aca2f4 Thu Feb 24 04:12:25 CST 2022 Marc Zyngier <maz@kernel.org> irqchip/qcom-pdc: Fix broken locking

pdc_enable_intr() serves as a primitive to qcom_pdc_gic_{en,dis}able,
and has a raw spinlock for mutual exclusion, which is uses with
interruptible primitives.

This means that this critical section can itself be interrupted.
Should the interrupt also be a PDC interrupt, and the endpoint driver
perform an irq_disable() on that interrupt, we end-up in a deadlock.

Fix this by using the irqsave/irqrestore variants of the locking
primitives.

Signed-off-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Maulik Shah <quic_mkshah@quicinc.com>
Link: https://lore.kernel.org/r/20220224101226.88373-5-maz@kernel.org