Searched hist:a105d685 (Results 1 – 1 of 1) sorted by relevance
/openbmc/linux/fs/overlayfs/ |
H A D | dir.c | a105d685 Thu Nov 20 09:39:59 CST 2014 Miklos Szeredi <mszeredi@suse.cz> ovl: fix remove/copy-up race
ovl_remove_and_whiteout() needs to check if upper dentry exists or not after having locked upper parent directory.
Previously we used a "type" value computed before locking the upper parent directory, which is susceptible to racing with copy-up.
There's a similar check in ovl_check_empty_and_clear(). This one is not actually racy, since copy-up doesn't change the "emptyness" property of a directory. Add a comment to this effect, and check the existence of upper dentry locally to make the code cleaner.
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> a105d685 Thu Nov 20 09:39:59 CST 2014 Miklos Szeredi <mszeredi@suse.cz> ovl: fix remove/copy-up race ovl_remove_and_whiteout() needs to check if upper dentry exists or not after having locked upper parent directory. Previously we used a "type" value computed before locking the upper parent directory, which is susceptible to racing with copy-up. There's a similar check in ovl_check_empty_and_clear(). This one is not actually racy, since copy-up doesn't change the "emptyness" property of a directory. Add a comment to this effect, and check the existence of upper dentry locally to make the code cleaner. Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
|