Searched hist:"7 fa7cb71" (Results 1 – 1 of 1) sorted by relevance
/openbmc/linux/net/core/ |
H A D | fib_rules.c | 7fa7cb71 Sun Sep 26 23:18:27 CDT 2010 Eric Dumazet <eric.dumazet@gmail.com> fib: use atomic_inc_not_zero() in fib_rules_lookup
It seems we dont use appropriate refcount increment in an rcu_read_lock() protected section.
fib_rule_get() might increment a null refcount and bad things could happen.
While fib_nl_delrule() respects an rcu grace period before calling fib_rule_put(), fib_rules_cleanup_ops() calls fib_rule_put() without a grace period.
Note : after this patch, we might avoid the synchronize_rcu() call done in fib_nl_delrule()
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> 7fa7cb71 Sun Sep 26 23:18:27 CDT 2010 Eric Dumazet <eric.dumazet@gmail.com> fib: use atomic_inc_not_zero() in fib_rules_lookup It seems we dont use appropriate refcount increment in an rcu_read_lock() protected section. fib_rule_get() might increment a null refcount and bad things could happen. While fib_nl_delrule() respects an rcu grace period before calling fib_rule_put(), fib_rules_cleanup_ops() calls fib_rule_put() without a grace period. Note : after this patch, we might avoid the synchronize_rcu() call done in fib_nl_delrule() Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|