Searched hist:"77 ddaff2" (Results 1 – 1 of 1) sorted by relevance
/openbmc/linux/net/sched/ |
H A D | sch_fq_codel.c | 77ddaff2 Sat Aug 03 18:37:29 CDT 2019 Dave Taht <dave.taht@gmail.com> fq_codel: Kill useless per-flow dropped statistic
It is almost impossible to get anything other than a 0 out of flow->dropped statistic with a tc class dump, as it resets to 0 on every round.
It also conflates ecn marks with drops.
It would have been useful had it kept a cumulative drop count, but it doesn't. This patch doesn't change the API, it just stops tracking a stat and state that is impossible to measure and nobody uses.
Signed-off-by: Dave Taht <dave.taht@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> 77ddaff2 Sat Aug 03 18:37:29 CDT 2019 Dave Taht <dave.taht@gmail.com> fq_codel: Kill useless per-flow dropped statistic It is almost impossible to get anything other than a 0 out of flow->dropped statistic with a tc class dump, as it resets to 0 on every round. It also conflates ecn marks with drops. It would have been useful had it kept a cumulative drop count, but it doesn't. This patch doesn't change the API, it just stops tracking a stat and state that is impossible to measure and nobody uses. Signed-off-by: Dave Taht <dave.taht@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|