Searched hist:"6 e1a52fae1e39bdae6427bf060598242e1e4e4e6" (Results 1 – 3 of 3) sorted by relevance
| /openbmc/bmcweb/test/redfish-core/lib/ |
| H A D | ethernet_test.cpp | 6e1a52fae1e39bdae6427bf060598242e1e4e4e6 Fri Nov 15 21:44:16 CST 2024 Ed Tanous <etanous@nvidia.com> Fix setting gateways
There's a number of conditions in setting gateways that don't work
properly. Specifically, one of the issues is setting a gateway on an
address that already exists. It returns a PropertyValueConflict error
on Ipv4Addresses/1/Gateway with Ipv4Addresses/1/Gateway
Obviously an address can't conflict with itself, so this is wrong.
To address this, move the gateway setting and selection code into a
routine outside of the main loop, after all the gateways are accounted
for, and so we can treat them separately.
Tested;
PATCH to an existing ip address works, and no longer returns the error.
More test cases likely needed.
Change-Id: I0339e02fc27164337416637153d0b0f744b64ad8
Signed-off-by: Ed Tanous <etanous@nvidia.com>
|
| /openbmc/bmcweb/redfish-core/lib/ |
| H A D | ethernet.hpp | 6e1a52fae1e39bdae6427bf060598242e1e4e4e6 Fri Nov 15 21:44:16 CST 2024 Ed Tanous <etanous@nvidia.com> Fix setting gateways
There's a number of conditions in setting gateways that don't work
properly. Specifically, one of the issues is setting a gateway on an
address that already exists. It returns a PropertyValueConflict error
on Ipv4Addresses/1/Gateway with Ipv4Addresses/1/Gateway
Obviously an address can't conflict with itself, so this is wrong.
To address this, move the gateway setting and selection code into a
routine outside of the main loop, after all the gateways are accounted
for, and so we can treat them separately.
Tested;
PATCH to an existing ip address works, and no longer returns the error.
More test cases likely needed.
Change-Id: I0339e02fc27164337416637153d0b0f744b64ad8
Signed-off-by: Ed Tanous <etanous@nvidia.com>
|
| /openbmc/bmcweb/ |
| H A D | meson.build | 6e1a52fae1e39bdae6427bf060598242e1e4e4e6 Fri Nov 15 21:44:16 CST 2024 Ed Tanous <etanous@nvidia.com> Fix setting gateways
There's a number of conditions in setting gateways that don't work
properly. Specifically, one of the issues is setting a gateway on an
address that already exists. It returns a PropertyValueConflict error
on Ipv4Addresses/1/Gateway with Ipv4Addresses/1/Gateway
Obviously an address can't conflict with itself, so this is wrong.
To address this, move the gateway setting and selection code into a
routine outside of the main loop, after all the gateways are accounted
for, and so we can treat them separately.
Tested;
PATCH to an existing ip address works, and no longer returns the error.
More test cases likely needed.
Change-Id: I0339e02fc27164337416637153d0b0f744b64ad8
Signed-off-by: Ed Tanous <etanous@nvidia.com>
|