Searched hist:"4 ed52fbe" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/linux/drivers/soc/fsl/qe/ |
| H A D | qe_io.c | 4ed52fbe Wed Dec 29 19:45:43 CST 2021 Jiasheng Jiang <jiasheng@iscas.ac.cn> soc: fsl: qe: Check of ioremap return value
[ Upstream commit a222fd8541394b36b13c89d1698d9530afd59a9c ]
As the possible failure of the ioremap(), the par_io could be NULL.
Therefore it should be better to check it and return error in order to
guarantee the success of the initiation.
But, I also notice that all the caller like mpc85xx_qe_par_io_init() in
`arch/powerpc/platforms/85xx/common.c` don't check the return value of
the par_io_init().
Actually, par_io_init() needs to check to handle the potential error.
I will submit another patch to fix that.
Anyway, par_io_init() itsely should be fixed.
Fixes: 7aa1aa6ecec2 ("QE: Move QE from arch/powerpc to drivers/soc")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: Li Yang <leoyang.li@nxp.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
|