Home
last modified time | relevance | path

Searched hist:"4 e8748fc" (Results 1 – 1 of 1) sorted by relevance

/openbmc/linux/sound/soc/ux500/
H A Dmop500.c4e8748fc Tue May 12 05:07:05 CDT 2020 Christophe JAILLET <christophe.jaillet@wanadoo.fr> ASoC: ux500: mop500: Fix some refcounted resources issues

There are 2 issues here:
- if one of the 'of_parse_phandle' fails, calling 'mop500_of_node_put()'
is a no-op because the 'mop500_dai_links' structure has not been
initialized yet, so the referenced are not decremented
- The reference stored in 'mop500_dai_links[i].codecs' is refcounted
only once in the probe and must be decremented only once.

Fixes: 39013bd60e79 ("ASoC: Ux500: Dispose of device nodes correctly")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/20200512100705.246349-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>
4e8748fc Tue May 12 05:07:05 CDT 2020 Christophe JAILLET <christophe.jaillet@wanadoo.fr> ASoC: ux500: mop500: Fix some refcounted resources issues

There are 2 issues here:
- if one of the 'of_parse_phandle' fails, calling 'mop500_of_node_put()'
is a no-op because the 'mop500_dai_links' structure has not been
initialized yet, so the referenced are not decremented
- The reference stored in 'mop500_dai_links[i].codecs' is refcounted
only once in the probe and must be decremented only once.

Fixes: 39013bd60e79 ("ASoC: Ux500: Dispose of device nodes correctly")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/20200512100705.246349-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>