Home
last modified time | relevance | path

Searched hist:"43699 ca7" (Results 1 – 2 of 2) sorted by relevance

/openbmc/phosphor-bmc-code-mgmt/
H A Dimage_manager.cpp43699ca7 Wed Oct 17 14:56:29 CDT 2018 Adriana Kobylak <anoo@us.ibm.com> Rename Version::Errors to Image::Errors

The Version interface is a public interface, and errors are being
added to it:
https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-dbus-interfaces/+/13836/

This conflicts with the internal Version errors, so rename the
internal one to an Image namespace since that's not a public
interface and make more sense since the errors deal with failures
during image file extraction.

Tested:
Uploaded an invalid tar file (u-boot.bin) and the new Image::Error
was created:

"/xyz/openbmc_project/logging/entry/2": {
"AdditionalData": [
"PATH=/tmp/images/u-boot.bin",
"_PID=1348"
],
"Description": "An internal BMC error occurred",
"EventID": "None",
"Id": 2,
"Message": "xyz.openbmc_project.Software.Image.Error.UnTarFailure",

Change-Id: I6f6c84e2ea782c8ebc952bba4d5cee6be232f08f
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
H A Ditem_updater.cpp43699ca7 Wed Oct 17 14:56:29 CDT 2018 Adriana Kobylak <anoo@us.ibm.com> Rename Version::Errors to Image::Errors

The Version interface is a public interface, and errors are being
added to it:
https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-dbus-interfaces/+/13836/

This conflicts with the internal Version errors, so rename the
internal one to an Image namespace since that's not a public
interface and make more sense since the errors deal with failures
during image file extraction.

Tested:
Uploaded an invalid tar file (u-boot.bin) and the new Image::Error
was created:

"/xyz/openbmc_project/logging/entry/2": {
"AdditionalData": [
"PATH=/tmp/images/u-boot.bin",
"_PID=1348"
],
"Description": "An internal BMC error occurred",
"EventID": "None",
"Id": 2,
"Message": "xyz.openbmc_project.Software.Image.Error.UnTarFailure",

Change-Id: I6f6c84e2ea782c8ebc952bba4d5cee6be232f08f
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>