Searched hist:"395 e60cdc292dc0183c6867d34b43f14a373df55" (Results 1 – 1 of 1) sorted by relevance
/openbmc/u-boot/ |
H A D | Makefile | 794d5f55407080aaf5dd7585a98cefe9c6f9a569 Sun Apr 20 21:33:07 CDT 2014 Masahiro Yamada <yamada.m@jp.panasonic.com> Revert "build: Use filechk rules to create and update u-boot.lds"
This reverts commit a8b993eb81c142a439c24b871a2317f765fe5397.
Commit a8b993eb claims it fixes u-boot.lds rule by replacing $(call if_changed) with $(call filechk).
But the problem had already been fixed by commit 395e60cd a few days before commit a8b993eb was posted.
There is no reason to apply commit a8b993eb. What is worse is $(call filechk) is too strong to fix the problem and looks weird.
Date of the two patches:
[1] commit 395e60cdc292dc0183c6867d34b43f14a373df55 Author: Masahiro Yamada <yamada.m@jp.panasonic.com> AuthorDate: Wed Apr 9 20:10:43 2014 +0900 Commit: Tom Rini <trini@ti.com> CommitDate: Fri Apr 11 10:08:42 2014 -0400 replaces $(call if_changed) -> $(call if_changed_dep)
[2] commit a8b993eb81c142a439c24b871a2317f765fe5397 Author: Jon Loeliger <jon.loeliger@oracle.com> AuthorDate: Tue Apr 15 16:09:37 2014 -0500 Commit: Tom Rini <trini@ti.com> CommitDate: Fri Apr 18 16:14:16 2014 -0400 replaces $(call if_changed) -> $(call filechk)
A conflict must have happened when applying [2], but somehow it was applied, sadly.
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> Cc: Jon Loeliger <jon.loeliger@oracle.com> Cc: Andreas Bießmann <andreas.devel@googlemail.com> Cc: Tom Rini <trini@ti.com> 395e60cdc292dc0183c6867d34b43f14a373df55 Wed Apr 09 06:10:43 CDT 2014 Masahiro Yamada <yamada.m@jp.panasonic.com> kbuild: fix a bug in regeneration of linker scripts
In some use cases, SPL linker script was not updated even when it should be.
For instance,
$ make tricoder_config all [ build complete ] ... modify include/configs/tricoder.h $ make
spl/u-boot-spl.lds should be updated in this case, but it wasn't.
To fix this problem, linker scripts generation should be handled by $(call if_changed_dep,...) rather than by $(call if_changed,...).
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> Reported-by: Andreas Bießmann <andreas.devel@googlemail.com> Tested-by: Andreas Bießmann <andreas.devel@googlemail.com>
|