Home
last modified time | relevance | path

Searched hist:"2 cd1b572" (Results 1 – 1 of 1) sorted by relevance

/openbmc/u-boot/lib/
H A Dtime.c2cd1b572 Thu Dec 05 13:08:09 CST 2013 Stephen Warren <swarren@nvidia.com> time: fix usec_to_tick()

Commit 8dfafdde88eb ("Introduce common timer functions") created a
common definition of usec_to_tick() which had a couple problems:

static unsigned long long usec_to_tick(unsigned long usec)
{
uint64_t tick = usec * get_tbclk();

That likely overflows.

usec *= get_tbclk();

That was an attempt to fix it by performing the multiply after the
promotion of usec to 64-bit, but was applied to the wrong variable,
which was never used.

This patch fixes these issues. A user-visible symptom of the problem was
the e.g. "dhcp zImage" using an ASIX USB Ethernet dongle would print:

Waiting for Ethernet connection... unable to connect.

... with no delay before "unable to connect". There are likely other
symptoms.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Rob Herring <rob.herring@calxeda.com>