Searched hist:"21 f644f3" (Results 1 – 2 of 2) sorted by relevance
/openbmc/linux/net/atm/ |
H A D | lec.c | 21f644f3 Tue Apr 08 18:50:44 CDT 2008 David S. Miller <davem@davemloft.net> [NET]: Undo code bloat in hot paths due to print_mac().
If print_mac() is used inside of a pr_debug() the compiler can't see that the call is redundant so still performs it even of pr_debug() ends up being a nop.
So don't use print_mac() in such cases in hot code paths, use MAC_FMT et al. instead.
As noted by Joe Perches, pr_debug() could be modified to handle this better, but that is a change to an interface used by the entire kernel and thus needs to be validated carefully. This here is thus the less risky fix for 2.6.25
Signed-off-by: David S. Miller <davem@davemloft.net> 21f644f3 Tue Apr 08 18:50:44 CDT 2008 David S. Miller <davem@davemloft.net> [NET]: Undo code bloat in hot paths due to print_mac(). If print_mac() is used inside of a pr_debug() the compiler can't see that the call is redundant so still performs it even of pr_debug() ends up being a nop. So don't use print_mac() in such cases in hot code paths, use MAC_FMT et al. instead. As noted by Joe Perches, pr_debug() could be modified to handle this better, but that is a change to an interface used by the entire kernel and thus needs to be validated carefully. This here is thus the less risky fix for 2.6.25 Signed-off-by: David S. Miller <davem@davemloft.net>
|
/openbmc/linux/drivers/net/ |
H A D | virtio_net.c | 21f644f3 Tue Apr 08 18:50:44 CDT 2008 David S. Miller <davem@davemloft.net> [NET]: Undo code bloat in hot paths due to print_mac().
If print_mac() is used inside of a pr_debug() the compiler can't see that the call is redundant so still performs it even of pr_debug() ends up being a nop.
So don't use print_mac() in such cases in hot code paths, use MAC_FMT et al. instead.
As noted by Joe Perches, pr_debug() could be modified to handle this better, but that is a change to an interface used by the entire kernel and thus needs to be validated carefully. This here is thus the less risky fix for 2.6.25
Signed-off-by: David S. Miller <davem@davemloft.net> 21f644f3 Tue Apr 08 18:50:44 CDT 2008 David S. Miller <davem@davemloft.net> [NET]: Undo code bloat in hot paths due to print_mac(). If print_mac() is used inside of a pr_debug() the compiler can't see that the call is redundant so still performs it even of pr_debug() ends up being a nop. So don't use print_mac() in such cases in hot code paths, use MAC_FMT et al. instead. As noted by Joe Perches, pr_debug() could be modified to handle this better, but that is a change to an interface used by the entire kernel and thus needs to be validated carefully. This here is thus the less risky fix for 2.6.25 Signed-off-by: David S. Miller <davem@davemloft.net>
|