Searched hist:"1 d36c75a" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/qemu/hw/ppc/ |
| H A D | spapr.c | 1d36c75a Wed Apr 11 12:46:06 CDT 2018 Greg Kurz <groug@kaod.org> spapr: drop useless sanity check in spapr_irq_alloc*()
Both spapr_irq_alloc() and spapr_irq_alloc_block() have an errp
parameter, but they don't use it if XICS hasn't been initialized
yet.
This is doubly wrong:
- all callers do pass a non-null Error **, ie, they expect an error
to be propagated in case of failure
- XICS obviously needs to be initialized before anything starts allocating
IRQs
So this patch turns the check into an assert.
Signed-off-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
|