Searched hist:"19 fd4bb2" (Results 1 – 1 of 1) sorted by relevance
/openbmc/linux/fs/proc/ |
H A D | base.c | 19fd4bb2 Wed Nov 28 18:21:26 CST 2007 Eric W. Biederman <ebiederm@xmission.com> proc: remove races from proc_id_readdir()
Oleg noticed that the call of task_pid_nr_ns() in proc_pid_readdir is racy with respect to tasks exiting.
After a bit of examination it also appears that the call itself is completely unnecessary.
So to fix the problem this patch modifies next_tgid() to return both a tgid and the task struct in question.
A structure is introduced to return these values because it is slightly cleaner and easier to optimize, and the resulting code is a little shorter.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com> Cc: Oleg Nesterov <oleg@tv-sign.ru> Cc: Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> 19fd4bb2 Wed Nov 28 18:21:26 CST 2007 Eric W. Biederman <ebiederm@xmission.com> proc: remove races from proc_id_readdir() Oleg noticed that the call of task_pid_nr_ns() in proc_pid_readdir is racy with respect to tasks exiting. After a bit of examination it also appears that the call itself is completely unnecessary. So to fix the problem this patch modifies next_tgid() to return both a tgid and the task struct in question. A structure is introduced to return these values because it is slightly cleaner and easier to optimize, and the resulting code is a little shorter. Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com> Cc: Oleg Nesterov <oleg@tv-sign.ru> Cc: Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
|