Home
last modified time | relevance | path

Searched hist:"0 f9e5b57" (Results 1 – 2 of 2) sorted by relevance

/openbmc/linux/net/dccp/
H A Ddccp.h0f9e5b57 Sat Dec 09 20:03:51 CST 2006 Gerrit Renker <gerrit@erg.abdn.ac.uk> [DCCP]: Debug timeval operations

Problem:

Most target types in the CCID3 code are u32, so subtle conversion errors
can occur if signed time calculations yield negative results: the original
values are lost in the conversion to unsigned, calculation errors go undetected.

This patch therefore
* sets all critical time types from unsigned to suseconds_t
* avoids comparison between signed/unsigned via type-casting
* provides ample warning messages in case time calculations are negative

These warning messages can be removed at a later stage when the code
has undergone more testing.

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Acked-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
0f9e5b57 Sat Dec 09 20:03:51 CST 2006 Gerrit Renker <gerrit@erg.abdn.ac.uk> [DCCP]: Debug timeval operations

Problem:

Most target types in the CCID3 code are u32, so subtle conversion errors
can occur if signed time calculations yield negative results: the original
values are lost in the conversion to unsigned, calculation errors go undetected.

This patch therefore
* sets all critical time types from unsigned to suseconds_t
* avoids comparison between signed/unsigned via type-casting
* provides ample warning messages in case time calculations are negative

These warning messages can be removed at a later stage when the code
has undergone more testing.

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Acked-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
/openbmc/linux/net/dccp/ccids/
H A Dccid3.c0f9e5b57 Sat Dec 09 20:03:51 CST 2006 Gerrit Renker <gerrit@erg.abdn.ac.uk> [DCCP]: Debug timeval operations

Problem:

Most target types in the CCID3 code are u32, so subtle conversion errors
can occur if signed time calculations yield negative results: the original
values are lost in the conversion to unsigned, calculation errors go undetected.

This patch therefore
* sets all critical time types from unsigned to suseconds_t
* avoids comparison between signed/unsigned via type-casting
* provides ample warning messages in case time calculations are negative

These warning messages can be removed at a later stage when the code
has undergone more testing.

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Acked-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
0f9e5b57 Sat Dec 09 20:03:51 CST 2006 Gerrit Renker <gerrit@erg.abdn.ac.uk> [DCCP]: Debug timeval operations

Problem:

Most target types in the CCID3 code are u32, so subtle conversion errors
can occur if signed time calculations yield negative results: the original
values are lost in the conversion to unsigned, calculation errors go undetected.

This patch therefore
* sets all critical time types from unsigned to suseconds_t
* avoids comparison between signed/unsigned via type-casting
* provides ample warning messages in case time calculations are negative

These warning messages can be removed at a later stage when the code
has undergone more testing.

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Acked-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>