/* * Arm CPU feature test cases * * Copyright (c) 2019 Red Hat Inc. * Authors: * Andrew Jones * * This work is licensed under the terms of the GNU GPL, version 2 or later. * See the COPYING file in the top-level directory. */ #include "qemu/osdep.h" #include "qemu/bitops.h" #include "libqos/libqtest.h" #include "qapi/qmp/qdict.h" #include "qapi/qmp/qjson.h" /* * We expect the SVE max-vq to be 16. Also it must be <= 64 * for our test code, otherwise 'vls' can't just be a uint64_t. */ #define SVE_MAX_VQ 16 #define MACHINE "-machine virt,gic-version=max -accel tcg " #define MACHINE_KVM "-machine virt,gic-version=max -accel kvm -accel tcg " #define QUERY_HEAD "{ 'execute': 'query-cpu-model-expansion', " \ " 'arguments': { 'type': 'full', " #define QUERY_TAIL "}}" static bool kvm_enabled(QTestState *qts) { QDict *resp, *qdict; bool enabled; resp = qtest_qmp(qts, "{ 'execute': 'query-kvm' }"); g_assert(qdict_haskey(resp, "return")); qdict = qdict_get_qdict(resp, "return"); g_assert(qdict_haskey(qdict, "enabled")); enabled = qdict_get_bool(qdict, "enabled"); qobject_unref(resp); return enabled; } static QDict *do_query_no_props(QTestState *qts, const char *cpu_type) { return qtest_qmp(qts, QUERY_HEAD "'model': { 'name': %s }" QUERY_TAIL, cpu_type); } static QDict *do_query(QTestState *qts, const char *cpu_type, const char *fmt, ...) { QDict *resp; if (fmt) { QDict *args; va_list ap; va_start(ap, fmt); args = qdict_from_vjsonf_nofail(fmt, ap); va_end(ap); resp = qtest_qmp(qts, QUERY_HEAD "'model': { 'name': %s, " "'props': %p }" QUERY_TAIL, cpu_type, args); } else { resp = do_query_no_props(qts, cpu_type); } return resp; } static const char *resp_get_error(QDict *resp) { QDict *qdict; g_assert(resp); qdict = qdict_get_qdict(resp, "error"); if (qdict) { return qdict_get_str(qdict, "desc"); } return NULL; } #define assert_error(qts, cpu_type, expected_error, fmt, ...) \ ({ \ QDict *_resp; \ const char *_error; \ \ _resp = do_query(qts, cpu_type, fmt, ##__VA_ARGS__); \ g_assert(_resp); \ _error = resp_get_error(_resp); \ g_assert(_error); \ g_assert(g_str_equal(_error, expected_error)); \ qobject_unref(_resp); \ }) static bool resp_has_props(QDict *resp) { QDict *qdict; g_assert(resp); if (!qdict_haskey(resp, "return")) { return false; } qdict = qdict_get_qdict(resp, "return"); if (!qdict_haskey(qdict, "model")) { return false; } qdict = qdict_get_qdict(qdict, "model"); return qdict_haskey(qdict, "props"); } static QDict *resp_get_props(QDict *resp) { QDict *qdict; g_assert(resp); g_assert(resp_has_props(resp)); qdict = qdict_get_qdict(resp, "return"); qdict = qdict_get_qdict(qdict, "model"); qdict = qdict_get_qdict(qdict, "props"); return qdict; } static bool resp_get_feature(QDict *resp, const char *feature) { QDict *props; g_assert(resp); g_assert(resp_has_props(resp)); props = resp_get_props(resp); g_assert(qdict_get(props, feature)); return qdict_get_bool(props, feature); } #define assert_has_feature(qts, cpu_type, feature) \ ({ \ QDict *_resp = do_query_no_props(qts, cpu_type); \ g_assert(_resp); \ g_assert(resp_has_props(_resp)); \ g_assert(qdict_get(resp_get_props(_resp), feature)); \ qobject_unref(_resp); \ }) #define assert_has_not_feature(qts, cpu_type, feature) \ ({ \ QDict *_resp = do_query_no_props(qts, cpu_type); \ g_assert(_resp); \ g_assert(!resp_has_props(_resp) || \ !qdict_get(resp_get_props(_resp), feature)); \ qobject_unref(_resp); \ }) #define resp_assert_feature(resp, feature, expected_value) \ ({ \ QDict *_props; \ \ g_assert(_resp); \ g_assert(resp_has_props(_resp)); \ _props = resp_get_props(_resp); \ g_assert(qdict_get(_props, feature)); \ g_assert(qdict_get_bool(_props, feature) == (expected_value)); \ }) #define assert_feature(qts, cpu_type, feature, expected_value) \ ({ \ QDict *_resp; \ \ _resp = do_query_no_props(qts, cpu_type); \ g_assert(_resp); \ resp_assert_feature(_resp, feature, expected_value); \ qobject_unref(_resp); \ }) #define assert_set_feature(qts, cpu_type, feature, value) \ ({ \ const char *_fmt = (value) ? "{ %s: true }" : "{ %s: false }"; \ QDict *_resp; \ \ _resp = do_query(qts, cpu_type, _fmt, feature); \ g_assert(_resp); \ resp_assert_feature(_resp, feature, value); \ qobject_unref(_resp); \ }) #define assert_has_feature_enabled(qts, cpu_type, feature) \ assert_feature(qts, cpu_type, feature, true) #define assert_has_feature_disabled(qts, cpu_type, feature) \ assert_feature(qts, cpu_type, feature, false) static void assert_type_full(QTestState *qts) { const char *error; QDict *resp; resp = qtest_qmp(qts, "{ 'execute': 'query-cpu-model-expansion', " "'arguments': { 'type': 'static', " "'model': { 'name': 'foo' }}}"); g_assert(resp); error = resp_get_error(resp); g_assert(error); g_assert(g_str_equal(error, "The requested expansion type is not supported")); qobject_unref(resp); } static void assert_bad_props(QTestState *qts, const char *cpu_type) { const char *error; QDict *resp; resp = qtest_qmp(qts, "{ 'execute': 'query-cpu-model-expansion', " "'arguments': { 'type': 'full', " "'model': { 'name': %s, " "'props': false }}}", cpu_type); g_assert(resp); error = resp_get_error(resp); g_assert(error); g_assert(g_str_equal(error, "Invalid parameter type for 'props', expected: dict")); qobject_unref(resp); } static uint64_t resp_get_sve_vls(QDict *resp) { QDict *props; const QDictEntry *e; uint64_t vls = 0; int n = 0; g_assert(resp); g_assert(resp_has_props(resp)); props = resp_get_props(resp); for (e = qdict_first(props); e; e = qdict_next(props, e)) { if (strlen(e->key) > 3 && !strncmp(e->key, "sve", 3) && g_ascii_isdigit(e->key[3])) { char *endptr; int bits; bits = g_ascii_strtoll(&e->key[3], &endptr, 10); if (!bits || *endptr != '\0') { continue; } if (qdict_get_bool(props, e->key)) { vls |= BIT_ULL((bits / 128) - 1); } ++n; } } g_assert(n == SVE_MAX_VQ); return vls; } #define assert_sve_vls(qts, cpu_type, expected_vls, fmt, ...) \ ({ \ QDict *_resp = do_query(qts, cpu_type, fmt, ##__VA_ARGS__); \ g_assert(_resp); \ g_assert(resp_has_props(_resp)); \ g_assert(resp_get_sve_vls(_resp) == expected_vls); \ qobject_unref(_resp); \ }) static void sve_tests_default(QTestState *qts, const char *cpu_type) { /* * With no sve-max-vq or sve properties on the command line * the default is to have all vector lengths enabled. This also * tests that 'sve' is 'on' by default. */ assert_sve_vls(qts, cpu_type, BIT_ULL(SVE_MAX_VQ) - 1, NULL); /* With SVE off, all vector lengths should also be off. */ assert_sve_vls(qts, cpu_type, 0, "{ 'sve': false }"); /* With SVE on, we must have at least one vector length enabled. */ assert_error(qts, cpu_type, "cannot disable sve128", "{ 'sve128': false }"); /* Basic enable/disable tests. */ assert_sve_vls(qts, cpu_type, 0x7, "{ 'sve384': true }"); assert_sve_vls(qts, cpu_type, ((BIT_ULL(SVE_MAX_VQ) - 1) & ~BIT_ULL(2)), "{ 'sve384': false }"); /* * --------------------------------------------------------------------- * power-of-two(vq) all-power- can can * of-two(< vq) enable disable * --------------------------------------------------------------------- * vq < max_vq no MUST* yes yes * vq < max_vq yes MUST* yes no * --------------------------------------------------------------------- * vq == max_vq n/a MUST* yes** yes** * --------------------------------------------------------------------- * vq > max_vq n/a no no yes * vq > max_vq n/a yes yes yes * --------------------------------------------------------------------- * * [*] "MUST" means this requirement must already be satisfied, * otherwise 'max_vq' couldn't itself be enabled. * * [**] Not testable with the QMP interface, only with the command line. */ /* max_vq := 8 */ assert_sve_vls(qts, cpu_type, 0x8b, "{ 'sve1024': true }"); /* max_vq := 8, vq < max_vq, !power-of-two(vq) */ assert_sve_vls(qts, cpu_type, 0x8f, "{ 'sve1024': true, 'sve384': true }"); assert_sve_vls(qts, cpu_type, 0x8b, "{ 'sve1024': true, 'sve384': false }"); /* max_vq := 8, vq < max_vq, power-of-two(vq) */ assert_sve_vls(qts, cpu_type, 0x8b, "{ 'sve1024': true, 'sve256': true }"); assert_error(qts, cpu_type, "cannot disable sve256", "{ 'sve1024': true, 'sve256': false }"); /* max_vq := 3, vq > max_vq, !all-power-of-two(< vq) */ assert_error(qts, cpu_type, "cannot disable sve512", "{ 'sve384': true, 'sve512': false, 'sve640': true }"); /* * We can disable power-of-two vector lengths when all larger lengths * are also disabled. We only need to disable the power-of-two length, * as all non-enabled larger lengths will then be auto-disabled. */ assert_sve_vls(qts, cpu_type, 0x7, "{ 'sve512': false }"); /* max_vq := 3, vq > max_vq, all-power-of-two(< vq) */ assert_sve_vls(qts, cpu_type, 0x1f, "{ 'sve384': true, 'sve512': true, 'sve640': true }"); assert_sve_vls(qts, cpu_type, 0xf, "{ 'sve384': true, 'sve512': true, 'sve640': false }"); } static void sve_tests_sve_max_vq_8(const void *data) { QTestState *qts; qts = qtest_init(MACHINE "-cpu max,sve-max-vq=8"); assert_sve_vls(qts, "max", BIT_ULL(8) - 1, NULL); /* * Disabling the max-vq set by sve-max-vq is not allowed, but * of course enabling it is OK. */ assert_error(qts, "max", "cannot disable sve1024", "{ 'sve1024': false }"); assert_sve_vls(qts, "max", 0xff, "{ 'sve1024': true }"); /* * Enabling anything larger than max-vq set by sve-max-vq is not * allowed, but of course disabling everything larger is OK. */ assert_error(qts, "max", "cannot enable sve1152", "{ 'sve1152': true }"); assert_sve_vls(qts, "max", 0xff, "{ 'sve1152': false }"); /* * We can enable/disable non power-of-two lengths smaller than the * max-vq set by sve-max-vq, but, while we can enable power-of-two * lengths, we can't disable them. */ assert_sve_vls(qts, "max", 0xff, "{ 'sve384': true }"); assert_sve_vls(qts, "max", 0xfb, "{ 'sve384': false }"); assert_sve_vls(qts, "max", 0xff, "{ 'sve256': true }"); assert_error(qts, "max", "cannot disable sve256", "{ 'sve256': false }"); qtest_quit(qts); } static void sve_tests_sve_off(const void *data) { QTestState *qts; qts = qtest_init(MACHINE "-cpu max,sve=off"); /* SVE is off, so the map should be empty. */ assert_sve_vls(qts, "max", 0, NULL); /* The map stays empty even if we turn lengths off. */ assert_sve_vls(qts, "max", 0, "{ 'sve128': false }"); /* It's an error to enable lengths when SVE is off. */ assert_error(qts, "max", "cannot enable sve128", "{ 'sve128': true }"); /* With SVE re-enabled we should get all vector lengths enabled. */ assert_sve_vls(qts, "max", BIT_ULL(SVE_MAX_VQ) - 1, "{ 'sve': true }"); /* Or enable SVE with just specific vector lengths. */ assert_sve_vls(qts, "max", 0x3, "{ 'sve': true, 'sve128': true, 'sve256': true }"); qtest_quit(qts); } static void sve_tests_sve_off_kvm(const void *data) { QTestState *qts; qts = qtest_init(MACHINE_KVM "-cpu max,sve=off"); /* * We don't know if this host supports SVE so we don't * attempt to test enabling anything. We only test that * everything is disabled (as it should be with sve=off) * and that using sve=off to explicitly disable vector * lengths is OK too. */ assert_sve_vls(qts, "max", 0, NULL); assert_sve_vls(qts, "max", 0, "{ 'sve128': false }"); qtest_quit(qts); } static void test_query_cpu_model_expansion(const void *data) { QTestState *qts; qts = qtest_init(MACHINE "-cpu max"); /* Test common query-cpu-model-expansion input validation */ assert_type_full(qts); assert_bad_props(qts, "max"); assert_error(qts, "foo", "The CPU type 'foo' is not a recognized " "ARM CPU type", NULL); assert_error(qts, "max", "Parameter 'not-a-prop' is unexpected", "{ 'not-a-prop': false }"); assert_error(qts, "host", "The CPU type 'host' requires KVM", NULL); /* Test expected feature presence/absence for some cpu types */ assert_has_feature_enabled(qts, "cortex-a15", "pmu"); assert_has_not_feature(qts, "cortex-a15", "aarch64"); /* Enabling and disabling pmu should always work. */ assert_has_feature_enabled(qts, "max", "pmu"); assert_set_feature(qts, "max", "pmu", false); assert_set_feature(qts, "max", "pmu", true); assert_has_not_feature(qts, "max", "kvm-no-adjvtime"); assert_has_not_feature(qts, "max", "kvm-steal-time"); if (g_str_equal(qtest_get_arch(), "aarch64")) { assert_has_feature_enabled(qts, "max", "aarch64"); assert_has_feature_enabled(qts, "max", "sve"); assert_has_feature_enabled(qts, "max", "sve128"); assert_has_feature_enabled(qts, "cortex-a57", "pmu"); assert_has_feature_enabled(qts, "cortex-a57", "aarch64"); sve_tests_default(qts, "max"); /* Test that features that depend on KVM generate errors without. */ assert_error(qts, "max", "'aarch64' feature cannot be disabled " "unless KVM is enabled and 32-bit EL1 " "is supported", "{ 'aarch64': false }"); } qtest_quit(qts); } static void test_query_cpu_model_expansion_kvm(const void *data) { QTestState *qts; qts = qtest_init(MACHINE_KVM "-cpu max"); /* * These tests target the 'host' CPU type, so KVM must be enabled. */ if (!kvm_enabled(qts)) { qtest_quit(qts); return; } /* Enabling and disabling kvm-no-adjvtime should always work. */ assert_has_feature_disabled(qts, "host", "kvm-no-adjvtime"); assert_set_feature(qts, "host", "kvm-no-adjvtime", true); assert_set_feature(qts, "host", "kvm-no-adjvtime", false); if (g_str_equal(qtest_get_arch(), "aarch64")) { bool kvm_supports_steal_time; bool kvm_supports_sve; char max_name[8], name[8]; uint32_t max_vq, vq; uint64_t vls; QDict *resp; char *error; assert_error(qts, "cortex-a15", "We cannot guarantee the CPU type 'cortex-a15' works " "with KVM on this host", NULL); assert_has_feature_enabled(qts, "host", "aarch64"); /* Enabling and disabling pmu should always work. */ assert_has_feature_enabled(qts, "host", "pmu"); assert_set_feature(qts, "host", "pmu", false); assert_set_feature(qts, "host", "pmu", true); /* * Some features would be enabled by default, but they're disabled * because this instance of KVM doesn't support them. Test that the * features are present, and, when enabled, issue further tests. */ assert_has_feature(qts, "host", "kvm-steal-time"); assert_has_feature(qts, "host", "sve"); resp = do_query_no_props(qts, "host"); kvm_supports_steal_time = resp_get_feature(resp, "kvm-steal-time"); kvm_supports_sve = resp_get_feature(resp, "sve"); vls = resp_get_sve_vls(resp); qobject_unref(resp); if (kvm_supports_steal_time) { /* If we have steal-time then we should be able to toggle it. */ assert_set_feature(qts, "host", "kvm-steal-time", false); assert_set_feature(qts, "host", "kvm-steal-time", true); } if (kvm_supports_sve) { g_assert(vls != 0); max_vq = 64 - __builtin_clzll(vls); sprintf(max_name, "sve%u", max_vq * 128); /* Enabling a supported length is of course fine. */ assert_sve_vls(qts, "host", vls, "{ %s: true }", max_name); /* Get the next supported length smaller than max-vq. */ vq = 64 - __builtin_clzll(vls & ~BIT_ULL(max_vq - 1)); if (vq) { /* * We have at least one length smaller than max-vq, * so we can disable max-vq. */ assert_sve_vls(qts, "host", (vls & ~BIT_ULL(max_vq - 1)), "{ %s: false }", max_name); /* * Smaller, supported vector lengths cannot be disabled * unless all larger, supported vector lengths are also * disabled. */ sprintf(name, "sve%u", vq * 128); error = g_strdup_printf("cannot disable %s", name); assert_error(qts, "host", error, "{ %s: true, %s: false }", max_name, name); g_free(error); } /* * The smallest, supported vector length is required, because * we need at least one vector length enabled. */ vq = __builtin_ffsll(vls); sprintf(name, "sve%u", vq * 128); error = g_strdup_printf("cannot disable %s", name); assert_error(qts, "host", error, "{ %s: false }", name); g_free(error); /* Get an unsupported length. */ for (vq = 1; vq <= max_vq; ++vq) { if (!(vls & BIT_ULL(vq - 1))) { break; } } if (vq <= SVE_MAX_VQ) { sprintf(name, "sve%u", vq * 128); error = g_strdup_printf("cannot enable %s", name); assert_error(qts, "host", error, "{ %s: true }", name); g_free(error); } } else { g_assert(vls == 0); } } else { assert_has_not_feature(qts, "host", "aarch64"); assert_has_not_feature(qts, "host", "pmu"); assert_has_not_feature(qts, "host", "sve"); assert_has_not_feature(qts, "host", "kvm-steal-time"); } qtest_quit(qts); } int main(int argc, char **argv) { g_test_init(&argc, &argv, NULL); qtest_add_data_func("/arm/query-cpu-model-expansion", NULL, test_query_cpu_model_expansion); /* * For now we only run KVM specific tests with AArch64 QEMU in * order avoid attempting to run an AArch32 QEMU with KVM on * AArch64 hosts. That won't work and isn't easy to detect. */ if (g_str_equal(qtest_get_arch(), "aarch64")) { qtest_add_data_func("/arm/kvm/query-cpu-model-expansion", NULL, test_query_cpu_model_expansion_kvm); } if (g_str_equal(qtest_get_arch(), "aarch64")) { qtest_add_data_func("/arm/max/query-cpu-model-expansion/sve-max-vq-8", NULL, sve_tests_sve_max_vq_8); qtest_add_data_func("/arm/max/query-cpu-model-expansion/sve-off", NULL, sve_tests_sve_off); qtest_add_data_func("/arm/kvm/query-cpu-model-expansion/sve-off", NULL, sve_tests_sve_off_kvm); } return g_test_run(); }