qemu/scripts/checkpatch.pl

1320 sub ERROR {  subroutine
1348 		ERROR("Do not add expected files together with tests, " .
1407 	ERROR("Saw unacceptable licenses '" . join(',', @unknown) .
1630 				ERROR("do not set execute permissions for source files\n" . $permhere);
1637 			ERROR("please use python3 interpreter\n" . $herecurr);
1646 		    ERROR("Author email address is mangled by the mailing list\n" . $herecurr);
1656 				ERROR("The correct form is \"Signed-off-by\"\n" .
1660 				ERROR("space required after Signed-off-by:\n" .
1690 			    ERROR("New file '$expect_spdx_file' requires " .
1724 			ERROR("Tag $tag not permitted in QEMU code, valid " .
1731 			ERROR("patch seems to be corrupt (line wrapped?)\n" .
1744 			ERROR("Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr);
1748 			ERROR("Doubly-encoded UTF-8\n" . $herecurr);
1805 			ERROR("headers imported from Linux should be self-" .
1817 			ERROR("DOS line endings\n" . $herevet);
1825 			ERROR("code blocks in documentation should have " .
1831 			ERROR("trailing whitespace\n" . $herevet);
1838 				ERROR("Don't use '#' flag of printf format ('%#') in " .
1849 					ERROR("Hex numbers must be prefixed with '0x'\n" .
1865 				ERROR("line over 90 characters\n" . $herecurr);
1873 			ERROR("unnecessary whitespace before a quoted newline\n" . $herecurr);
1878 			ERROR("adding a line without newline at end of file\n" . $herecurr);
1883 			ERROR("CVS style keyword markers, these will _not_ be updated\n". $herecurr);
1894 			ERROR("code indent should never use tabs\n" . $herevet);
2037 				ERROR("switch and case should be at the same indent\n$hereline$err");
2071 				ERROR("that open brace { should be on the previous line\n" .
2080 					ERROR("trailing semicolon indicates no statements, indent implies otherwise\n" .
2088 			ERROR("suspicious ; after while (0)\n" . $herecurr);
2093 			ERROR("superfluous trailing semicolon\n" . $herecurr);
2178 …ERROR("suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_…
2201 				ERROR("TEST: is type\n" . $herecurr);
2203 				ERROR("TEST: is not type ($1 is)\n". $herecurr);
2210 				ERROR("TEST: is attr\n" . $herecurr);
2212 				ERROR("TEST: is not attr ($1 is)\n". $herecurr);
2220 			ERROR("that open brace { should be on the previous line\n" . $hereprev);
2231 				ERROR("malformed #include filename\n" .
2239 			ERROR("do not use C99 // comments\n" . $herecurr);
2247 			ERROR("do not initialise globals to 0 or NULL\n" .
2252 			ERROR("do not initialise statics to 0 or NULL\n" .
2271 				ERROR("\"(foo$from)\" should be \"(foo$to)\"\n" .  $herecurr);
2288 				ERROR("\"foo${from}bar\" should be \"foo${to}bar\"\n" .  $herecurr);
2296 			ERROR("open brace '{' following function declarations go on the next line\n" . $herecurr);
2302 			ERROR("open brace '{' following $1 go on the same line\n" . $hereprev);
2307 		    ERROR("missing space after $1 definition\n" . $herecurr);
2322 				ERROR("space prohibited before open square bracket '['\n" . $herecurr);
2356 				ERROR("space prohibited between function name and open parenthesis '('\n" . $herecurr);
2430 						ERROR("space required after that '$op' $at\n" . $hereptr);
2445 						ERROR("spaces prohibited around that '$op' $at\n" . $hereptr);
2453 						ERROR("space required after that '$op' $at\n" . $hereptr);
2470 						ERROR("space required before that '$op' $at\n" . $hereptr);
2476 						ERROR("space prohibited after that '$op' $at\n" . $hereptr);
2482 						ERROR("space required one side of that '$op' $at\n" . $hereptr);
2486 						ERROR("space prohibited before that '$op' $at\n" . $hereptr);
2489 						ERROR("space prohibited after that '$op' $at\n" . $hereptr);
2496 						ERROR("space prohibited before that '$op' $at\n" . $hereptr);
2531 						ERROR("spaces required around that '$op' $at\n" . $hereptr);
2541 			ERROR("space required before the open brace '{'\n" . $herecurr);
2547 			ERROR("space required after that close brace '}'\n" . $herecurr);
2552 			ERROR("space prohibited after that open square bracket '['\n" . $herecurr);
2555 			ERROR("space prohibited before that close square bracket ']'\n" . $herecurr);
2561 			ERROR("space prohibited after that open parenthesis '('\n" . $herecurr);
2566 			ERROR("space prohibited before that close parenthesis ')'\n" . $herecurr);
2586 				ERROR("return is not a function, parentheses are not required\n" . $herecurr);
2589 				ERROR("space required before the open parenthesis '('\n" . $herecurr);
2596 				ERROR("return of an errno should typically be -ve (return -$1)\n" . $herecurr);
2602 		    ERROR("named $1 should be typedefed separately\n" . $herecurr);
2607 			ERROR("space required before the open parenthesis '('\n" . $herecurr);
2635 				ERROR("do not use assignment in if condition\n" . $herecurr);
2657 				ERROR("trailing statements should be on next line\n" . $herecurr . $stat_real);
2673 			ERROR("boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr);
2681 				ERROR("trailing statements should be on next line\n" . $herecurr);
2686 			ERROR("trailing statements should be on next line\n" .
2696 			ERROR("trailing statements should be on next line\n" . $herecurr);
2703 			ERROR("else should follow close brace '}'\n" . $hereprev);
2716 				ERROR("while should follow close brace '}'\n" . $hereprev);
2729 			ERROR("Whitespace after \\ makes next lines useless\n" . $herecurr);
2811 …ERROR("Macros with multiple statements should be enclosed in a do - while loop\n" . "$here\n$ctx\n…
2821 					ERROR("Macros with complex values should be enclosed in parenthesis\n" . "$here\n$ctx\n");
2893 					ERROR("braces {} are necessary for all arms of this statement\n" . $herectx);
2961 				ERROR("braces {} are necessary even for single statement blocks\n" . $herectx);
2971                         ERROR($msg);
2976 			ERROR("if this code is redundant consider removing it\n" .
2984 				ERROR("g_free(NULL) is safe this check is probably not required\n" . $hereprev);
2997 			ERROR("exactly one space required after that #$1\n" . $herecurr);
3002 				ERROR("memory barrier without comment\n" . $herecurr);
3014 			ERROR("storage class should be at the beginning of the declaration\n" . $herecurr)
3021 			ERROR("inline keyword should sit between storage class and type\n" . $herecurr);
3026 			ERROR("sizeof(& should be avoided\n" . $herecurr);
3043 				ERROR("externs should be avoided in .c files\n" .  $herecurr);
3047 				ERROR("arguments for function declarations should follow identifier\n" . $herecurr);
3053 			ERROR("externs should be avoided in .c files\n" .  $herecurr);
3059 				ERROR("unnecessary cast may hide bugs, use g_$1new$3 instead\n" . $herecurr);
3061 				ERROR("unnecessary cast may hide bugs, use g_$1renew$3 instead\n" . $herecurr);
3067 			ERROR("__func__ should be used instead of gcc specific __FUNCTION__\n"  . $herecurr);
3077 			ERROR("use g_memdup2() instead of unsafe g_memdup()\n" . $herecurr);
3082 			ERROR("consider using qemu_$1 in preference to $1\n" . $herecurr);
3086 			ERROR("use sigaction to establish signal handlers; signal is not portable\n" . $herecurr);
3090 …ERROR("use qemu_bh_new_guarded() instead of qemu_bh_new() to avoid reentrancy problems\n" . $herec…
3094 …ERROR("use aio_bh_new_guarded() instead of aio_bh_new() to avoid reentrancy problems\n" . $herecur…
3098 			ERROR("please use block_init(), type_init() etc. instead of module_init()\n" . $herecurr);
3123 			ERROR("initializer for struct $1 should normally be const\n" .
3134 				ERROR("\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr);
3138 				ERROR("Don't use '#' flag of printf format " .
3146 			ERROR("use QEMU instead of Qemu or QEmu\n" . $herecurr);
3169 		ERROR("Error messages should not contain newlines\n" . $herecurr);
3190 			ERROR("Error messages should not contain newlines\n" . $herecurr);
3196 			ERROR("use ctz32() instead of ffs()\n" . $herecurr);
3199 			ERROR("use ctz32() or ctz64() instead of ffsl()\n" . $herecurr);
3202 			ERROR("use ctz64() instead of ffsll()\n" . $herecurr);
3205 			ERROR("use memset() instead of bzero()\n" . $herecurr);
3208 			ERROR("use qemu_real_host_page_size() instead of getpagesize()\n" . $herecurr);
3211 			ERROR("use qemu_real_host_page_size() instead of sysconf(_SC_PAGESIZE)\n" . $herecurr);
3214 			ERROR("use g_assert_not_reached() instead of assert(0)\n" . $herecurr);
3217 			ERROR("use g_assert_not_reached() instead of assert(false)\n" .
3221 			ERROR("use strerror() instead of strerrorname_np()\n" . $herecurr);
3242 			ERROR("Use g_assert or g_assert_not_reached\n". $herecurr);
3247 		ERROR("Missing Signed-off-by: line(s)\n");
3269 		ERROR("Does not appear to be a unified-diff format patch\n");