refactor power restore controller

Currently PowerRestorePolicy handling code uses two undocumented
interfaces:
* `xyz.openbmc_project.Control.Power.RestoreDelay`
* `xyz.openbmc_project.Common.ACBoot

refactor power restore controller

Currently PowerRestorePolicy handling code uses two undocumented
interfaces:
* `xyz.openbmc_project.Control.Power.RestoreDelay`
* `xyz.openbmc_project.Common.ACBoot`

Power Restore Delay seems to be logical part of
`xyz.openbmc_project.Control.Power.RestorePolicy` interface and has
been moved there.

ACBoot depends on some custom logic that can be found only in Intel-BMC
fork.

This commit reorganize PowerRestorePolicy-related code to be more clear
and flexible, fixes interface for RestoreDelay. Use of ACBoot feature is
now optional and can be compile-time enabled.

Tested: Model power loss event with Off, On and Restore policy, verify,
that power restored as expected.
Test On policy with Delay set to 300000000 - ensure, power on
delayed by 5 minutes.
Test with ACBoot interface emulated.
Signed-off-by: Andrei Kartashev <a.kartashev@yadro.com>
Change-Id: Id8b42d2085f44418e02a7f52836cc1a6f55f50db

show more ...

Correct osState string to match xyz naming format for fixing automation test

Symptom:
"Verify Dump After Host Watchdog Error Injection" automation test item failed.

Root cause:
Due to "Is OS Booted

Correct osState string to match xyz naming format for fixing automation test

Symptom:
"Verify Dump After Host Watchdog Error Injection" automation test item failed.

Root cause:
Due to "Is OS Booted" keyword got failed in lib/state_manager.robot.

According openbmc-test-automation/lib/variables.py
The "os_state" must match to
"xyz.openbmc_project.State.OperatingSystem.Status.OSStatus.Standby".

But, "osState" string in x86-power-control just return "Standby" instead of
"xyz.openbmc_project.State.OperatingSystem.Status.OSStatus.Standby".
Thus keyword "Is OS Booted" return failed then cause test item got failed.

Reference:
openbmc-test-automation/lib/state_manager.robot:
Is OS Booted
[Documentation] Check OS status.
${os_state}= Get Host State Attribute OperatingSystemState
Should Be Equal ${OS_BOOT_COMPLETE} ${os_state}

openbmc-test-automation/lib/variables.py:
STATE_DBUS_BASE = 'xyz.openbmc_project.State.'
OS_BOOT_COMPLETE = STATE_DBUS_BASE + \
'OperatingSystem.Status.OSStatus.Standby'

Solution:
Correct osState string to match xyz naming format and consistent with auto test.

Tested:
Host Power ON:
busctl call xyz.openbmc_project.State.Host /xyz/openbmc_project/state/host0 \
org.freedesktop.DBus.Properties \
GetAll s "xyz.openbmc_project.State.OperatingSystem.Status"
a{sv} 1 "OperatingSystemState" s "xyz.openbmc_project.State.OperatingSystem.Status.OSStatus.Standby"

Host Power OFF:
busctl call xyz.openbmc_project.State.Host /xyz/openbmc_project/state/host0 \
org.freedesktop.DBus.Properties \
GetAll s "xyz.openbmc_project.State.OperatingSystem.Status"
"xyz.openbmc_project.State.OperatingSystem.Status.OSStatus.Inactive"

Signed-off-by: Tim Lee <timlee660101@gmail.com>
Change-Id: Ia63100a6756104a645c2d789d3b5be560a1305ff

show more ...

use same consumer for each gpio request

The `consumer` field of line_request supposed to represent consumer
application. Currently x86-power-control uses different names for
different cases: applica

use same consumer for each gpio request

The `consumer` field of line_request supposed to represent consumer
application. Currently x86-power-control uses different names for
different cases: application name for inputs and function name for
outputs.

There is no benefits in use function name as consumer, so use
application name in both cases.

Tested: gpioinfo | grep -i power-control
see all gpios, used by x86-power-control
Signed-off-by: Andrei Kartashev <a.kartashev@yadro.com>
Change-Id: I1baef7bd4bb9b0c2efcb423f513f56d244a0cbdd

show more ...

introduce PersistentState manager

This commit brings new mechanism to store application state over system
reboot. State is saved to json file and restored on application startup
by easy to use class

introduce PersistentState manager

This commit brings new mechanism to store application state over system
reboot. State is saved to json file and restored on application startup
by easy to use class.

Currently only PowerState is managed by this class but more states can
be added in future.

Tested: verify that power state saved to file and restored on startup
Change-Id: I91fb46f262827dda89f438eefea38d59e02ba25c
Signed-off-by: Andrei Kartashev <a.kartashev@yadro.com>

show more ...

Change to lg2

To take advantage of the improved structured logging, change
x86-power-control logging to lg2.

Also fixed up some minor formatting issues and added more
detail to clarify some of the

Change to lg2

To take advantage of the improved structured logging, change
x86-power-control logging to lg2.

Also fixed up some minor formatting issues and added more
detail to clarify some of the debug messages.

Tested:
Ran a power off, on, cycle, and reset and confirmed that the
logs look the same.

Change-Id: Iad601e39a54e7e1dc0f26352711cb1b3d5f83522
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Changes for dbus based gpio config.

Updating dbus match search filter function with more specific
interface name to avoid match function event handler getting called
for multiple not relevant proper

Changes for dbus based gpio config.

Updating dbus match search filter function with more specific
interface name to avoid match function event handler getting called
for multiple not relevant properties.

Updating the variable type to match with the return type from
sdbusplus method call

TESTED:Tested and verified in YosemiteV2.

Signed-off-by: Logananth Sundararaj <logananth.s@hcl.com>
Change-Id: Ib910b8b7c174247e7199eb0785fa9c81f6a54aac

show more ...

Fix issues flagged by werror

This fixes the issues that are flagged by werror in preparation
for enabling a meson build.

Change-Id: Icf05316d21390188f84da5b59f97319e3718e728
Signed-off-by: Jason M.

Fix issues flagged by werror

This fixes the issues that are flagged by werror in preparation
for enabling a meson build.

Change-Id: Icf05316d21390188f84da5b59f97319e3718e728
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Re-organize source

After removing i2c support, we can reduce the depth of the source
code and remove the power-control-x86 folder.

We can also simplify the CMake files.

Tested:
Confirmed that ipmi

Re-organize source

After removing i2c support, we can reduce the depth of the source
code and remove the power-control-x86 folder.

We can also simplify the CMake files.

Tested:
Confirmed that ipmi power control commands all still work correctly.

Change-Id: I67104e40555d4d84c2b946fad000e3a541828272
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...