| 7768e783 | 12-Jun-2023 |
Gunnar Mills <gmills@us.ibm.com> |
Remove How do I become a Design Partner
Nicole is no longer working on the project, remove her name and the section about becoming a design partner.
Change-Id: I1b25dc1f5479093fed1b645bbc6b352fd75e
Remove How do I become a Design Partner
Nicole is no longer working on the project, remove her name and the section about becoming a design partner.
Change-Id: I1b25dc1f5479093fed1b645bbc6b352fd75eea37 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
| 54fbdafc | 01-Feb-2023 |
kirankumarb07 <kirankumarb@ami.com> |
OWNERS: add Kirankumar Ballapalli
Propose myself (Kirankumar Ballapalli) as an additional maintainer. I have contributed following patches to the webui-vue package. [1] commits: https://gerrit.openb
OWNERS: add Kirankumar Ballapalli
Propose myself (Kirankumar Ballapalli) as an additional maintainer. I have contributed following patches to the webui-vue package. [1] commits: https://gerrit.openbmc.org/q/owner:kirankumarb%2540ami.com
Change-Id: Ifcb12a4bdb6b3365860fbe264c1b79bbf6d23a8a Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com> Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
| 29aaa9e8 | 06-Jun-2023 |
Gunnar Mills <gmills@us.ibm.com> |
Maintainership: Remove Sandeepa
Sandeepa has left the project. Thank you for all the work on OpenBMC!
Change-Id: I6e2a68f56a6730c93cbe5aaec8b5476700e574c2 Signed-off-by: Gunnar Mills <gmills@us.ibm
Maintainership: Remove Sandeepa
Sandeepa has left the project. Thank you for all the work on OpenBMC!
Change-Id: I6e2a68f56a6730c93cbe5aaec8b5476700e574c2 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
| 60da0f57 | 06-Jun-2023 |
Gunnar Mills <gmills@us.ibm.com> |
Fix up README
AngularJS is end of life, correct that. Recommend switching from phosphor-webui. Further minor README improvements.
Change-Id: I5067a9b5c6fc775bfa684fa1af4cb9a8142629dc Signed-off-by:
Fix up README
AngularJS is end of life, correct that. Recommend switching from phosphor-webui. Further minor README improvements.
Change-Id: I5067a9b5c6fc775bfa684fa1af4cb9a8142629dc Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
| 780733a1 | 19-Apr-2023 |
Thang Q. Nguyen <thang@os.amperecomputing.com> |
Fix logout button not work on Safari
After logged on via Safari web browser, click <user> -> Log out button does not take effect until clicking on other tab. The current page still works normally. F
Fix logout button not work on Safari
After logged on via Safari web browser, click <user> -> Log out button does not take effect until clicking on other tab. The current page still works normally. For example, in Virtual Media page, after clicking on the Log out button, nothing happens and we can still mount ISO file. The issue does not happen on Chrome or Firefox.
Fix the issue by changing router.go() to router.push().
Reference: https://github.com/vuejs/vue-router/issues/2554 https://codewithandrea.com/articles/flutter-navigation-gorouter-go-vs-push/
Tested: 1. Check if the issue does not happen on Safari anymore. 2. Check if no issue with Google Chrome and Mozilla Firefox.
Change-Id: I2ae35dad2dec6b19c3cb9d7f8d577b6077ac8d9c Signed-off-by: Thang Q. Nguyen <thang@os.amperecomputing.com> Signed-off-by: HuyLe <hule@amperecomputing.com>
show more ...
|
| 2dabfc1b | 29-Mar-2023 |
kirankumarb07 <kirankumarb@ami.com> |
Add session timeout in Policies page
This patchset will provide the option to configure the session timeout for the WebUI. The functionality will provide the below timeout options to configure.
Add session timeout in Policies page
This patchset will provide the option to configure the session timeout for the WebUI. The functionality will provide the below timeout options to configure. 1. 30 minutes 2. 1 hour 3. 2 hours 4. 4 hours 5. 8 hours 6. 1 Day For the API, redfish is having the following resource. URL - /redfish/v1/SessionService Method - GET (to get the configured timeout) - PATCH (to configure the timeout value) Property - { "SessionTimeout": 1800 }
When the user idles up until the configured session timeout, after that any API call from this session will get 401 status and the web UI will gets logged out.
Change-Id: Ic7c6b4817e560ca4ceb983dc5e2af51f3ae08cf5 Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
show more ...
|
| 0f6147ca | 12-Apr-2023 |
Sivaprabu Ganesan <sivaprabug@ami.com> |
Display eventlog status button based on condition
Resolved and Unresolved status button in event log page is shown or hidden based on the environment variable VUE_APP_EVENT_LOGS_TOGGLE_BUTTON_DISABL
Display eventlog status button based on condition
Resolved and Unresolved status button in event log page is shown or hidden based on the environment variable VUE_APP_EVENT_LOGS_TOGGLE_BUTTON_DISABLED
Change-Id: If99a9705d4690995fb998daa979c21c61c3cc4a7 Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>
show more ...
|
| 6c5418f5 | 25-Feb-2022 |
MichalX Szopinski <michalx.szopinski@intel.com> |
Remove hardcoded chassis from Fan store
This change removes the hardcoded chassis URL from FanStore. Now the URL is taken from the odata.id.
Signed-off-by: MichalX Szopinski <michalx.szopinski@inte
Remove hardcoded chassis from Fan store
This change removes the hardcoded chassis URL from FanStore. Now the URL is taken from the odata.id.
Signed-off-by: MichalX Szopinski <michalx.szopinski@intel.com> Change-Id: I59e4d46a8aaa453f6662f4f396f32d7fad18fb91
show more ...
|
| 6b424f99 | 10-Mar-2023 |
greenfil <mikl@greenfil.ru> |
Added the use of HttpPushUri
According to the Redfish specification, the address to update the firmware is set in redfish/v1/UpdateService with the HttpPushUri variable. ``` https://github.com/openb
Added the use of HttpPushUri
According to the Redfish specification, the address to update the firmware is set in redfish/v1/UpdateService with the HttpPushUri variable. ``` https://github.com/openbmc/bmcweb/commit/4dc23f3fb6c9a7cef84658f8ab3b703d29ec7d57 ```
Change-Id: I29566a8ab2d06b658ab62f61c34be00fbbba0571 Signed-off-by: greenfil <mikl@greenfil.ru>
show more ...
|
| 7c26338e | 13-Feb-2023 |
Glukhov Mikhail <mikl@greenfil.ru> |
Added a "solved" check
Now Health status will be "Ok" if there are no unsolved problems in the log. Before this patch, the flag "solved" was not considered. Test: Created a log entry with the status
Added a "solved" check
Now Health status will be "Ok" if there are no unsolved problems in the log. Before this patch, the flag "solved" was not considered. Test: Created a log entry with the status of "Critical" and "Warning". Health became Critical. Event Critical pressed Resolved. Health became "Warning". Event Warning pressed Resolved. Health became "Ok".
Change-Id: Ic74a4c488c1c806c478c562a17fc0bb132e66e8f Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>
show more ...
|
| 2f2f64d2 | 05-Dec-2022 |
Damian Celico <damianx.celico@intel.com> |
Fixed endpoint for Power PowerControl
Saving power cap value was throwing an error, and it was caused by incorrect endpoint to PowerControl resource in Redfish: https://redfish.dmtf.org/schemas/v1/P
Fixed endpoint for Power PowerControl
Saving power cap value was throwing an error, and it was caused by incorrect endpoint to PowerControl resource in Redfish: https://redfish.dmtf.org/schemas/v1/Power.v1_7_1.json
Fixed endpoint for saving Power Cap value
Signed-off-by: Damian Celico <damianx.celico@intel.com> Change-Id: Ib9117f62548c55eb3f07562b71330675a2101924
show more ...
|
| 8890db89 | 21-Mar-2023 |
Glukhov Mikhail <mikl@greenfil.ru> |
Don't count solved problems in Overview
At the moment, the Overview page shows the total number of log errors and warnings, even if they are marked as "resolved". After the patch, only unresolved er
Don't count solved problems in Overview
At the moment, the Overview page shows the total number of log errors and warnings, even if they are marked as "resolved". After the patch, only unresolved errors and warnings are counted. Test: Created an error event and a warning event in the log. The Overview page displays 1 and 1. Marked them as resolved. The Overview page displays 0 and 0.
Change-Id: I8ee1122bbec3e678d33edfbd2035d02553fb64ea Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>
show more ...
|
| e21b2fed | 31-Mar-2023 |
kirankumarb07 <kirankumarb@ami.com> |
Filter the event log data by severity and status
In the event logs page, if the filter options are selected for both severity and status, it displays row that falls into either of the two categories
Filter the event log data by severity and status
In the event logs page, if the filter options are selected for both severity and status, it displays row that falls into either of the two categories: severity or status.
The filter options are in two categories: severity [OK, Warning, Critical], and status [Resolved, Unresolved]
If select the filter options "Critical" on severity and "Unresolved" on status, it shows every row whose status is "Unresolved" whether its severity is "Ok" or "Warning", If the row data is "Critical" or "Unresolved", it shows in the table. As per the filter selection, it shouldn't show the row data that has "Ok" or "Warning" but the status is "Unresolved"; it should show only the row data that is in both "Critical" and "Unresolved".
This commit will work as follows: if different categories are selected, that will be applied with an "and" logic, and within the same category, it will be applied with an "or" logic.
Change-Id: I5ddf6e5ebe35c961306e68885febf6f2324ebaee Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
show more ...
|
| 5905f96b | 07-Jun-2021 |
MichalX Szopinski <michalx.szopinski@intel.com> |
Handle API error messages on add/edit user
Display API error messages on Local user managment tab.
Change-Id: I8ffe2359aa454503d07e8895907202bd0d8493f5 Signed-off-by: MichalX Szopinski <michalx.szo
Handle API error messages on add/edit user
Display API error messages on Local user managment tab.
Change-Id: I8ffe2359aa454503d07e8895907202bd0d8493f5 Signed-off-by: MichalX Szopinski <michalx.szopinski@intel.com>
show more ...
|
| 80d697d8 | 27-Mar-2023 |
Ed Tanous <edtanous@google.com> |
Fix popup-box authenticate on session disconnect
On the session Web UI page, when we disconnect the current session, instead of navigating to the login page, the browser populates the authentication
Fix popup-box authenticate on session disconnect
On the session Web UI page, when we disconnect the current session, instead of navigating to the login page, the browser populates the authentication window for basic authorization.
If basic authentication is enabled, we are adding the www-authenticate header to unauthorizing requests.
As per redfish, we have to set the "Accept" and "X-Requested-With" header for the request from Web UI. This patch set will add those headers.
Tested:
Logged in to the WebUI and navigated to the sessions page. Clicked "Disconnect" to the current session and the WebUI is navigated to login. page as expected.
Change-Id: I61cccbf41e854683e6cd5aa80fa72593ae4aa698 Signed-off-by: Ed Tanous <edtanous@google.com>
show more ...
|
| bcb0ab4f | 22-Aug-2022 |
Damian Celico <damianx.celico@intel.com> |
Old password input in change password screen
When the user changed their password in profile settings, to prevent XSS attacks, I added the current password input field to authenticate the user.
Onc
Old password input in change password screen
When the user changed their password in profile settings, to prevent XSS attacks, I added the current password input field to authenticate the user.
Once the authentication had success with the current password, then allowing the update was possible. After the password is changed successfully, all the sessions of the user who changed the password will be disconnected, including the current session. and the current session will navigate to the login page.
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com> Change-Id: Idb8bc9d6ada420329c38407da76a08dc83fddd61
show more ...
|
| 095bb6dd | 22-Mar-2023 |
Konstantin Aladyshev <aladyshev22@gmail.com> |
RU: Correct 'successSaveNetworkSettings' translation
Since %{settings} template variable in this case takes values like 'DHCP' or 'IPv4' the translation string needs minor correction.
Change-Id: I9
RU: Correct 'successSaveNetworkSettings' translation
Since %{settings} template variable in this case takes values like 'DHCP' or 'IPv4' the translation string needs minor correction.
Change-Id: I987e3a8a60fd3f1bba163fcf81904dda303fe036 Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
show more ...
|
| aced36e8 | 22-Mar-2023 |
Konstantin Aladyshev <aladyshev22@gmail.com> |
RU: Added DHCP enable/disable feature
Add russian translations that were missed in a commit e8cb2c6a81e8abb75cb63c10c29008d868e7fef2 ("Added DHCP enable/disable feature").
Change-Id: Ida37e9864f124
RU: Added DHCP enable/disable feature
Add russian translations that were missed in a commit e8cb2c6a81e8abb75cb63c10c29008d868e7fef2 ("Added DHCP enable/disable feature").
Change-Id: Ida37e9864f12424011c8c1b12eb1cac126672112 Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
show more ...
|
| 6ad19aac | 21-Mar-2023 |
kirankumarb07 <kirankumarb@ami.com> |
Fix User Management Page issues title and Policy
This patchset will fix the following issues in the user management page
1. "lockoutThreshold" and "lockoutDuration" values are not shown in the acco
Fix User Management Page issues title and Policy
This patchset will fix the following issues in the user management page
1. "lockoutThreshold" and "lockoutDuration" values are not shown in the account policy model when we navigate to any other page and come back to the user management page account policy model. Fix - The "lockoutThreshold" and "lockoutDuration" values are monitored and updated in the model window by using the watch. When navigated from another page, the watch is not updating the values, so the default values are displayed. Initialized the value with an empty object, so the watch will get triggered and update the fields with proper values.
2. The User Management Page title is not translated properly. The router names are used to map each page's language objects. For the user management page, the router name and the object value in the locale file are different. Due to that, the title did not get translated properly. Fix - Changed the user management page title to match the locale file's language object key value.
Change-Id: I1582c9d528633465c65f5d78e31d3dc740252cb0 Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
show more ...
|
| aeb19816 | 23-Nov-2022 |
Damian Celico <damianx.celico@intel.com> |
Added route restrictions based on user privilege
This commit allows us to add 'exclusiveToRoles' field to route config files, with the list of roles that can access this resource, if needed. In this
Added route restrictions based on user privilege
This commit allows us to add 'exclusiveToRoles' field to route config files, with the list of roles that can access this resource, if needed. In this case, only Administrator can access Virtual-Media page and SOL console, and it is blocked for other users.
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com> Change-Id: Ibcee18bd92d97c34414ecaf2caf6af28070c5538
show more ...
|
| 568b8a93 | 14-Feb-2023 |
kirankumarb07 <kirankumarb@ami.com> |
Sessions page Client ID is not displayed
Redfish added support for the Context parameter on the session resource This parameter has the same function that the "OemSession.ClientId" field served. And
Sessions page Client ID is not displayed
Redfish added support for the Context parameter on the session resource This parameter has the same function that the "OemSession.ClientId" field served. And BMC Web moves all the existing ClientId code to produce Context. This patch set contains the code changes for adding a new column "Context" in the sessions page and modifying the existing column "Client ID" to "Session ID" and mapping the redfish property "Id" to it.
The property "Context" is optional in redfish. If the Context holds any value it will display in WebUI as it is. If it is not having any value, "-" will be displayed in the WebUI.
Change-Id: Ibc99416fc37a91029bf430ccc7b387832eef729c Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
show more ...
|
| e78d10b7 | 03-Mar-2023 |
kirankumarb07 <kirankumarb@ami.com> |
After the session expired redirect to login page
If the user switches pages between the KVM and Virtual Media pages after the session has expired, it won't redirect to the login page.
So I have add
After the session expired redirect to login page
If the user switches pages between the KVM and Virtual Media pages after the session has expired, it won't redirect to the login page.
So I have added the system redfish API call in the create method to check the session timeout status. If the session is expired, the API call will get a 401 status, and WEBUI will be redirected to the login page.
Change-Id: I069768ee0cef41afb4e6aa770bb8bec6565a16bd Signed-off-by: Kirankumarb07 Ballapalli <kirankumarb@ami.com>
show more ...
|
| e4d54c6c | 08-Mar-2023 |
Gunnar Mills <gmills@us.ibm.com> |
Add Nikhil as a reviewer
Nikhil has contributed to webui-vue and continues to give review feedback.
https://gerrit.openbmc.org/q/owner:a.nikhil%2540ibm.com
Change-Id: Id0bcbf82e17fcf8204a13468572f
Add Nikhil as a reviewer
Nikhil has contributed to webui-vue and continues to give review feedback.
https://gerrit.openbmc.org/q/owner:a.nikhil%2540ibm.com
Change-Id: Id0bcbf82e17fcf8204a13468572fa21b40ba6ad1 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
| 5d95418c | 09-Mar-2023 |
kirankumarb07 <kirankumarb@ami.com> |
Fix pre commit script break
There is no validation handle before checking the page title name from the router. Which causes the pre-commit script to through error. This patch set will handle this sc
Fix pre commit script break
There is no validation handle before checking the page title name from the router. Which causes the pre-commit script to through error. This patch set will handle this scenario and fix the break.
Change-Id: I5aed3bfeba643c2eb2b2753bf8f6d984b5100361 Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
show more ...
|
| 373d243c | 15-Dec-2022 |
Chandra Harkude <chandramohan.harkude@gmail.com> |
Fixed calling method "handleSubmit" two times
Problem : "handleSubmit" called on clicking Ok button implicitly as well by the form (<b-form id="generate-csr-form" novalidate @submit.prevent= "handle
Fixed calling method "handleSubmit" two times
Problem : "handleSubmit" called on clicking Ok button implicitly as well by the form (<b-form id="generate-csr-form" novalidate @submit.prevent= "handleSubmit"), due to this, redfish API POST /redfish/v1/CertificateService/Actions/Certificate Servi ce.GenerateCSR sent two times when "Generate CSR" button clicked,ideally redfish API needs to be sent only once This leads to failure of the second redfish API.
Steps to Reproduce Issue:
1. Go to 'Login->Security and access->Certificate->Generate CSR fill the form 2. Click on 'Generate CSR.' 3. Scroll down to 'More Tools->Web Developer Tools->Network tab' 4. Two POST /redfish/v1/CertificateService/Actions/CertificateService. GenerateCSR are sent
Solution: The issue can be fixed either by deleting the Ok button click event listener or deleting the (@submit.prevent="handleSubmit"). I have used later one, which is small change as well does not alter the code much
Tested : I did manual testing and observed that two POST requests are no longer sent Reference : https://softauthor.com/vuejs-prevent-form-submission/
Signed-off-by: Chandra Harkude <chandramohan.harkude@gmail.com> Change-Id: I8736e597d2fe70aef438779667475426837d2c67
show more ...
|