69be824a | 23-Sep-2024 |
Surya Venkatesan <suryav@ami.com> |
Invalid feedback if condition change
For required, invalid format, minlength, maxlength, date, pattern validation if condition change in the few components
Change-Id: Id8eebc140301e48dde833a604ca92
Invalid feedback if condition change
For required, invalid format, minlength, maxlength, date, pattern validation if condition change in the few components
Change-Id: Id8eebc140301e48dde833a604ca92426ebf77c9c Signed-off-by: Surya Venkatesan <suryav@ami.com>
show more ...
|
de23ea23 | 11-Jul-2024 |
Surya V <suryav@ami.com> |
Vuelidate, I18n, and filter are upgraded to vue3
While navigating to the pages i18n, vuelidate, and filters errors occurred. i18n, and vuelidate code changes in each page adapted to vue3. Filter glo
Vuelidate, I18n, and filter are upgraded to vue3
While navigating to the pages i18n, vuelidate, and filters errors occurred. i18n, and vuelidate code changes in each page adapted to vue3. Filter global function for date and time format implemented in the main.js file and those files which as called the filter functions.
Change-Id: If1a2ee22d47750faef1c35ef2c263299067d9a20 Signed-off-by: Surya Venkatesan <suryav@ami.com>
show more ...
|
7d6b44cb | 23-Mar-2024 |
Ed Tanous <ed@tanous.net> |
Upgrade vue3 and all dependencies
Start the process of porting everything to Vue 3. I have most things working. npm run-scripts build works, npm install works. prettier passes. Styles load, logi
Upgrade vue3 and all dependencies
Start the process of porting everything to Vue 3. I have most things working. npm run-scripts build works, npm install works. prettier passes. Styles load, login works, webui loads.
This was primarily done using the linked documents below. It makes the following design decisions: 1. Vue is put in compat 2 mode, which allows most of the components to work as-is. 2. Bootstrap v4 is used along with bootstrap-vue to keep our components working. 3. Minor changes are made to load the latest versions of vue-router, vuex, and vue-i18n.
I suspect this patchset is good enough to start with, and we can clean up the broken things one patchset at a time. The things that need to happen are:
1. Get remaining features working again. This primiarily is vue-i18n for mixins, and non vue components. This likely needs to be done by not pulling in i18n into the non vue components, then using the .Vue files to do the internationalization in the component context, NOT in the mixin context. Alternatively, we could drop MixIns alltogether. 2. Get custom styles working again. Previously, we used some path hackery in vue.config.js to optionally pre-load styles. This stops working now that we're required to @import our modules. Likely we need some rearangement of the paths such that custom styles are a complete replacement (possibly importing the original) rather than additive with overrides. That's a guess, but I don't really see anyone else doing customization the way we've defined it here. 3. Bootstrap 5 no longer requires ANY custom vue modules, as it has dropped the jquery dependency. We won't be able to pull in bootstrap 5 all at once, so pull in bootstrap 5 under an alias, like "bootstrap5" that we can optionally import 5 or 4. 4. One at a time, start porting components over to Vue3 syntax and bootstrap 5. This will be the bulk of the manual work and review.
The only thing I think left is getting unit tests passing, which I commented out the pre-commit hook to make this PR.
Tested: Code builds. Needs better testing.
[1] https://router.vuejs.org/guide/migration/ [2] https://vue-i18n.intlify.dev/guide/migration/vue3 [3] https://vuelidate-next.netlify.app/migration_guide.html#package-name-and-imports
Change-Id: I5bb3187b9efbf2e4ff63e57994bc528756e2a981 Signed-off-by: Ed Tanous <ed@tanous.net>
show more ...
|
8841b7d4 | 15-Jun-2024 |
Sean Zhang <xiazhang@nvidia.com> |
Replace fixed paths with response from API
Currently, the Redfish request used fixed URIs, modify the code to use the BMC and System paths got from response of API calls. For CertificateStore, since
Replace fixed paths with response from API
Currently, the Redfish request used fixed URIs, modify the code to use the BMC and System paths got from response of API calls. For CertificateStore, since it was using the URL for constant variable assignment, changed the constant CERTIFICATE_TYPES to method call.
Change-Id: I330b7272083e3e6993aae5705aae170b8e9a4659 Signed-off-by: Sean Zhang <xiazhang@nvidia.com>
show more ...
|
dfba4e54 | 23-Apr-2024 |
Vedangi Mittal <vedangimittal@vedangis-mbp.in.ibm.com> |
Removed Challenge password option from Generate CSR panel
- Unable to generate Certificate Signing Request (CSR) when filling optional field-Challenge password values on Certificate page. - Hence,
Removed Challenge password option from Generate CSR panel
- Unable to generate Certificate Signing Request (CSR) when filling optional field-Challenge password values on Certificate page. - Hence, removed the Challenge password option from the Generate CSR panel.
Change-Id: I862f024de84f34738be5e5cd22701b63c2309152 Signed-off-by: Vedangi Mittal <vedangimittal3004@gmail.com>
show more ...
|
d1ef18e6 | 06-Apr-2024 |
Paul Fertser <fercerpav@gmail.com> |
Focus default action in modal windows
Users of common WIMP GUIs (as opposed to interfaces primarily meant for touch input) expect dialog boxes to have keyboard focus set on the button for default ac
Focus default action in modal windows
Users of common WIMP GUIs (as opposed to interfaces primarily meant for touch input) expect dialog boxes to have keyboard focus set on the button for default action so that it can be executed by a single key press. Usually that is chosen to proceed with the operation but in cases where that leads to data loss the UI designers often pre-select Cancel as a precaution.
This patch adds suitable property to all invocations of msgBoxConfirm() method of `this.$bvModal` BootstrapVue object. For regular actions the confirmation button is selected and can be activated by Enter or Space bar. For actions deemed dangerous Cancel is focused instead so it takes two key presses (first being Tab to shift the focus) to prooceed.
This also improves accessibility following the Web Content Accessibility Guidelines (WCAG) published by W3C.
Tested: manually verified that modals are consistently shown with the specified button focused, Enter and Space bar key presses produce the same effect as left pointer button click: when Cancel is focused it just closes the window, when OK is focused it sends the corresponding request to the Redfish endpoint.
Change-Id: I66bfd02e48e08dc18994b11bbdd5d6b3ea27047f Signed-off-by: Paul Fertser <fercerpav@gmail.com>
show more ...
|
8132399c | 27-Feb-2024 |
Ed Tanous <ed@tanous.net> |
Reformat files with new linter
All changes should be whitespace, and were done using npm run-script lint.
Change-Id: I943c6b435c5c872841af5affc1e89910468b5ca6 Signed-off-by: Ed Tanous <ed@tanous.ne
Reformat files with new linter
All changes should be whitespace, and were done using npm run-script lint.
Change-Id: I943c6b435c5c872841af5affc1e89910468b5ca6 Signed-off-by: Ed Tanous <ed@tanous.net>
show more ...
|
373d243c | 15-Dec-2022 |
Chandra Harkude <chandramohan.harkude@gmail.com> |
Fixed calling method "handleSubmit" two times
Problem : "handleSubmit" called on clicking Ok button implicitly as well by the form (<b-form id="generate-csr-form" novalidate @submit.prevent= "handle
Fixed calling method "handleSubmit" two times
Problem : "handleSubmit" called on clicking Ok button implicitly as well by the form (<b-form id="generate-csr-form" novalidate @submit.prevent= "handleSubmit"), due to this, redfish API POST /redfish/v1/CertificateService/Actions/Certificate Servi ce.GenerateCSR sent two times when "Generate CSR" button clicked,ideally redfish API needs to be sent only once This leads to failure of the second redfish API.
Steps to Reproduce Issue:
1. Go to 'Login->Security and access->Certificate->Generate CSR fill the form 2. Click on 'Generate CSR.' 3. Scroll down to 'More Tools->Web Developer Tools->Network tab' 4. Two POST /redfish/v1/CertificateService/Actions/CertificateService. GenerateCSR are sent
Solution: The issue can be fixed either by deleting the Ok button click event listener or deleting the (@submit.prevent="handleSubmit"). I have used later one, which is small change as well does not alter the code much
Tested : I did manual testing and observed that two POST requests are no longer sent Reference : https://softauthor.com/vuejs-prevent-form-submission/
Signed-off-by: Chandra Harkude <chandramohan.harkude@gmail.com> Change-Id: I8736e597d2fe70aef438779667475426837d2c67
show more ...
|
713dae09 | 14-Nov-2022 |
Damian Celico <damianx.celico@intel.com> |
Added popup window with error message
Showing error message if uploaded certificate is incorrect
Signed-off-by: Damian Celico <damianx.celico@intel.com> Change-Id: Ifa034e663329e4841ff5c68f6171ce71
Added popup window with error message
Showing error message if uploaded certificate is incorrect
Signed-off-by: Damian Celico <damianx.celico@intel.com> Change-Id: Ifa034e663329e4841ff5c68f6171ce71739a6d13
show more ...
|
c72f1e3e | 06-Jan-2023 |
Sivaprabu Ganesan <sivaprabug@ami.com> |
Added encodeURIComponent to CSR certificate
Description 1: Downloading the CSR certificate data value without encodeURIComponent function is not supported in Firefox So added the encodeURIComponent
Added encodeURIComponent to CSR certificate
Description 1: Downloading the CSR certificate data value without encodeURIComponent function is not supported in Firefox So added the encodeURIComponent function to download the csr certificate
Tested: Step 1: Launch WEBUI on firefox Step 2: Navigate to Security and access, Certificates Page Step 3: Generate and Download CSR certificate (KeyPair Algorithm - EC and Key curve id - secp521r1) Step 4: After CSR Downloaded, copy the downloaded file to any of the linux machine Step 5: Try to create an https/ldap certificate via openssl on linux machine
Result: Able to download the CSR certificate successfully and able to create https/ldap certificate via openssl
Description 2: While downloading the generated csr via Web UI, the csr file is getting downloaded as ".txt" file but it should download as ".csr" file So changed the extension to ".csr"
Tested: Step 1: Login to Web UI. Step 2: Navigate to Security and access, Certificates Page Step 3: Click Generate CSR Button and fill the required details Step 4: Click Generate CSR from the popup modal. Step 5: After CSR Generated an prompt will open and it will show download and copy option. In that select download, the csr certificate will download with ".csr" extension
Change-Id: Ice176006a95afd53845d7696ce0eac88f02b1096 Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>
show more ...
|
31fb2b96 | 27-Jun-2022 |
Damian Celico <damianx.celico@intel.com> |
Check certificate file extension
Checking the file extension type of uploaded certificates to redfish. Sends the file only if the file type is correct, otherwise shows error.
Signed-off-by: Damian
Check certificate file extension
Checking the file extension type of uploaded certificates to redfish. Sends the file only if the file type is correct, otherwise shows error.
Signed-off-by: Damian Celico <damianx.celico@intel.com> Change-Id: Idfc790bc8967333aed66c5c128334af4231dbea3
show more ...
|
41057853 | 27-Dec-2021 |
Kenneth Fullbright <kennyneedsmilky@gmail.com> |
Set table busy state on load
- Add busy prop to tables
Signed-off-by: Kenneth Fullbright <kennyneedsmilky@gmail.com> Change-Id: I4416f12967c9a0ad6c8bb782c7d8de5c17fdd195 |
b440616c | 26-Jul-2021 |
Sandeepa Singh <sandeepa.singh@ibm.com> |
IA update: Update access and control section
This is the fifth commit of the information architecture changes and has the following changes:
- The icon for access and control has been updated - Acc
IA update: Update access and control section
This is the fifth commit of the information architecture changes and has the following changes:
- The icon for access and control has been updated - Access and control section has been updated to security and access section - Security settings page has been updated to policies page and moved to security and access section - Client sessions page has been updated to sessions page - Local user management page has been updated to user management page - SSL certificates page has been updated to certificates page
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com> Change-Id: Ie93cee9002742ecf7d33615636f4f159f4395fc4
show more ...
|