5a2d2bc8 | 30-Nov-2017 |
Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com> |
Updating PS redundancy object path.
Changing the PS redundancy object path from /org/openbmc/sensors/host/PowerSupplyRedundancy to /xyz/openbmc_project/sensors/chassis/PowerSupplyRedundancy since Al
Updating PS redundancy object path.
Changing the PS redundancy object path from /org/openbmc/sensors/host/PowerSupplyRedundancy to /xyz/openbmc_project/sensors/chassis/PowerSupplyRedundancy since All Witherspoon REST API URIs should being with xyz/openbmc_project or org/open_power
Change-Id: Ic1360cef2b4939835d47b995a8542aee598bb939 Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
show more ...
|
86101ea3 | 17-Nov-2017 |
Yong Li <yong.b.li@linux.intel.com> |
Add lseek to support GPIO read/write
GPIO api does not support repeat read(read multi times after one open). A workaround is close and reopen the device before the second read. The root cause is tha
Add lseek to support GPIO read/write
GPIO api does not support repeat read(read multi times after one open). A workaround is close and reopen the device before the second read. The root cause is that the file descriptor is not moved to beginning of the file, this patch can fix this issue
Change-Id: I40e5602669c9ab6f0dddf5aa77040466cbfa3738 Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
show more ...
|
8102f929 | 09-Nov-2017 |
James Feist <james.feist@linux.intel.com> |
Add initial Wfp config to be able to build platform.
Wfp is an Intel platform.
Change-Id: I0991d404f6c5fb8d35d7b524caff0d194d75ee90 Signed-off-by: James Feist <james.feist@linux.intel.com> |
e2691e75 | 09-Nov-2017 |
Lei YU <mine260309@gmail.com> |
Remove pci_reset from Romulus config
The pci_reset GPIOs are not connected on PASS2 Romulus. There is no need to toggle the GPIOs.
Change-Id: I78afa4358e2540d72517d5f2ae953f0e6319db1e Signed-off-by
Remove pci_reset from Romulus config
The pci_reset GPIOs are not connected on PASS2 Romulus. There is no need to toggle the GPIOs.
Change-Id: I78afa4358e2540d72517d5f2ae953f0e6319db1e Signed-off-by: Lei YU <mine260309@gmail.com>
show more ...
|
aa4c3103 | 25-Oct-2017 |
Gunnar Mills <gmills@us.ibm.com> |
Spelling fixes
Change-Id: Ia4ded0c195204543c3df671ea471610237f5f44b Signed-off-by: Gunnar Mills <gmills@us.ibm.com> |
1902990d | 06-Oct-2017 |
Gunnar Mills <gmills@us.ibm.com> |
Add basename for file name in download manager
Added getting the basename for the output file name in download manager. This is to prevent any security holes that would let the user out of the FLASH
Add basename for file name in download manager
Added getting the basename for the output file name in download manager. This is to prevent any security holes that would let the user out of the FLASH_DOWNLOAD_PATH dir. (e.g. passing a file name of ../etc/shadow)
Resolves openbmc/openbmc#1898
Change-Id: Ie33fe56599e86c29da4b2eae8ef070f0866d054c Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
1be4fabd | 15-Oct-2017 |
Andrew Jeffery <andrew@aj.id.au> |
pytools: obmcutil: Add `chassiskill` command
Nick reported an issue where the BMC became unusable after the host hit a bug and began "spewing a lot of messages to the console". Save ourselves some
pytools: obmcutil: Add `chassiskill` command
Nick reported an issue where the BMC became unusable after the host hit a bug and began "spewing a lot of messages to the console". Save ourselves some DBus transactions and immediate execution of systemd transitions by introducing a `chassiskill` command to directly deassert the the power-up GPIO ourselves. This will immediately terminate the host and free up resources for the BMC to become responsive. As a bonus, the PGOOD monitoring will then execute to clean up the resulting inconsistent BMC/Host state for us.
Change-Id: I106a4202b6544b8e78b04938230a4eeee5f132bb Requested-by: Nicholas Piggin <npiggin@gmail.com> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
cf6a784d | 11-Oct-2017 |
Andrew Jeffery <andrew@aj.id.au> |
pytools: obmcutil: Optionally wait for standby before getting objects
If the user passes --wait, try to immediately get the object but wait until we reach standby before trying again if the first at
pytools: obmcutil: Optionally wait for standby before getting objects
If the user passes --wait, try to immediately get the object but wait until we reach standby before trying again if the first attempt fails.
The correct strategy is probably to look for registration of names on the bus, but this ghetto approach also works.
Change-Id: I71b6f5d4fcf5841510da6f9877726b875b019d51 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
08e149bb | 11-Oct-2017 |
Andrew Jeffery <andrew@aj.id.au> |
pytools: obmcutil: Use 'in' test rather than dict.has_key()
Change-Id: I51b4d8a9760e0c73f0c36ff6619a484718db3a4b Signed-off-by: Andrew Jeffery <andrew@aj.id.au> |
81707a1f | 11-Oct-2017 |
Andrew Jeffery <andrew@aj.id.au> |
pytools: obmcutil: Remove unnecessary parentheses
Change-Id: I902c6674111a6c1790d08ddf02819dddeede970d Signed-off-by: Andrew Jeffery <andrew@aj.id.au> |
b43f7ed4 | 11-Oct-2017 |
Andrew Jeffery <andrew@aj.id.au> |
pytools: obmcutil: Implement verbose mode
Verbose output is limited to state change requests at the moment, as they are the operations that take significant amounts of time. Further, the verbose out
pytools: obmcutil: Implement verbose mode
Verbose output is limited to state change requests at the moment, as they are the operations that take significant amounts of time. Further, the verbose output is implemented as following the tail of the journal until the requested state change either succeeds or fails.
In testing it was observed that the journal output tends to lag the DBus event that signals the completion of the state transition. As such the patch adds a tuning parameter defining a further waiting period beyond the receipt of the completion signal so that the verbose output looks "reasonable". The default value of the tuning parameter was roughly chosen to correlate well with the journal output on a Witherspoon system for the `poweron` command.
Change-Id: I847e2bfeba55d6a3d7d1f7ff1ba1901993c9b505 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
de4ed02d | 11-Oct-2017 |
Andrew Jeffery <andrew@aj.id.au> |
pytools: obmcutil: Implement blocking behaviour
The technique to block is to attach a listener for systemd JobRemoved property change events, change the desired OpenBMC state management property to
pytools: obmcutil: Implement blocking behaviour
The technique to block is to attach a listener for systemd JobRemoved property change events, change the desired OpenBMC state management property to trigger the systemd transition, and then run the gobject dbus mainloop. We terminate the mainloop by invoking quit() in the callback on the captured mainloop object.
Additionally, the result of the transition (success or failure) is judged in the callback. We can't obtain the result by returning it, and as we are using Python 2 we cannot meaningfully mutate captured variables to expose it. Instead, a variable is created on the callback function object after it is defined but before the function is invoked, which is mutated inside the function (which can reference its own object) when called. The result is retrieved after the mainloop has terminated and is propagated up the call chain to form the exit status.
Change-Id: Ic19aa604631177abea7580de2357d8c6812ee874 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
bba82bd3 | 11-Oct-2017 |
Andrew Jeffery <andrew@aj.id.au> |
pytools: obmcutil: Use format string for all-props output
Change-Id: I9d803da8c0ff8862039bb5b7adc07952208820d1 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> |
c6b5deb0 | 11-Oct-2017 |
Andrew Jeffery <andrew@aj.id.au> |
pytools: obmcutil: Consistent naming for command descriptors
Change-Id: Ibb6d90dbca9c1bffd7b714dc70342b7927ced94e Signed-off-by: Andrew Jeffery <andrew@aj.id.au> |
0b6883d8 | 11-Oct-2017 |
Andrew Jeffery <andrew@aj.id.au> |
pytools: obmcutil: Use argparse
Change-Id: Id33e3802530aa1bf0cb2af88c16bd94f8bfa219d Signed-off-by: Andrew Jeffery <andrew@aj.id.au> |
da3b35cc | 11-Oct-2017 |
Andrew Jeffery <andrew@aj.id.au> |
pytools: obmcutil: Drop ElementTree and json imports
Change-Id: I2e310eef36eb7bcea58d1567dcf3efe9a9dbeeb8 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> |
7b376e7b | 11-Oct-2017 |
Andrew Jeffery <andrew@aj.id.au> |
pytools: obmcutil: Introduce run_all_commands()
This implements the partner for-loop to the run_one_command() function, moving the implementation out of main(). Again this is to elevate the main() i
pytools: obmcutil: Introduce run_all_commands()
This implements the partner for-loop to the run_one_command() function, moving the implementation out of main(). Again this is to elevate the main() implementation to a higher level of abstraction and reduce cyclomatic complexity.
Change-Id: I0abe5ee026750efd10dafb6f113359f035ba5bd8 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
e4dcaef2 | 11-Oct-2017 |
Andrew Jeffery <andrew@aj.id.au> |
pytools: obmcutil: Introduce run_one_command()
Move the complexity of the for-loop body implementation away from the loop itself. This reduces the general cyclomatic complexity a little and allows f
pytools: obmcutil: Introduce run_one_command()
Move the complexity of the for-loop body implementation away from the loop itself. This reduces the general cyclomatic complexity a little and allows for easier consideration of the implementation in isolation.
Change-Id: Id779dec720d3582cf89cd9981bcfd8b101b0d386 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
554a0e5c | 11-Oct-2017 |
Andrew Jeffery <andrew@aj.id.au> |
pytools: obmcutil: Drop redundant prop assignment and test
Change-Id: I0b1b023aeac7103f0be92201c2475193b0f69e5c Signed-off-by: Andrew Jeffery <andrew@aj.id.au> |
849ebeb7 | 11-Oct-2017 |
Andrew Jeffery <andrew@aj.id.au> |
pytools: obmcutil: Collapse redundant assignment and test
Change-Id: Ie461546c9056829b1b4a081a4031ac91c10e6a42 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> |
1133d8c3 | 11-Oct-2017 |
Andrew Jeffery <andrew@aj.id.au> |
pytools: obmcutil: Drop ability to set properties from the commandline
This was prioritised below the built-in value anyway so I suspect it is an unused feature, especially now that the org.openbmc
pytools: obmcutil: Drop ability to set properties from the commandline
This was prioritised below the built-in value anyway so I suspect it is an unused feature, especially now that the org.openbmc interfaces (and the method feature) have gone away.
Change-Id: Icd5ab91b5fc08b0f6cc461390f4ac39f7e9e41cd Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
39e10da7 | 11-Oct-2017 |
Andrew Jeffery <andrew@aj.id.au> |
pytools: obmcutil: Collapse nested conditions
Change-Id: Idb1f30dc553cfa95b4669df317a5dbac5dbe8966 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> |
fb8e1014 | 11-Oct-2017 |
Andrew Jeffery <andrew@aj.id.au> |
pytools: obmcutil: Assign None to val by default
And remove a now-redundant branch.
Change-Id: I92e91cfb307a98cd60a26e5e5d34bf0ddc384d3f Signed-off-by: Andrew Jeffery <andrew@aj.id.au> |
b40e64be | 11-Oct-2017 |
Andrew Jeffery <andrew@aj.id.au> |
pytools: obmcutil: Properly use format string
This changes the format slightly, but not for the worse in my opinion.
Change-Id: Ie9297c22f8c3ceff4fc56ae567dbdbb0f128dd51 Signed-off-by: Andrew Jeffe
pytools: obmcutil: Properly use format string
This changes the format slightly, but not for the worse in my opinion.
Change-Id: Ie9297c22f8c3ceff4fc56ae567dbdbb0f128dd51 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
47f8ff97 | 11-Oct-2017 |
Andrew Jeffery <andrew@aj.id.au> |
pytools: obmcutil: Drop parentheses from conditions
Change-Id: I85b74febc33e8f44d9df86718ce6e3ba1d6d6933 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> |