sdevent: Support source destroy callbacks

Will be needed to support heap allocated userdata and floating sources.

Change-Id: I927acb3e03fb6c724e762b3ac47cd0d4d297ef87
Signed-off-by: William A. Kenn

sdevent: Support source destroy callbacks

Will be needed to support heap allocated userdata and floating sources.

Change-Id: I927acb3e03fb6c724e762b3ac47cd0d4d297ef87
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

sdevent: Support getting userdata

Will be needed when we start storing the userdata on the heap

Change-Id: I31d2c2b6741d0a4422a79b4d0a752d352121ae3c
Signed-off-by: William A. Kennington III <wak@go

sdevent: Support getting userdata

Will be needed when we start storing the userdata on the heap

Change-Id: I31d2c2b6741d0a4422a79b4d0a752d352121ae3c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

autotools: Remove

Meson is now used to build this package in all of the necessary places.

Change-Id: Ic5155621967fa94ec03eced2193e0d453b174eba
Signed-off-by: William A. Kennington III <wak@google.c

autotools: Remove

Meson is now used to build this package in all of the necessary places.

Change-Id: Ic5155621967fa94ec03eced2193e0d453b174eba
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

meson: Use declare_dependency for libraries

Now example binaries and tests don't have to be aware of the nuances for
configuring the build to use the library. This makes the project library
look lik

meson: Use declare_dependency for libraries

Now example binaries and tests don't have to be aware of the nuances for
configuring the build to use the library. This makes the project library
look like any other system dependency.

Change-Id: Ife3bcd3dcbd423f08c513f9a05fc8cabff41e2f6
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

meson: Style fix

Change-Id: I9b4b86ecfab6649671b24d957bd47c7e8e375e21
Signed-off-by: William A. Kennington III <wak@google.com>

source/base: Fix docs for owning constructor

Change-Id: I22667a652bc4db8afc05aea1736b678a213a7e89
Signed-off-by: William A. Kennington III <wak@google.com>

source/base: sourceCallback forward reference type information

Change-Id: I2006ae1a116ec9a664d0dd3b56ed5242f8dbd469
Signed-off-by: William A. Kennington III <wak@google.com>

internal/utils: performCallback should preserve argument references

Arguments including the function are now passed with reference types
forwarded.

Change-Id: I32cf4704737faa6c140d16352528ceb0d738f

internal/utils: performCallback should preserve argument references

Arguments including the function are now passed with reference types
forwarded.

Change-Id: I32cf4704737faa6c140d16352528ceb0d738f5b8
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

example/heartbeat: Add signal handling

This makes the example a little more interesting as we now have multiple
sources and we can analyze memory safety with valgrind by just sending a
SIGINT to qui

example/heartbeat: Add signal handling

This makes the example a little more interesting as we now have multiple
sources and we can analyze memory safety with valgrind by just sending a
SIGINT to quit cleanly.

Change-Id: Id15fe58f798d3b137f91228025f48a5e4cd5fc50
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

sdevent: Fix missing parameter names

Change-Id: I46fb9436fa955ea7c5a3f2319a4332925ef33729
Signed-off-by: William A. Kennington III <wak@google.com>

tree-wide: Use cexec for checking calls

This makes error handling guaranteed and slightly more compact.

Tested:
Ran through unit test suite.

Change-Id: If12cf25302390e5e5238f80b4fdb7ea577b5b5c

tree-wide: Use cexec for checking calls

This makes error handling guaranteed and slightly more compact.

Tested:
Ran through unit test suite.

Change-Id: If12cf25302390e5e5238f80b4fdb7ea577b5b5c8
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

source/base: Remove unused ref constructor

We don't ever use this constructor and it was effectively package
private. Remove it as we don't ever need to add references to our
sd_event_source*.

Test

source/base: Remove unused ref constructor

We don't ever use this constructor and it was effectively package
private. Remove it as we don't ever need to add references to our
sd_event_source*.

Tested:
Built and run through unit test suite.

Change-Id: I1ca9fd4ecfdef1a3fd5aa2ca214be657c1a04b94
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

internal/sdref: Remove in favor of stdplus/handle

We no longer need to roll our own managed handle type now that stdplus
implements a generic one.

Tested:
Built and run through unit tests.

Cha

internal/sdref: Remove in favor of stdplus/handle

We no longer need to roll our own managed handle type now that stdplus
implements a generic one.

Tested:
Built and run through unit tests.

Change-Id: Id34cd8d3ffacf7901d49cac335fa93f744f0e310
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

tree-wide: Use get() helper instead of direct access

This makes it easier to refactor the handle used to hold the pointers.

Change-Id: Ie6eaf9cab998039f18d61a6321774a3db3fa5564
Signed-off-by: Willi

tree-wide: Use get() helper instead of direct access

This makes it easier to refactor the handle used to hold the pointers.

Change-Id: Ie6eaf9cab998039f18d61a6321774a3db3fa5564
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

meson: Add version to library

Otherwise bitbake will treat it as a private library and not move it to
the proper directory and generate the necessary shlib metadata.

Change-Id: Ibc1409fd63ff1d73ef9

meson: Add version to library

Otherwise bitbake will treat it as a private library and not move it to
the proper directory and generate the necessary shlib metadata.

Change-Id: Ibc1409fd63ff1d73ef97e9fb7ed4aa370807c0a9
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

autotools: Fix for autoconf-archive 2019.01.19

The code coverage macros from the archive changed in a backward
incompatible way. This adds a workaround to autodetect either version
and do the right

autotools: Fix for autoconf-archive 2019.01.19

The code coverage macros from the archive changed in a backward
incompatible way. This adds a workaround to autodetect either version
and do the right thing

Change-Id: Ic010ed59fb332e19e5c76f60e55f864f8f4a43f8
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

clang-tidy: Basic configuration

This also cleans up some outstanding issues detected by the
configuration.

Tested:
Ran through unit test scripts.

Change-Id: I3357a2280a681a87532d6d72315260db2a

clang-tidy: Basic configuration

This also cleans up some outstanding issues detected by the
configuration.

Tested:
Ran through unit test scripts.

Change-Id: I3357a2280a681a87532d6d72315260db2ab73e87
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

meson: Add alternative build system

For now both autotools and meson will be maintained side by side.
Eventually we should remove the autotools build system.

Change-Id: I04382b17d5267ee218e2658fc16

meson: Add alternative build system

For now both autotools and meson will be maintained side by side.
Eventually we should remove the autotools build system.

Change-Id: I04382b17d5267ee218e2658fc163da17853f637a
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

utility/timer: Implement callback setting

All of the other classes that take callbacks support having the callback
updated.

Tested:
Builds and passed through the unit test suite.

Change-Id: I0

utility/timer: Implement callback setting

All of the other classes that take callbacks support having the callback
updated.

Tested:
Builds and passed through the unit test suite.

Change-Id: I0efcd074523fa6ec0cc84c7a930346dd9340f7ec
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

utility/timer: Make movable

Now that we can update the callbacks of our sources, we can move the
timer object freely by updating the callback when moved.

Tested:
Unit tests pass, and we no long

utility/timer: Make movable

Now that we can update the callbacks of our sources, we can move the
timer object freely by updating the callback when moved.

Tested:
Unit tests pass, and we no longer see any valgrind issues when
moving the timer object.

Change-Id: I15baf97538459ca8b9c48b75dba77d09b7b5075b
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

source/*: Make updating callbacks possible

Sometimes callers want to be able to update the callback used when the
source is acted upon. This is needed for updating references stored in
the callback.

source/*: Make updating callbacks possible

Sometimes callers want to be able to update the callback used when the
source is acted upon. This is needed for updating references stored in
the callback.

Tested:
Run through the unit test suite.

Change-Id: I78bda32569287964bfc9d49501869d3a2b497f3d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

clock: Make it possible to move assign

When the internal Event is const, it makes it impossible to generate the
implicit move constructors since moving an Event is non-const.

Tested:
Object is

clock: Make it possible to move assign

When the internal Event is const, it makes it impossible to generate the
implicit move constructors since moving an Event is non-const.

Tested:
Object is now movable by containers. This was verified by using a
future commit that requires movability of timers.

Change-Id: Id9859806899443e3daf425dacd4bd23fe9a52f58
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

utility/timer: Make it possible to get the Event

Other event sources expose the ability to get th event used for
constructing the source. Since our timer is basically just a time
source, we should b

utility/timer: Make it possible to get the Event

Other event sources expose the ability to get th event used for
constructing the source. Since our timer is basically just a time
source, we should be able to trivially get the event object.

Tested:
Built and run through unit tests

Change-Id: I4b4192797652a903cba90d6e73771014df7702d6
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

source/signal: Clarify signal bocking during construction

Blocking signals is a potentially unexpected requirement of the user
prior to constructing a signal source. Clarify this requirement base on

source/signal: Clarify signal bocking during construction

Blocking signals is a potentially unexpected requirement of the user
prior to constructing a signal source. Clarify this requirement base on
guidance from the sd_event_add_signal(3) docs.

Change-Id: I34335f1882acbf54a3219324e4e23e803a763365
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

utility/timer: Implement oneshot timers

This change is meant to enable users of the old openbmc timer class to
trivially use the timer if they only want single executions. It also
makes setting up t

utility/timer: Implement oneshot timers

This change is meant to enable users of the old openbmc timer class to
trivially use the timer if they only want single executions. It also
makes setting up the timer less verbose if you do not already know the
timeout interval.

Tested:
Run through unit tests and did a sample integration with
phosphor-watchdog and phosphor-networkd. Verified that the new
oneshot example works as expected.

Change-Id: I2cd006d1f19fff99bce3f732a16eac9ca9553666
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...